MightyPork/airsonic-custom
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,342 Commits 2 Branches 0 Tags
f476fd7c333df1710156490b18163c0c0eec5fc4
Commit Graph
53 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Evan Harris f476fd7c33 Added checkstyle for trailing whitespace 2019-12-06 03:10:06 -06:00
Evan Harris 1651e14bf5 Merge branch 'origin/pr/1365' 2019-11-20 05:18:40 -06:00
Evan Harris f62617df56 Added refresh link to all home navigation types 
This adds a refresh link to all homePager.jsp browse methods in a
consistent place, so that users can easily refresh the proper frame
without causing a whole page refresh that would interrupt the web
player.
This is a follow-on to #1339 which removed the auto-refresh feature.
A side effect of this cleanup was to change all spacing between sets
of elements to a standard 2em to the right which made the layout
less convoluted.
 2019-11-20 04:52:53 -06:00
Evan HarrisandGitHub 569a55259f Merge pull request #1339 from eharris/remove-autorefresh 
Removed the auto-refresh feature
 2019-11-20 04:21:38 -06:00
Evan Harris a44cad0c5b Removed duplicate Integer parsing code 2019-11-12 01:50:02 -06:00
Evan Harris 4a1493e474 Removed duplicated code 2019-11-12 01:50:02 -06:00
Evan Harris ecc026b3e8 Changed to use short-cut logic and other cleanups 2019-11-12 01:49:42 -06:00
Evan HarrisandJonas L a79b56fe5a Removed unused variables, imports, empty statements (#1361) 
Also some unnecessary whitespace.
 2019-11-03 14:35:53 +01:00
Evan Harris bc0ef1ea27 Cleanup extraneous quote 2019-10-30 17:11:32 -05:00
Evan Harrisandjvoisin 2da9c7310a Changed final constant to add static 2019-10-24 19:43:51 +00:00
Evan Harris a793deab0b Got rid of duplicated code to format durations 
Added new functions and test cases.
 2019-10-21 07:46:16 -05:00
Evan Harris 0660c4f3e6 Renamed StringUtil.formatDuration to formatDurationMSS 2019-10-21 07:01:34 -05:00
Evan Harris 29c1b5dbca Enabled PMD checking for jsp files 
2 rulesets are included.
 2019-10-20 10:20:42 -05:00
Evan Harris 42537686fc Added page encoding meta tags to jsp files to satisfy PMD 2019-10-20 10:20:41 -05:00
Evan Harris 4098d801fc Fixed a bunch of quoting issues in jsp files 
All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too.
 2019-10-20 10:20:31 -05:00
Evan Harris cd0dc8673d Move DOCTYPE line to top of all jsp files 
Not doing this causes violations when using PMD.
 2019-10-20 10:03:22 -05:00
Evan Harris 460589f590 Added an SVG icon for shuffle in dark theme 2019-10-17 15:57:05 -05:00
Evan Harris 18e2fe6449 Changed link text from "more" to "refresh" (more correct) 
Also added refresh SVG icons to match the text.
 2019-10-17 15:34:50 -05:00
Evan Harris 91f91ed654 Removed the auto-refresh feature 
This feature just generated a lot of unnecessary traffic to the server and
hurt usability because the page would refresh unexpectedly while a user was
actively looking at content.  Fixes #1003, #1179, #729.
Did not remove the column for that setting in the user database, since that
would lead to complications if needing to downgrade for some reason.
 2019-10-16 00:50:15 -05:00
Evan Harris c728d267c7 Fixed inconsistencies in SVG icon colors 2019-10-15 20:51:04 -05:00
Evan Harris 4fb9820a08 Added test case sources to checkstyle 
Fixes #1328.
 2019-10-15 12:38:52 -05:00
Evan Harris 06f81f8b97 Added separate user icon from logout icon 
Fixes #1305 and improves navigation.
 2019-10-12 00:45:25 -05:00
Evan Harris d8464e6497 Updated the issue template to add language 
Also corrected some other typos and suggested using file attachments
or gist's for large logs.
 2019-10-09 14:35:00 -05:00
Evan Harris 317b3a44b5 Fixed broken brace and quote splitting in help text 
Hopefully fixes #1298.
 2019-10-09 14:14:13 -05:00
Evan HarrisandAndrew DeMaria f644f5a1d0 Improved handling of missing/failed transcoder 
Fixes #659.

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-10-08 18:41:55 -06:00
Evan Harris 6783ced897 Removed inability to change roles for admin user 2019-10-08 06:38:57 -05:00
Evan HarrisandAndrew DeMaria 90e6c77563 Fix incorrect absolute paths in css 
Fixes #1256

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-10-06 15:55:19 -06:00
Evan HarrisandAndrew DeMaria 41967e76df Media file scan will now heed configured music/video file types 
It will also now heed the Media Folders -> Exclude Pattern.  Fixes #1227.

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-10-05 21:14:31 -06:00
Evan HarrisandAndrew DeMaria 1b28d2c2fe Handle nulls when processing cover art better 
This expands on commit d4487a07a0fcacea1544d61c79a380f2e9bf3087.

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-10-05 20:06:09 -06:00
Evan Harris 2fa584f81d Merge branch 'origin/pr/1244' 2019-10-02 01:24:51 -05:00
Evan Harris a85642c797 Merge branch 'origin/pr/1248' 2019-09-21 18:48:44 -05:00
Evan Harris 117e8c7fd1 Improve transcoder info text and formatting 2019-09-20 03:59:14 -05:00
Evan HarrisandAndrew DeMaria b02fd9ad6c Change integration tests from parallel to single 
This is an attempt to make the Travis CI integration tests more reliable,
and changes from parallel to single forking mode.
This is a temporary measure until cucumber-jvm-parallel-plugin (which is no
longer supported) is ripped out (see #1240)

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-09-18 22:23:51 -06:00
Evan Harris d4aff1dca5 Added checkstyle to prohibit windows line endings 
Suggestion taken from jvoisin in #1121.
 2019-09-13 13:11:01 -05:00
Evan Harris 83ca97e21c Improve error handling for jaudiotaggerParser artwork fetch 2019-09-01 13:24:26 -05:00
Evan Harris 4679bac08d Added handling for LyricsService ConnectTimeoutException 2019-08-31 08:44:25 -05:00
Evan Harris 73768b94ea Handle Lyrics fetch HttpResponseException 
Also marked 503 error as retryable and added log message for socket error
 2019-08-31 08:44:10 -05:00
Evan Harris 6e8ae8971c Enable checkstyle OverloadMethodsDeclarationOrder 2019-08-16 18:08:42 -05:00
Evan Harris 1acfacb4c6 Enable checkstyle FileTabCharacter 2019-08-15 18:40:04 -05:00
Evan Harrisandjvoisin 16039d5e81 Enable checkstyle UniqueProperties 2019-08-15 22:07:53 +00:00
Evan Harrisandjvoisin fcc68febc8 Enable several more code checkstyles 2019-08-15 22:07:32 +00:00
Evan Harrisandjvoisin 389db3f1b4 Enable checkstyle for simple boolean expressions 2019-08-11 20:10:06 +00:00
Evan Harrisandjvoisin f738819625 Enable additional checkstyles for whitespace 
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
 2019-08-11 20:09:40 +00:00
Evan Harrisandjvoisin 86a5b8708d Enable checkstyle OneStatementPerLine 2019-08-08 21:26:01 +00:00
Evan Harrisandjvoisin 153ad19b6b Enable several more checkstyle modules 
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
 2019-08-07 22:46:10 +00:00
Evan Harrisandjvoisin 3c5735e03e Fix null exception when creating a new podcast channel 
Until the podcast channel has been updated to provide it with a title, there
is no point to doing any further processing since the directory where episodes
are stored is derived from the title.

While this change is unrelated to #176, it fixes the traceback shown in that
issue.
 2019-08-07 09:14:18 +00:00
Evan Harris 093f7c028d Fix podcast download issues 
Some podcast feeds use circular redirects (with query parameters).
Fixes #1013
Avoids HttpClient cookie handling producing "Invalid cookie" errors due to
not handling latest "expires" attribute formats.
 2019-07-24 23:30:40 -05:00
Evan Harrisandjvoisin bf309e9117 Fixup eccb7e08f5 (#1170) 2019-07-17 22:48:41 +00:00
Evan Harris 50b3fd382c Handle null without exception 2019-07-08 02:57:41 -05:00
Evan Harris 59db5073e3 Added webm to default video file types 2019-07-02 06:33:03 -05:00
Evan Harris 983d688cce Added validation to reject things disallowed on the current user 2019-06-27 00:26:10 -05:00
Evan Harris a4c62f6860 Disallow deleting your own user or removing admin role 2019-06-26 21:17:56 -05:00
Evan Harris 79b800656a Cleanup siebling -> sibling mis-spellings 2019-06-24 20:59:04 -05:00