jvoisin
5bbcd6d84b
Document a bit our review process ( #1353 )
...
@randomnicode asked some good questions in #1348
about out governance/contribution/review/… processes,
so here is a commit to document them a bit.
5 years ago
jvoisin
a9a7b08230
Use the try-with-resource construct where possible
5 years ago
randomnicode
a81dbc7e23
Additions to gitignore for static analysis plugins
5 years ago
jvoisin
6d092286e3
Remove openjdk-ea for now
...
It's breaking the build in weird ways, we
can always add it back later.
5 years ago
Evan Harris
2da9c7310a
Changed final constant to add static
5 years ago
jvoisin
a0cc372abc
Add OpenJDK 13 and OpenJDK-dev to travis
5 years ago
jvoisin
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
5 years ago
François-Xavier Thomas
b37cbf6617
Merge pull request #1359 from randomnicode/minorfixtostatictimeunit
...
Minor fix to static time unit call
5 years ago
François-Xavier Thomas
320e2a7b77
Merge pull request #1352 from fxthomas/1333-allow-previous-migration-checksums-for-mariadb
...
Allow previous Liquibase migration checksums for MariaDB
5 years ago
François-Xavier Thomas
78a99d5860
Allow previous Liquibase migration checksums for MariaDB
...
If someone was using MariaDB before #1188 , they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).
This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188 .
5 years ago
Randomnicode
acb4e033aa
Minor fix to static time unit call
5 years ago
jvoisin
0c0561d104
Bump apache's cxf
5 years ago
jvoisin
599eb8574d
Bump OWASP's maven dependency's check
5 years ago
jvoisin
f910c572c9
Use a static access in a test file, because we can.
5 years ago
jvoisin
a4cc1ec6ec
Bump jackson to a proper release
5 years ago
François-Xavier Thomas
2438044c5d
Merge pull request #1265 from benferreri/master
...
Add discogs search link to main album page
5 years ago
jvoisin
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
5 years ago
jvoisin
d17c00115a
Minor refactor of CsrfSecurityRequestMatcher
...
- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
d61a00e830
Merge remote-tracking branch 'origin/pr/1315'
5 years ago
Andrew DeMaria
75705e8f2d
Merge remote-tracking branch 'origin/pr/1324'
5 years ago
Andrew DeMaria
75a280457e
Merge remote-tracking branch 'origin/pr/1327'
5 years ago
Andrew DeMaria
0d0683d066
Merge remote-tracking branch 'origin/pr/1335'
5 years ago
Andrew DeMaria
ceb6b3e598
Merge remote-tracking branch 'origin/pr/1332'
5 years ago
Andrew DeMaria
378850a9b1
Merge remote-tracking branch 'origin/pr/1330'
5 years ago
Evan Harris
c728d267c7
Fixed inconsistencies in SVG icon colors
5 years ago
jvoisin
af28e7c257
Fix the syntax for sunfire's exclusion
5 years ago
Evan Harris
4fb9820a08
Added test case sources to checkstyle
...
Fixes #1328 .
5 years ago
Phil Hudson
0a94058a62
Fix broken update link
5 years ago
Andrew DeMaria
666bc66ec8
Merge remote-tracking branch 'origin/pr/1313'
5 years ago
Andrew DeMaria
7d0328cf8d
Update changelog with 10.4.1 release
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
82fa09d198
Bump jwt
5 years ago
jvoisin
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
5 years ago
jvoisin
c25e26d61a
Remove a dead file
5 years ago
jvoisin
06e36ff154
Mark a field as private
...
Since we're synchronising on playQueue, we should make
it final.
5 years ago
Evan Harris
06f81f8b97
Added separate user icon from logout icon
...
Fixes #1305 and improves navigation.
5 years ago
Andrew DeMaria
89ea120a2f
Merge remote-tracking branch 'origin/pr/1310'
5 years ago
Andrew DeMaria
357758ba4e
Merge remote-tracking branch 'origin/pr/1312'
5 years ago
Andrew DeMaria
7058b5098d
Merge remote-tracking branch 'origin/pr/1302'
5 years ago
François-Xavier Thomas
6b2c7e338d
Remove white underline from player controls
5 years ago
François-Xavier Thomas
09808b170e
Update dark icons for the 'groove' theme
5 years ago
François-Xavier Thomas
8b72964086
Display file id and path in debug scanning logs
5 years ago
jvoisin
b6414ebb6c
Simplify a condition
5 years ago
jvoisin
9f027f333e
Upgrade PlaylistService to non-deprecated methods
...
As documented here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/Assert.html#notNull-java.lang.Object-java.lang.String-
5 years ago
Andrew DeMaria
3fe6e8b267
Add logger name checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
d8464e6497
Updated the issue template to add language
...
Also corrected some other typos and suggested using file attachments
or gist's for large logs.
5 years ago
Evan Harris
f644f5a1d0
Improved handling of missing/failed transcoder
...
Fixes #659 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
431b42bfb3
Ensure commons logging is excluded ( #1274 )
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
6783ced897
Removed inability to change roles for admin user
5 years ago
jvoisin
6f590f7740
Check the return value of `delete` calls
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Kessiler Rodrigues
4b3890f6ec
Replace custom circular buffer with Apache commons(CircularFifoQueue)
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago