Update to work with rocket-0.5 #4

Closed
opened 1 year ago by Ghost · 4 comments
Ghost commented 1 year ago

I was interested in rocket_session functionality but soon noticed it doesn't work with rocket-0.5 (which I need to use for other reasons).

I went ahead and made the changes myself to make it work, and the examples now work correctly. I wanted to submit the changes as a PR but for some reason this gitea instance is not accepting my ssh key, so I am not able to push my changes.

I'd be happy to drop them as a patch file or put them on github.com somewhere or whatever you prefer.

I was interested in rocket_session functionality but soon noticed it doesn't work with rocket-0.5 (which I need to use for other reasons). I went ahead and made the changes myself to make it work, and the examples now work correctly. I wanted to submit the changes as a PR but for some reason this gitea instance is not accepting my ssh key, so I am not able to push my changes. I'd be happy to drop them as a patch file or put them on github.com somewhere or whatever you prefer.
Owner

SSH keys should work, however make sure you use the correct port, 4022

It's shown on the landing page, but it's accessible only when you're logged out. Nice bug.

host git.ondrovo.com
    user git
    hostname git.ondrovo.com
    port 4022

You can also try pushing with a password. But if you just dump a git patch here, that's also fine.

SSH keys should work, however make sure you use the correct port, 4022 It's shown on the landing page, but it's accessible only when you're logged out. Nice bug. ``` host git.ondrovo.com user git hostname git.ondrovo.com port 4022 ``` You can also try pushing with a password. But if you just dump a git patch here, that's also fine.
Owner

This is in the log... all I can say, ssh key works for me

gitea-gitea-1  | 2023/01/09 13:51:50 ...ers/web/auth/auth.go:616:handleUserCreated() [E] [63bc1bf6] UpdateExternalUser failed: external login user link does not exists [userID: 3330, loginSourceID: 1]
gitea-gitea-1  | 2023/01/09 13:55:05 ...ey/ssh_key_verify.go:34:VerifySSHKey() [E] [63bc1cb9-14] Unable to validate token signature. Error: ssh: signature did not verify
gitea-gitea-1  | 2023/01/09 13:55:05 ...ey/ssh_key_verify.go:34:VerifySSHKey() [E] [63bc1cb9-14] Unable to validate token signature. Error: ssh: signature did not verify
gitea-gitea-1  | 2023/01/09 14:00:11 ...ey/ssh_key_verify.go:34:VerifySSHKey() [E] [63bc1deb] Unable to validate token signature. Error: ssh: signature did not verify
gitea-gitea-1  | 2023/01/09 14:24:06 ...s/web/user/avatar.go:34:AvatarByUserName() [E] [63bc2386] Invalid user: Matthewbes: user does not exist [uid: 0, name: Matthewbes, keyid: 0]

This is in the log... all I can say, ssh key works for me ``` gitea-gitea-1 | 2023/01/09 13:51:50 ...ers/web/auth/auth.go:616:handleUserCreated() [E] [63bc1bf6] UpdateExternalUser failed: external login user link does not exists [userID: 3330, loginSourceID: 1] gitea-gitea-1 | 2023/01/09 13:55:05 ...ey/ssh_key_verify.go:34:VerifySSHKey() [E] [63bc1cb9-14] Unable to validate token signature. Error: ssh: signature did not verify gitea-gitea-1 | 2023/01/09 13:55:05 ...ey/ssh_key_verify.go:34:VerifySSHKey() [E] [63bc1cb9-14] Unable to validate token signature. Error: ssh: signature did not verify gitea-gitea-1 | 2023/01/09 14:00:11 ...ey/ssh_key_verify.go:34:VerifySSHKey() [E] [63bc1deb] Unable to validate token signature. Error: ssh: signature did not verify gitea-gitea-1 | 2023/01/09 14:24:06 ...s/web/user/avatar.go:34:AvatarByUserName() [E] [63bc2386] Invalid user: Matthewbes: user does not exist [uid: 0, name: Matthewbes, keyid: 0] ```
Poster

Oh wow, I never would have figured out that the port is supposed to be 4022 :) Thanks! Fixed now.

I'll submit a PR.

Oh wow, I never would have figured out that the port is supposed to be 4022 :) Thanks! Fixed now. I'll submit a PR.
MightyPork closed this issue 1 year ago
Owner

okay, I hacked the front-end a bit, this should make the port more clear :D

/attachments/9e83e1ab-470e-4a06-a87c-2fa80ff19ed4

okay, I hacked the front-end a bit, this should make the port more clear :D ![/attachments/9e83e1ab-470e-4a06-a87c-2fa80ff19ed4](/attachments/9e83e1ab-470e-4a06-a87c-2fa80ff19ed4)
Sign in to join this conversation.
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: packages/rocket_session#4
Loading…
There is no content yet.