Wrong HttpMethod applied by AuthContext::new_post #2

New Issue

2019-08-18T15:51:50Z

Ghost commented

2019-08-18 15:51:50 +00:00

The code

pub fn new_post<'n:'a, 'p:'a, 'u:'a, 'b:'a>(
        username : &'n str,
        password : &'p str,
        uri : &'u str,
        body : Option<&'b [u8]>
    ) -> Self {
        Self::new_with_method(username, password, uri, body, HttpMethod::GET)
    }

is applying the GET method instead of the POST method. This causes the md5(method:uri) value to be incorrectly calculated and so causes post requests to fail

The code ``` pub fn new_post<'n:'a, 'p:'a, 'u:'a, 'b:'a>( username : &'n str, password : &'p str, uri : &'u str, body : Option<&'b [u8]> ) -> Self { Self::new_with_method(username, password, uri, body, HttpMethod::GET) } ``` is applying the GET method instead of the POST method. This causes the md5(method:uri) value to be incorrectly calculated and so causes post requests to fail

MightyPork commented

2019-08-19 07:15:59 +00:00

Good catch, I suppose I never used that function ;)

I'll fix it ASAP

Good catch, I suppose I never used that function ;) I'll fix it ASAP

MightyPork commented

2019-10-05 13:06:26 +00:00

oops took a while, finally fixed

MightyPork closed this issue

2019-10-05 13:06:26 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: packages/digest_auth_rs#2