implemented lock button option

framework/system_settings.c

@@ -23,7 +23,7 @@ void systemsettings_init(void)
 
     // Flags
     SystemSettings.modified = false;
-    LockJumper_ReadHardware();
+    LockJumper_CheckInitialState();
 }
 
 // to binary

platform/lock_jumper.c

@@ -13,9 +13,14 @@
 #include "pin_utils.h"
 #include "lock_jumper.h"
 
+static bool LockJumper_ReadPin(void);
+
 static GPIO_TypeDef *lock_periph;
 static uint32_t lock_llpin;
 
+static bool old_state = false;
+static uint32_t debo_ticks = 0;
+
 // We use macros LOCK_JUMPER_PORT, LOCK_JUMPER_PIN from plat_compat.h
 
 /** Init the jumper subsystem */
@@ -37,7 +42,13 @@ void LockJumper_Init(void)
 
     // Configure for input
     LL_GPIO_SetPinMode(lock_periph, lock_llpin, LL_GPIO_MODE_INPUT);
-    LL_GPIO_SetPinPull(lock_periph, lock_llpin, LL_GPIO_PULL_UP);
+
+    // pull-up/down in the opposite direction of the active state
+    #if PLAT_LOCK_1CLOSED
+        LL_GPIO_SetPinPull(lock_periph, lock_llpin, LL_GPIO_PULL_DOWN);
+    #else
+        LL_GPIO_SetPinPull(lock_periph, lock_llpin, LL_GPIO_PULL_UP);
+    #endif
 
     SystemSettings.editable = (bool) LL_GPIO_IsInputPinSet(lock_periph, lock_llpin);
     dbg("Settings editable? %d", SystemSettings.editable);
@@ -49,10 +60,10 @@ static void jumper_changed(void)
 {
     if (SystemSettings.editable) {
         // Unlock
-        dbg("LOCK jumper removed, enabling MSC!");
+        dbg("LOCK removed, enabling MSC!");
     } else {
         // Lock
-        dbg("LOCK jumper replaced, disabling MSC!");
+        dbg("LOCK replaced, disabling MSC!");
 
         if (SystemSettings.modified) {
             dbg("Saving settings to Flash...");
@@ -69,26 +80,51 @@ static void jumper_changed(void)
 /** Periodic jumper check */
 void LockJumper_Check(void)
 {
-    // Debounce cooldown
+    bool state = LockJumper_ReadPin();
-    static uint32_t cooldown = 0;
+    if (state != old_state) {
-    if (cooldown > 0) {
+        old_state = state;
-        cooldown--;
+        debo_ticks = 3;
-        return;
     }
 
-    // Read the pin state
+    if (debo_ticks > 0) {
-    bool old = SystemSettings.editable;
+        if (--debo_ticks == 0) {
-    LockJumper_ReadHardware();
+            // we've reached a change
-
+            #if PLAT_LOCK_BTN
-    if (old != SystemSettings.editable) {
+                if (state == true) {
-        // --- State changed ---
+                    SystemSettings.editable = !SystemSettings.editable;
-        cooldown = 5; // 0.5s if called every 100 ms
+                    jumper_changed();
-
+                }
-        jumper_changed();
+            #else
+                SystemSettings.editable = state;
+                jumper_changed();
+            #endif
+        }
     }
 }
 
-void LockJumper_ReadHardware(void)
+/**
+ * Read the jumper / button state.
+ *
+ * @return true if the jumper is closed, or button pressed
+ */
+static bool LockJumper_ReadPin(void)
 {
-    SystemSettings.editable = (bool) LL_GPIO_IsInputPinSet(lock_periph, lock_llpin);
+    // lock jumper - start with MSC on if removed
+    #if PLAT_LOCK_1CLOSED
+        return (bool) LL_GPIO_IsInputPinSet(lock_periph, lock_llpin);
+    #else
+        return ! ((bool) LL_GPIO_IsInputPinSet(lock_periph, lock_llpin));
+    #endif
+}
+
+
+void LockJumper_CheckInitialState(void)
+{
+    #if PLAT_LOCK_BTN
+        // no static read - starts with MSC off
+        SystemSettings.editable = false;
+        old_state = false;
+    #else
+        old_state = SystemSettings.editable = ! LockJumper_ReadPin();
+    #endif
 }

platform/lock_jumper.h

@@ -21,6 +21,6 @@ void LockJumper_Check(void);
  * Check hardware jumper and load it's value into the settings struct.
  * Does NOT trigger MSC changes or anything else.
  */
-void LockJumper_ReadHardware(void);
+void LockJumper_CheckInitialState(void);
 
 #endif //GEX_LOCK_JUMPER_H

platform/plat_compat.h

@@ -50,6 +50,8 @@
 // PLAT_NO_FLOATING_INPUTS - can't have digital inputs with no pull resistor
 // PLAT_USB_PHYCLOCK - requires special config of phy clock for USB
 // PLAT_USB_OTGFS - uses the USB OTG IP, needs different config code
+// PLAT_LOCK_BTN - use a lock button instead of a lock jumper (push to toggle)
+// PLAT_LOCK_1CLOSED - lock jumper is active (closed / button pressed) in logical 1
 
 #if defined(GEX_PLAT_F103_BLUEPILL)
 
@@ -138,8 +140,10 @@
     #define PORTS_COUNT 6
 
     // Lock jumper config
-    #define LOCK_JUMPER_PORT 'F'
+    #define LOCK_JUMPER_PORT 'A'
-    #define LOCK_JUMPER_PIN  1 // OSC OUT, not used in BYPASS mode (receiving clock from the ST-Link MCO)
+    #define LOCK_JUMPER_PIN  0
+    #define PLAT_LOCK_BTN 1 // toggle button instead of a jumper
+    #define PLAT_LOCK_1CLOSED 1 // toggle button active in log. 1
 
     // Status LED config
     #define STATUS_LED_PORT 'C'