Fix minor mistakes in tests that made them fail, fix account normalization #14

Sloučený
MightyPork sloučil 2 commity z větve fgaz/group-actor:master do větve master před před 4 roky
fgaz okomentoval před 4 roky
Není zde žádný obsah.
Vlastník

Good catch with the tests, please also update the message "still member even if banned". (That test can be simplified, it was written before I made banning also a kick.)

What are you trying to solve with that lowercasing?

Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt

Good catch with the tests, please also update the message "still member even if banned". (That test can be simplified, it was written before I made banning also a kick.) What are you trying to solve with that lowercasing? Perhaps the lowercasing should be in `acct_to_server()` instead (and change it to return String)? That one added alloc probably won't hurt
Autor

please also update the message "still member even if banned"

done

What are you trying to solve with that lowercasing?

assert_eq!(
    Ok("piggo@banana.nana".into()),
    normalize_acct("piGGo", "foo@baNANA.nana")
);

Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt

makes sense, so it also applies during authentication. done

> please also update the message "still member even if banned" done > What are you trying to solve with that lowercasing? ```rust assert_eq!( Ok("piggo@banana.nana".into()), normalize_acct("piGGo", "foo@baNANA.nana") ); ``` > Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt makes sense, so it also applies during authentication. done
Vlastník

thanks, i'll try to merge it tonight

thanks, i'll try to merge it tonight
Autor

Great! When you do, could you also make a point release so I don't have to disable tests / apply patches on the current one when packaging it?

Great! When you do, could you also make a point release so I don't have to disable tests / apply patches on the current one when packaging it?
MightyPork uzavřel/a tento požadavek na natažení před 4 roky
Autor

Thanks for the release!

Thanks for the release!
Požadavek na natažení byl sloučen jako cbd3c0a575.
Přihlaste se pro zapojení do konverzace.
Žádní posuzovatelé
Bez milníku
Bez zpracovatelů
2 účastníků
Oznámení
Termín dokončení

Žádný termín dokončení.

Závislosti

Nejsou nastaveny žádné závislosti.

Reference: MightyPork/group-actor#14
Načítá se…
Není zde žádný obsah.