Fix minor mistakes in tests that made them fail, fix account normalization #14

Merged
MightyPork merged 2 commits from fgaz/group-actor:master into master 1 year ago
fgaz commented 1 year ago
There is no content yet.
Owner

Good catch with the tests, please also update the message "still member even if banned". (That test can be simplified, it was written before I made banning also a kick.)

What are you trying to solve with that lowercasing?

Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt

Good catch with the tests, please also update the message "still member even if banned". (That test can be simplified, it was written before I made banning also a kick.) What are you trying to solve with that lowercasing? Perhaps the lowercasing should be in `acct_to_server()` instead (and change it to return String)? That one added alloc probably won't hurt
Poster

please also update the message "still member even if banned"

done

What are you trying to solve with that lowercasing?

assert_eq!(
    Ok("piggo@banana.nana".into()),
    normalize_acct("piGGo", "foo@baNANA.nana")
);

Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt

makes sense, so it also applies during authentication. done

> please also update the message "still member even if banned" done > What are you trying to solve with that lowercasing? ```rust assert_eq!( Ok("piggo@banana.nana".into()), normalize_acct("piGGo", "foo@baNANA.nana") ); ``` > Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt makes sense, so it also applies during authentication. done
Owner

thanks, i'll try to merge it tonight

thanks, i'll try to merge it tonight
Poster

Great! When you do, could you also make a point release so I don't have to disable tests / apply patches on the current one when packaging it?

Great! When you do, could you also make a point release so I don't have to disable tests / apply patches on the current one when packaging it?
MightyPork closed this pull request 1 year ago
Poster

Thanks for the release!

Thanks for the release!
The pull request has been merged as cbd3c0a575.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MightyPork/group-actor#14
Loading…
There is no content yet.