Fix minor mistakes in tests that made them fail, fix account normalization #14

2021-11-01T20:29:26Z

fgaz commented

2021-11-01 20:29:26 +00:00

No description provided.

MightyPork commented

2021-11-01 23:26:32 +00:00

Good catch with the tests, please also update the message "still member even if banned". (That test can be simplified, it was written before I made banning also a kick.)

What are you trying to solve with that lowercasing?

Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt

Good catch with the tests, please also update the message "still member even if banned". (That test can be simplified, it was written before I made banning also a kick.) What are you trying to solve with that lowercasing? Perhaps the lowercasing should be in `acct_to_server()` instead (and change it to return String)? That one added alloc probably won't hurt

fgaz commented

2021-11-02 10:39:33 +00:00

please also update the message "still member even if banned"

done

What are you trying to solve with that lowercasing?

assert_eq!(
    Ok("piggo@banana.nana".into()),
    normalize_acct("piGGo", "foo@baNANA.nana")
);

Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt

makes sense, so it also applies during authentication. done

> please also update the message "still member even if banned" done > What are you trying to solve with that lowercasing? ```rust assert_eq!( Ok("piggo@banana.nana".into()), normalize_acct("piGGo", "foo@baNANA.nana") ); ``` > Perhaps the lowercasing should be in acct_to_server() instead (and change it to return String)? That one added alloc probably won't hurt makes sense, so it also applies during authentication. done

MightyPork commented

2021-11-02 12:24:18 +00:00

thanks, i'll try to merge it tonight