Andrew DeMaria
ef22d6d8ed
Remove optional jetty runtime
...
- Simplifies pom making future upgrades easier
- Fixes tests picking up jetty runtime
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
437d8ce947
Move index meta information
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
a79b56fe5a
Removed unused variables, imports, empty statements ( #1361 )
...
Also some unnecessary whitespace.
5 years ago
Randomnicode
4b852c53e2
Fix Test Queries for limits
5 years ago
Randomnicode
8728566860
Switch to using ScheduledExecutor for MediaScanner
5 years ago
jvoisin
a9a7b08230
Use the try-with-resource construct where possible
5 years ago
Evan Harris
2da9c7310a
Changed final constant to add static
5 years ago
jvoisin
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
5 years ago
François-Xavier Thomas
78a99d5860
Allow previous Liquibase migration checksums for MariaDB
...
If someone was using MariaDB before #1188 , they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).
This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188 .
5 years ago
Randomnicode
acb4e033aa
Minor fix to static time unit call
5 years ago
Evan Harris
a793deab0b
Got rid of duplicated code to format durations
...
Added new functions and test cases.
5 years ago
Evan Harris
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
5 years ago
jvoisin
f910c572c9
Use a static access in a test file, because we can.
5 years ago
Evan Harris
29c1b5dbca
Enabled PMD checking for jsp files
...
2 rulesets are included.
5 years ago
Evan Harris
42537686fc
Added page encoding meta tags to jsp files to satisfy PMD
5 years ago
Evan Harris
4098d801fc
Fixed a bunch of quoting issues in jsp files
...
All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too.
5 years ago
Evan Harris
cd0dc8673d
Move DOCTYPE line to top of all jsp files
...
Not doing this causes violations when using PMD.
5 years ago
jvoisin
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
5 years ago
jvoisin
d17c00115a
Minor refactor of CsrfSecurityRequestMatcher
...
- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
c728d267c7
Fixed inconsistencies in SVG icon colors
5 years ago
Evan Harris
4fb9820a08
Added test case sources to checkstyle
...
Fixes #1328 .
5 years ago
Phil Hudson
0a94058a62
Fix broken update link
5 years ago
jvoisin
82fa09d198
Bump jwt
5 years ago
jvoisin
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
5 years ago
jvoisin
c25e26d61a
Remove a dead file
5 years ago
jvoisin
06e36ff154
Mark a field as private
...
Since we're synchronising on playQueue, we should make
it final.
5 years ago
Evan Harris
06f81f8b97
Added separate user icon from logout icon
...
Fixes #1305 and improves navigation.
5 years ago
François-Xavier Thomas
6b2c7e338d
Remove white underline from player controls
5 years ago
François-Xavier Thomas
09808b170e
Update dark icons for the 'groove' theme
5 years ago
François-Xavier Thomas
8b72964086
Display file id and path in debug scanning logs
5 years ago
jvoisin
b6414ebb6c
Simplify a condition
5 years ago
jvoisin
9f027f333e
Upgrade PlaylistService to non-deprecated methods
...
As documented here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/Assert.html#notNull-java.lang.Object-java.lang.String-
5 years ago
Andrew DeMaria
3fe6e8b267
Add logger name checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
317b3a44b5
Fixed broken brace and quote splitting in help text
...
Hopefully fixes #1298 .
5 years ago
Evan Harris
f644f5a1d0
Improved handling of missing/failed transcoder
...
Fixes #659 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
431b42bfb3
Ensure commons logging is excluded ( #1274 )
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
6783ced897
Removed inability to change roles for admin user
5 years ago
jvoisin
6f590f7740
Check the return value of `delete` calls
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Kessiler Rodrigues
4b3890f6ec
Replace custom circular buffer with Apache commons(CircularFifoQueue)
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
42b4aaafc7
Use EnumMap in IndexManager
...
EnumMap are _much_ more efficient than HashMaps,
so we should use them if we can.
See here for more details: https://docs.oracle.com/javase/8/docs/api/java/util/EnumMap.html
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
85f85fd88c
Make test results quieter
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
1a7bb68dc6
Remove a leftover of the Radexo removal
...
This is a followup of 85e0e08d9a
5 years ago
jvoisin
da34bf0d3f
Improve Windows system detection
...
Use apache commons instead of terrifyingly fragile black magic.
5 years ago
jvoisin
85e0e08d9a
Remove radeox
...
Radeox is a rendering engine for an unspecified markup.
Its [website](http://radeox.org/ ) is dead, the website
of its [authors](http://www.codehaus.org/ ) is dead too,
its [last commit](https://github.com/codehaus/radeox ) was 13 years ago.
It's only used for the welcome and login messages,
as well as comments from users. If we want to have some markup parsing,
we should use something maintained with autoescaping guarantees,
instead of a piece of zombie code prone to $DEITY knows what injections.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
e5404648a4
Remove unnecessary exceptions and unused imports
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
90e6c77563
Fix incorrect absolute paths in css
...
Fixes #1256
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
776bb2cfef
Switch to newer modelAttribute
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
dddf8dc0aa
Fix some javadoc comments
...
- Remove a dangling comment
- Delete half-documented parameters
- Fix some @see/@link
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
889add6848
More lambdaification
5 years ago
jvoisin
362cf29e41
Fix some javadoc comments
...
- Remove a dangling comment
- Delete half-documented parameters
- Fix some @see/@link
5 years ago