Commit Graph
1295 Commits
Author SHA1 Message Date
Andrew DeMaria b407231132 Update changelog for 10.3.0
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-05-20 17:10:24 -06:00
Andrew DeMaria 6fbed41b7b Add date for version release 2019-05-20 17:00:27 -06:00
Andrew DeMaria 8be0746bd4 Bump to 10.4.0 SNAPSHOT 2019-05-20 16:59:57 -06:00
Andrew DeMaria 7203d4ba6b One more changelog update
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-05-20 15:59:10 -06:00
Andrew DeMaria 53142c8702 Merge remote-tracking branch 'origin/pr/1062' 2019-05-20 15:53:22 -06:00
Andrew DeMaria f1831820f4 Update docker base image 2019-05-20 15:36:08 -06:00
Andrew DeMaria 493a53b418 Merge remote-tracking branch 'origin/pr/930' 2019-05-20 15:30:15 -06:00
Andrew DeMaria 6729838030 Changelog updates for 10.3.0
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-05-20 15:27:57 -06:00
Andrew DeMaria bec5cec4a2 Merge remote-tracking branch 'origin/pr/930' 2019-05-20 15:05:18 -06:00
jvoisin 1090348b0e Use the version number in jquery-ui's css path 2019-05-20 22:57:21 +02:00
Andrew DeMaria 0a1164966d Merge remote-tracking branch 'origin/pr/1032' 2019-05-20 14:52:32 -06:00
Andrew DeMaria cdd307d86f Merge remote-tracking branch 'origin/pr/1042' 2019-05-20 14:50:56 -06:00
Andrew DeMaria 1e89890223 Merge remote-tracking branch 'origin/pr/1038' 2019-05-20 14:17:33 -06:00
jvoisinandJonas L 33bf68aaa5 Add a password settings testcase (#1058)
* Add a simple testcase

This commit was done to understand how JUnit
and its friends are working. Expect more useful tests
in the future ;)

* Factorise a bit the tests
2019-05-20 20:26:00 +02:00
Jonas LandGitHub 27ee009b69 [ci skip] Better readability in .gitlab-ci.yml 2019-05-18 12:27:12 +02:00
jvoisinandGitHub ce7671bf5e Add the required keyword to some forms
This should improve a bit the accessibility.
2019-05-17 20:29:16 +00:00
jvoisinandGitHub 6d294a770b Replace the usage of prototypejs with jquery in changeCoverArt.jsp
This change was successfully tested on Chromium and Firefox.
2019-05-17 20:23:40 +00:00
jvoisinandGitHub bf5f8cb713 Factorize scripts-2.0.js into utils.js
No need to include two different and super-small javascript "utils" files.
2019-05-17 20:13:12 +00:00
jvoisinandGitHub f3b2c2ea7a Add a missing taglib to homePager.jsp
The missing taglib is confusing coverity a bit,
and I think that it's a good practise to add it
anyway.
2019-05-17 17:13:01 +00:00
jvoisinandGitHub 3cfe2b31a1 Move some cast-related inline js to an external file
There is no point in having such a massive
blob of javascript inline in the page.
2019-05-17 17:09:45 +00:00
Andrew DeMaria 7b628ed8dd Merge remote-tracking branch 'origin/pr/1056' 2019-05-16 13:05:19 -06:00
jvoisin 58daacd9ab Jetty is only used by developers, and never in production
So we're free to completely ignore CVE against it.
2019-05-16 00:37:37 +02:00
Jonas LandGitHub 2c3ba680d8 [ci skip] Add Java version in issue template 2019-05-05 16:10:59 +02:00
jvoisinandGitHub ab03526620 Fix two NULL-deref 2019-05-01 08:52:09 +00:00
François-Xavier Thomas f57ad3f27b Fix typo in anonymous user name (#663) 2019-04-29 23:30:02 +02:00
Andrew DeMaria ac0a722a10 Merge remote-tracking branch 'airsonic/pr/990' 2019-04-28 22:59:23 -04:00
Andrew DeMaria b51cdc1c5c Merge remote-tracking branch 'airsonic/pr/1028' 2019-04-28 22:58:29 -04:00
Andrew DeMaria 4537495baf Merge remote-tracking branch 'airsonic/pr/1012' 2019-04-28 22:55:50 -04:00
Andrew DeMaria 3cdecb87f4 Merge remote-tracking branch 'airsonic/pr/1037' 2019-04-28 19:20:03 -04:00
François-Xavier Thomas 8a90d9f77b Add system properties for persisting the 'remember me' key
This adds the 'airsonic.rememberMeKey' system property (can be set from
command-line with `-Dairsonic.rememberMeKey=<value>`) as well as a
'RememberMeKey' setting in airsonic.properties, so that the key used for
generating 'remember me' tokens can be persisted across server restarts.

It also adds a default, insecure key in case we are running in
development mode with the 'airsonic.development' property set.
2019-04-28 16:51:46 +02:00
jvoisin 3ee6fefe11 Bump jQuery/jquery-ui to the latest versions
I bumped it first to 2.X with jQuery migrate, played around but didn't manage
to trigger any warning.  So I bumped it again to the latest available version,
jQuery 3.4.0, which isn't triggering useful warnings either.
2019-04-28 16:26:36 +02:00
jvoisinandGitHub b663a2fb90 Fix a stored XSS 2019-04-28 08:49:25 +00:00
jvoisinandGitHub 348c698e35 Remove the /db page
This page wasn't linked anywhere, and was
allowing an administrator to issue arbitrary sql
comments, and was vulnerable to reflected XSS.

We should get rid of it. If you really want to issue
SQL commands, just ssh to your instance and do it from here.
2019-04-28 08:48:41 +00:00
jvoisinandGitHub d3970a5c62 Fix various minor issues found by LGTM
- Unnecessary boxing
- Integer overflow
- Path traversal via zip
- Dangerous synchronization pattern
2019-04-28 08:37:47 +00:00
Andrew DeMaria a911ebab80 Merge remote-tracking branch 'origin/pr/1027' 2019-04-27 20:27:37 -06:00
Andrew DeMaria df352d8cb0 Fix #611 Add support for Java 9 and greater
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-04-27 14:04:48 -06:00
Andrew DeMaria 2162250101 Revert "Minor frameset-related factorization"
This reverts commit e69287cfe6.

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-04-27 14:00:52 -06:00
jvoisin 925ecdaa03 Add a gitlab-ci file 2019-04-27 21:18:30 +02:00
jvoisin 3d54ef1afb Mark the player cookie httpOnly
It doesn't improve much security-wise,
but it's a good practise anyway.
2019-04-27 20:37:41 +02:00
jvoisin 8f608485cb Fix a typo 2019-04-27 20:37:35 +02:00
jvoisin 8123716d52 Remove unused loggers 2019-04-27 20:37:35 +02:00
jvoisin 4a06823057 Balance some synchronized
Balance synchronized used on getters and not setters
as well as the other way around.
2019-04-27 20:36:08 +02:00
jvoisin d2f40b710b Fix a possible stacktrace on RandomPlayQueue 2019-04-27 20:35:41 +02:00
Andrew DeMaria a14c8549fa Merge remote-tracking branch 'origin/pr/963' 2019-04-27 11:56:46 -06:00
Andrew DeMaria a3e59e9724 Fix file encoding
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-04-27 10:56:09 -06:00
Andrew DeMaria e5c36d9854 Fix variable name
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-04-27 10:55:54 -06:00
Andrew DeMaria d8a5d1afad Merge remote-tracking branch 'origin/pr/1034' 2019-04-27 10:45:48 -06:00
Andrew DeMaria afc2f58ac5 Merge remote-tracking branch 'origin/pr/1036' 2019-04-27 10:39:19 -06:00
Andrew DeMaria ab07462530 Update tomcat to 8.5.40
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-04-27 10:36:10 -06:00
François-Xavier Thomas 820a4faec2 Avoid logging sensitive URL parameters in the Subsonic API
In case of exceptions, Airsonic logs the full URL that triggered it
since 417583cc, including possibly sensitive query parameters such as
the authentication password/tokens passed to the Subsonic API.

This replaces the value set for this parameter in the URL by the
"<hidden>" string.
2019-04-26 22:18:23 +02:00