MightyPork/airsonic-custom
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,295 Commits 2 Branches 0 Tags
eda6406865c2a1a85a259c36740a7bbe60b50df2
Commit Graph
34 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
jvoisinandGitHub 5bbcd6d84b Document a bit our review process (#1353) 
@randomnicode asked some good questions in #1348
about out governance/contribution/review/… processes,
so here is a commit to document them a bit.
 2019-10-30 22:00:52 +00:00
jvoisinandGitHub a9a7b08230 Use the try-with-resource construct where possible 2019-10-25 19:43:24 +00:00
jvoisinandGitHub a0cc372abc Add OpenJDK 13 and OpenJDK-dev to travis 2019-10-24 19:40:41 +00:00
jvoisinandGitHub 9f6b02c5d0 Refactor a bit how we're handling avatars 
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
 2019-10-24 19:39:39 +00:00
jvoisinandGitHub d3a9a3226f Replace deprecated Date by Calendar 
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
 2019-10-17 21:28:40 +00:00
jvoisinandGitHub 82fa09d198 Bump jwt 2019-10-13 23:32:45 +00:00
jvoisinandGitHub 3d8f3ed21d Gracefully handle failed version check attempts 
This issue what found by darkling, and reported on irc
 2019-09-19 19:54:58 +00:00
jvoisinandGitHub e085d77635 Remove use useless arrays creation 2019-09-01 15:16:14 +00:00
jvoisinandGitHub 7578ee9537 Enable checkstyle's Indentation module 2019-08-07 20:13:29 +00:00
jvoisinandGitHub fabed228da Enable EqualsAvoidNull in checkstyle 2019-08-07 19:12:04 +00:00
jvoisinandGitHub 9a5f3f9483 Replace a now-defunct maven repo with a working one 2019-08-04 21:02:51 +00:00
jvoisinandGitHub 8ba97026a4 Synchronize on activeAudioPlayers when changing them 2019-07-27 16:28:51 +00:00
jvoisinandGitHub 3b8993e860 Replace Hashtable with HashMap, since Hashtable are deprecated 2019-07-13 11:38:01 +00:00
jvoisinandGitHub a997fd4873 Bump jaxb-impl and jaxb-core 2019-07-13 11:34:44 +00:00
jvoisinandGitHub 61e3bc059d Bump javax annotation 2019-07-13 11:33:44 +00:00
jvoisinandGitHub cdc38cb88d Use SVG for the icons for the default_light theme 2019-06-19 23:25:05 +00:00
jvoisinandGitHub 1f1a22fca5 Remove the deprecated getAlphabetialAlbums method 2019-06-10 20:15:32 +00:00
jvoisinandGitHub 828c1b2674 Use modern Spring mapping annotations 
Java is verbose enough, no need to make it worse.
 2019-06-06 18:52:11 +00:00
jvoisinandGitHub 4f59c72bbe Replace wz_tooltip.js with jquery-ui 2019-06-04 22:27:47 +00:00
jvoisinandGitHub 6aa96911de Replace FancyZoom with jquery.fancyzoom 2019-06-04 22:13:07 +00:00
jvoisinandGitHub e3a4fe4603 Balance some synchronized 2019-06-04 21:08:57 +00:00
jvoisinandGitHub 4263d59940 Fix a possible stacktrace on RandomPlayQueue 2019-06-04 21:06:08 +00:00
jvoisinandGitHub f7ee02c88c Remove the embedded copy of jaxrpc (#965) 2019-06-04 21:05:14 +00:00
jvoisinandGitHub 24632317b2 Declare the usage of HTML5 in the doctype 
This should marginally increase the performances
and jquery (no more quirks mode), as well
as making web browsers happier.
 2019-06-04 21:04:59 +00:00
jvoisinandJonas L 33bf68aaa5 Add a password settings testcase (#1058) 
* Add a simple testcase

This commit was done to understand how JUnit
and its friends are working. Expect more useful tests
in the future ;)

* Factorise a bit the tests
 2019-05-20 20:26:00 +02:00
jvoisinandGitHub ce7671bf5e Add the required keyword to some forms 
This should improve a bit the accessibility.
 2019-05-17 20:29:16 +00:00
jvoisinandGitHub 6d294a770b Replace the usage of prototypejs with jquery in changeCoverArt.jsp 
This change was successfully tested on Chromium and Firefox.
 2019-05-17 20:23:40 +00:00
jvoisinandGitHub bf5f8cb713 Factorize scripts-2.0.js into utils.js 
No need to include two different and super-small javascript "utils" files.
 2019-05-17 20:13:12 +00:00
jvoisinandGitHub f3b2c2ea7a Add a missing taglib to homePager.jsp 
The missing taglib is confusing coverity a bit,
and I think that it's a good practise to add it
anyway.
 2019-05-17 17:13:01 +00:00
jvoisinandGitHub 3cfe2b31a1 Move some cast-related inline js to an external file 
There is no point in having such a massive
blob of javascript inline in the page.
 2019-05-17 17:09:45 +00:00
jvoisinandGitHub ab03526620 Fix two NULL-deref 2019-05-01 08:52:09 +00:00
jvoisinandGitHub b663a2fb90 Fix a stored XSS 2019-04-28 08:49:25 +00:00
jvoisinandGitHub 348c698e35 Remove the /db page 
This page wasn't linked anywhere, and was
allowing an administrator to issue arbitrary sql
comments, and was vulnerable to reflected XSS.

We should get rid of it. If you really want to issue
SQL commands, just ssh to your instance and do it from here.
 2019-04-28 08:48:41 +00:00
jvoisinandGitHub d3970a5c62 Fix various minor issues found by LGTM 
- Unnecessary boxing
- Integer overflow
- Path traversal via zip
- Dangerous synchronization pattern
 2019-04-28 08:37:47 +00:00