e3b3bc9d2b
Move Last.fm logic into separate helper class
...
- Split AudioScrobblerSevice into two classes
- Change api to https in last.fm Audio Scrobbler
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
af97925124
Rename some exceptions to `ignored` since we don't care about them
5 years ago
a44cad0c5b
Removed duplicate Integer parsing code
5 years ago
4a1493e474
Removed duplicated code
5 years ago
ecc026b3e8
Changed to use short-cut logic and other cleanups
5 years ago
35eaae39db
Bump snapshot version
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
2caa2550ef
Change exception handling to log at debug
5 years ago
cb63a5cb88
Add jxr plugin for pmd refs
5 years ago
ef22d6d8ed
Remove optional jetty runtime
...
- Simplifies pom making future upgrades easier
- Fixes tests picking up jetty runtime
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
437d8ce947
Move index meta information
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
a79b56fe5a
Removed unused variables, imports, empty statements ( #1361 )
...
Also some unnecessary whitespace.
5 years ago
4b852c53e2
Fix Test Queries for limits
5 years ago
8728566860
Switch to using ScheduledExecutor for MediaScanner
5 years ago
a9a7b08230
Use the try-with-resource construct where possible
5 years ago
2da9c7310a
Changed final constant to add static
5 years ago
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
5 years ago
78a99d5860
Allow previous Liquibase migration checksums for MariaDB
...
If someone was using MariaDB before #1188 , they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).
This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188 .
5 years ago
acb4e033aa
Minor fix to static time unit call
5 years ago
a793deab0b
Got rid of duplicated code to format durations
...
Added new functions and test cases.
5 years ago
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
5 years ago
f910c572c9
Use a static access in a test file, because we can.
5 years ago
29c1b5dbca
Enabled PMD checking for jsp files
...
2 rulesets are included.
5 years ago
42537686fc
Added page encoding meta tags to jsp files to satisfy PMD
5 years ago
4098d801fc
Fixed a bunch of quoting issues in jsp files
...
All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too.
5 years ago
cd0dc8673d
Move DOCTYPE line to top of all jsp files
...
Not doing this causes violations when using PMD.
5 years ago
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
5 years ago
460589f590
Added an SVG icon for shuffle in dark theme
5 years ago
18e2fe6449
Changed link text from "more" to "refresh" (more correct)
...
Also added refresh SVG icons to match the text.
5 years ago
91f91ed654
Removed the auto-refresh feature
...
This feature just generated a lot of unnecessary traffic to the server and
hurt usability because the page would refresh unexpectedly while a user was
actively looking at content. Fixes #1003 , #1179 , #729 .
Did not remove the column for that setting in the user database, since that
would lead to complications if needing to downgrade for some reason.
5 years ago
d17c00115a
Minor refactor of CsrfSecurityRequestMatcher
...
- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
c728d267c7
Fixed inconsistencies in SVG icon colors
5 years ago
4fb9820a08
Added test case sources to checkstyle
...
Fixes #1328 .
5 years ago
0a94058a62
Fix broken update link
5 years ago
82fa09d198
Bump jwt
5 years ago
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
5 years ago
c25e26d61a
Remove a dead file
5 years ago
06e36ff154
Mark a field as private
...
Since we're synchronising on playQueue, we should make
it final.
5 years ago
06f81f8b97
Added separate user icon from logout icon
...
Fixes #1305 and improves navigation.
5 years ago
6b2c7e338d
Remove white underline from player controls
5 years ago
09808b170e
Update dark icons for the 'groove' theme
5 years ago
8b72964086
Display file id and path in debug scanning logs
5 years ago
b6414ebb6c
Simplify a condition
5 years ago
9f027f333e
Upgrade PlaylistService to non-deprecated methods
...
As documented here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/Assert.html#notNull-java.lang.Object-java.lang.String-
5 years ago
3fe6e8b267
Add logger name checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
317b3a44b5
Fixed broken brace and quote splitting in help text
...
Hopefully fixes #1298 .
5 years ago
f644f5a1d0
Improved handling of missing/failed transcoder
...
Fixes #659 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
431b42bfb3
Ensure commons logging is excluded ( #1274 )
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
6783ced897
Removed inability to change roles for admin user
5 years ago
6f590f7740
Check the return value of `delete` calls
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
4b3890f6ec
Replace custom circular buffer with Apache commons(CircularFifoQueue)
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Shen-Ta Hsieh
jvoisin
Evan Harris
Andrew DeMaria
Randomnicode
jvoisin
François-Xavier Thomas
Phil Hudson
Kessiler Rodrigues