Commit Graph
1169 Commits
Author SHA1 Message Date
jvoisinandGitHub e085d77635 Remove use useless arrays creation 2019-09-01 15:16:14 +00:00
Evan Harris 4679bac08d Added handling for LyricsService ConnectTimeoutException 2019-08-31 08:44:25 -05:00
Evan Harris 73768b94ea Handle Lyrics fetch HttpResponseException
Also marked 503 error as retryable and added log message for socket error
2019-08-31 08:44:10 -05:00
Shen-Ta Hsieh 394dfa1ce7 upgrade jackson-databind and commons-beanutils for CVEs
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
2019-08-31 15:40:59 +08:00
Shen-Ta Hsieh 16c1e42b97 normalize license expire date to prevent outstanding value on Java 12
Date(Long.MAX_VALUE) is 292278994-08-17T07:12:55.807Z on Java 12, and
make Ultrasonic failed to parse.

Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
2019-08-31 10:11:30 +08:00
Evan Harris 6e8ae8971c Enable checkstyle OverloadMethodsDeclarationOrder 2019-08-16 18:08:42 -05:00
Evan Harris 1acfacb4c6 Enable checkstyle FileTabCharacter 2019-08-15 18:40:04 -05:00
Evan Harrisandjvoisin 16039d5e81 Enable checkstyle UniqueProperties 2019-08-15 22:07:53 +00:00
Evan Harrisandjvoisin fcc68febc8 Enable several more code checkstyles 2019-08-15 22:07:32 +00:00
Evan Harrisandjvoisin 389db3f1b4 Enable checkstyle for simple boolean expressions 2019-08-11 20:10:06 +00:00
Evan Harrisandjvoisin f738819625 Enable additional checkstyles for whitespace
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
2019-08-11 20:09:40 +00:00
Evan Harrisandjvoisin 86a5b8708d Enable checkstyle OneStatementPerLine 2019-08-08 21:26:01 +00:00
Evan Harrisandjvoisin 153ad19b6b Enable several more checkstyle modules
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
2019-08-07 22:46:10 +00:00
jvoisinandGitHub 7578ee9537 Enable checkstyle's Indentation module 2019-08-07 20:13:29 +00:00
jvoisinandGitHub fabed228da Enable EqualsAvoidNull in checkstyle 2019-08-07 19:12:04 +00:00
Evan Harrisandjvoisin 3c5735e03e Fix null exception when creating a new podcast channel
Until the podcast channel has been updated to provide it with a title, there
is no point to doing any further processing since the directory where episodes
are stored is derived from the title.

While this change is unrelated to #176, it fixes the traceback shown in that
issue.
2019-08-07 09:14:18 +00:00
jvoisin 49c6e89f73 Ignore CVE-2019-14439 too 2019-08-07 02:09:52 +02:00
jvoisin 8260fed1b3 Ignore CVE-2019-14379 2019-08-07 01:57:54 +02:00
jvoisin b650ac70d6 Temporarily skip a test
Based on tesshucom's #1192
2019-08-07 01:52:17 +02:00
jvoisinandGitHub 9a5f3f9483 Replace a now-defunct maven repo with a working one 2019-08-04 21:02:51 +00:00
jvoisin 4a85cdbc7a Sort the checkstyle modules 2019-08-01 10:46:26 +02:00
jvoisin 0d6ed81b83 Add a check for InnerAssignment in checkstyle.xml 2019-08-01 10:36:51 +02:00
jvoisin ba9d3ff539 Remove an empty statement 2019-08-01 10:30:26 +02:00
jvoisin 61c8fbc5e2 Add more style checks 2019-08-01 10:21:54 +02:00
jvoisin 10b41160c0 Enabled StringLiteralEquality in CheckStyle 2019-07-31 00:26:58 +02:00
jvoisin 167d1d9c20 Enable EqualsHashCode in CheckStyle 2019-07-31 00:23:18 +02:00
jvoisinandGitHub 8ba97026a4 Synchronize on activeAudioPlayers when changing them 2019-07-27 16:28:51 +00:00
Andrew DeMariaandjvoisin e7bd5da6fa Precompile jsp
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-07-27 16:25:59 +00:00
tesshucomandAndrew DeMaria ff08f6dd02 Fix #1139 2019-07-25 19:26:01 -06:00
Evan Harris 093f7c028d Fix podcast download issues
Some podcast feeds use circular redirects (with query parameters).
Fixes #1013
Avoids HttpClient cookie handling producing "Invalid cookie" errors due to
not handling latest "expires" attribute formats.
2019-07-24 23:30:40 -05:00
jvoisin d256386cbb Use titles in some <img> tags 2019-07-22 22:49:11 +02:00
Evan Harrisandjvoisin bf309e9117 Fixup eccb7e08f5 (#1170) 2019-07-17 22:48:41 +00:00
jvoisinandAndrew DeMaria eccb7e08f5 Fix a NULL-deref in CoverArtController.java
ImageIO.read() can return null in certain cases
2019-07-14 11:54:30 -06:00
jvoisinandAndrew DeMaria e9ea61036f First pass of CSP-compliance for mousetrap
Since the preference for the keyboard shortcuts
is set server-side, I had to shove them into a non-javascript
context, and then access them via javascript,
in a separate file.

Since I'm not a javascript expert, I'm more than open
to alternatives if this isn't the right way™ to do it.
2019-07-14 11:46:28 -06:00
Andrew DeMaria cb8fc14858 Some release note fixes
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-07-13 18:12:01 -06:00
Andrew DeMaria 859d08fc02 Bump version
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-07-13 18:10:18 -06:00
Andrew DeMaria 5d459d20e9 Add date for changelog 2019-07-13 17:58:14 -06:00
Andrew DeMaria acb89fc556 Update changelog
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-07-13 17:56:27 -06:00
Andrew DeMaria 8db4ec12e1 Add sha256sums and gpg sign outside of maven process
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-07-13 16:19:45 -06:00
jvoisinandGitHub 3b8993e860 Replace Hashtable with HashMap, since Hashtable are deprecated 2019-07-13 11:38:01 +00:00
jvoisinandGitHub a997fd4873 Bump jaxb-impl and jaxb-core 2019-07-13 11:34:44 +00:00
jvoisinandGitHub 61e3bc059d Bump javax annotation 2019-07-13 11:33:44 +00:00
Andrew DeMaria 85716941dc Merge remote-tracking branch 'origin/pr/1162' 2019-07-10 10:08:36 -06:00
tesshucom 4ce892e39d Fix for duplication and synchronization.
- Moved MusicFolderTestData
   from org.airsonic.player.service
   to   org.airsonic.player.util
2019-07-10 04:45:22 +09:00
Andrew DeMaria 0dd16c2cd8 Merge remote-tracking branch 'origin/pr/1152' 2019-07-09 13:08:17 -06:00
Andrew DeMaria 0bc15b404e Merge remote-tracking branch 'origin/pr/1164' 2019-07-08 12:26:08 -06:00
Andrew DeMaria 05c8bdf73a Merge remote-tracking branch 'origin/pr/897' 2019-07-08 12:25:33 -06:00
jo b4dfa1edc5 Add Weblate config 2019-07-08 17:22:45 +02:00
Evan Harris 50b3fd382c Handle null without exception 2019-07-08 02:57:41 -05:00
tesshucom 4a728ed9a6 Add and modify comments 2019-07-08 05:44:03 +09:00