546451bf0a
Merge remote-tracking branch 'origin/pr/1355'
6 years ago
e2c4f57671
Merge remote-tracking branch 'origin/pr/1300'
6 years ago
cb63a5cb88
Add jxr plugin for pmd refs
6 years ago
ef22d6d8ed
Remove optional jetty runtime
...
- Simplifies pom making future upgrades easier
- Fixes tests picking up jetty runtime
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
39f75fd4a0
Merge remote-tracking branch 'origin/pr/1376'
6 years ago
2ef4a7131d
Merge remote-tracking branch 'origin/pr/1350'
6 years ago
437d8ce947
Move index meta information
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
a79b56fe5a
Removed unused variables, imports, empty statements ( #1361 )
...
Also some unnecessary whitespace.
6 years ago
821d8d6b8c
Merge pull request #1387 from randomnicode/fixtestqueries
...
Fix test queries for limits
6 years ago
4b852c53e2
Fix Test Queries for limits
6 years ago
bc0ef1ea27
Cleanup extraneous quote
6 years ago
5bbcd6d84b
Document a bit our review process ( #1353 )
...
@randomnicode asked some good questions in #1348
about out governance/contribution/review/… processes,
so here is a commit to document them a bit.
6 years ago
8728566860
Switch to using ScheduledExecutor for MediaScanner
6 years ago
a9a7b08230
Use the try-with-resource construct where possible
6 years ago
a81dbc7e23
Additions to gitignore for static analysis plugins
6 years ago
6d092286e3
Remove openjdk-ea for now
...
It's breaking the build in weird ways, we
can always add it back later.
6 years ago
2da9c7310a
Changed final constant to add static
6 years ago
fd1b154a3c
Simplify a bit a function
...
Credit goes to eharris@
6 years ago
1bc5729cfb
Remove the parseLocale function in SettingsService
6 years ago
d2ad85447b
Remove the unused md5Hex method
6 years ago
d07d0ad687
Tighten en exception
6 years ago
e1a8a3b752
Use a switch-case instead of if-spaghettis
6 years ago
6b54086590
Remove an unused method
6 years ago
332718386b
Simplify the parseInts method
6 years ago
29b083ddac
Simplify the split method
...
Use a regexp with two groups, instead of
doing some black magic manually.
6 years ago
e1583691d8
Replace StringUtil.toHtml with StringEscapeUtils.escapeHtml
...
Apache commons is providing Html-escaping, no need to reinvent the wheel:
> It supports all known HTML 4.0 entities, including funky accents. Note that the
> commonly used apostrophe escape character (') is not a legal entity and so
> is not supported).
So I manually checked that nothing is relying on escaped single-quotes,
and didn't manage to find anything that does.
6 years ago
9dc9cbd821
Remove the unused toISO8601 method
6 years ago
a0cc372abc
Add OpenJDK 13 and OpenJDK-dev to travis
6 years ago
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
6 years ago
b37cbf6617
Merge pull request #1359 from randomnicode/minorfixtostatictimeunit
...
Minor fix to static time unit call
6 years ago
320e2a7b77
Merge pull request #1352 from fxthomas/1333-allow-previous-migration-checksums-for-mariadb
...
Allow previous Liquibase migration checksums for MariaDB
6 years ago
78a99d5860
Allow previous Liquibase migration checksums for MariaDB
...
If someone was using MariaDB before #1188 , they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).
This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188 .
6 years ago
acb4e033aa
Minor fix to static time unit call
6 years ago
a793deab0b
Got rid of duplicated code to format durations
...
Added new functions and test cases.
6 years ago
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
6 years ago
0c0561d104
Bump apache's cxf
6 years ago
599eb8574d
Bump OWASP's maven dependency's check
6 years ago
f910c572c9
Use a static access in a test file, because we can.
6 years ago
a4cc1ec6ec
Bump jackson to a proper release
6 years ago
29c1b5dbca
Enabled PMD checking for jsp files
...
2 rulesets are included.
6 years ago
42537686fc
Added page encoding meta tags to jsp files to satisfy PMD
6 years ago
4098d801fc
Fixed a bunch of quoting issues in jsp files
...
All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too.
6 years ago
cd0dc8673d
Move DOCTYPE line to top of all jsp files
...
Not doing this causes violations when using PMD.
6 years ago
2438044c5d
Merge pull request #1265 from benferreri/master
...
Add discogs search link to main album page
6 years ago
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
6 years ago
460589f590
Added an SVG icon for shuffle in dark theme
6 years ago
18e2fe6449
Changed link text from "more" to "refresh" (more correct)
...
Also added refresh SVG icons to match the text.
6 years ago
91f91ed654
Removed the auto-refresh feature
...
This feature just generated a lot of unnecessary traffic to the server and
hurt usability because the page would refresh unexpectedly while a user was
actively looking at content. Fixes #1003 , #1179 , #729 .
Did not remove the column for that setting in the user database, since that
would lead to complications if needing to downgrade for some reason.
6 years ago
d17c00115a
Minor refactor of CsrfSecurityRequestMatcher
...
- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
d61a00e830
Merge remote-tracking branch 'origin/pr/1315'
6 years ago
Andrew DeMaria
Evan Harris
François-Xavier Thomas
Randomnicode
jvoisin
randomnicode
jvoisin