Commit Graph
1278 Commits
Author SHA1 Message Date
Evan Harris bc0ef1ea27 Cleanup extraneous quote 2019-10-30 17:11:32 -05:00
jvoisinandGitHub 5bbcd6d84b Document a bit our review process (#1353)
@randomnicode asked some good questions in #1348
about out governance/contribution/review/… processes,
so here is a commit to document them a bit.
2019-10-30 22:00:52 +00:00
jvoisinandGitHub a9a7b08230 Use the try-with-resource construct where possible 2019-10-25 19:43:24 +00:00
randomnicodeandjvoisin a81dbc7e23 Additions to gitignore for static analysis plugins 2019-10-25 19:42:05 +00:00
jvoisin 6d092286e3 Remove openjdk-ea for now
It's breaking the build in weird ways, we
can always add it back later.
2019-10-25 17:55:52 +02:00
Evan Harrisandjvoisin 2da9c7310a Changed final constant to add static 2019-10-24 19:43:51 +00:00
jvoisinandGitHub a0cc372abc Add OpenJDK 13 and OpenJDK-dev to travis 2019-10-24 19:40:41 +00:00
jvoisinandGitHub 9f6b02c5d0 Refactor a bit how we're handling avatars
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
2019-10-24 19:39:39 +00:00
François-Xavier ThomasandGitHub b37cbf6617 Merge pull request #1359 from randomnicode/minorfixtostatictimeunit
Minor fix to static time unit call
2019-10-22 21:33:39 +02:00
François-Xavier ThomasandGitHub 320e2a7b77 Merge pull request #1352 from fxthomas/1333-allow-previous-migration-checksums-for-mariadb
Allow previous Liquibase migration checksums for MariaDB
2019-10-22 20:27:53 +02:00
François-Xavier Thomas 78a99d5860 Allow previous Liquibase migration checksums for MariaDB
If someone was using MariaDB before #1188, they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).

This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188.
2019-10-21 22:00:37 +02:00
Randomnicode acb4e033aa Minor fix to static time unit call 2019-10-21 11:55:01 -07:00
jvoisin 0c0561d104 Bump apache's cxf 2019-10-20 23:50:59 +02:00
jvoisin 599eb8574d Bump OWASP's maven dependency's check 2019-10-20 22:55:34 +02:00
jvoisin f910c572c9 Use a static access in a test file, because we can. 2019-10-20 22:43:10 +02:00
jvoisin a4cc1ec6ec Bump jackson to a proper release 2019-10-20 22:27:36 +02:00
François-Xavier ThomasandGitHub 2438044c5d Merge pull request #1265 from benferreri/master
Add discogs search link to main album page
2019-10-20 16:08:16 +02:00
jvoisinandGitHub d3a9a3226f Replace deprecated Date by Calendar
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
2019-10-17 21:28:40 +00:00
jvoisinandAndrew DeMaria d17c00115a Minor refactor of CsrfSecurityRequestMatcher
- use plain string comparison instead of regexp
- Simplify data structures

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-10-15 21:15:55 -06:00
Andrew DeMaria d61a00e830 Merge remote-tracking branch 'origin/pr/1315' 2019-10-15 21:13:46 -06:00
Andrew DeMaria 75705e8f2d Merge remote-tracking branch 'origin/pr/1324' 2019-10-15 21:11:08 -06:00
Andrew DeMaria 75a280457e Merge remote-tracking branch 'origin/pr/1327' 2019-10-15 21:09:48 -06:00
Andrew DeMaria 0d0683d066 Merge remote-tracking branch 'origin/pr/1335' 2019-10-15 21:08:39 -06:00
Andrew DeMaria ceb6b3e598 Merge remote-tracking branch 'origin/pr/1332' 2019-10-15 21:07:42 -06:00
Andrew DeMaria 378850a9b1 Merge remote-tracking branch 'origin/pr/1330' 2019-10-15 21:05:12 -06:00
Evan Harris c728d267c7 Fixed inconsistencies in SVG icon colors 2019-10-15 20:51:04 -05:00
jvoisin af28e7c257 Fix the syntax for sunfire's exclusion 2019-10-16 01:11:11 +02:00
Evan Harris 4fb9820a08 Added test case sources to checkstyle
Fixes #1328.
2019-10-15 12:38:52 -05:00
Phil Hudson 0a94058a62 Fix broken update link 2019-10-15 17:24:50 +08:00
Andrew DeMaria 666bc66ec8 Merge remote-tracking branch 'origin/pr/1313' 2019-10-14 21:38:45 -06:00
Andrew DeMaria 7d0328cf8d Update changelog with 10.4.1 release
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-10-14 20:57:12 -06:00
jvoisinandGitHub 82fa09d198 Bump jwt 2019-10-13 23:32:45 +00:00
jvoisin 78480ab766 Remove a homemade implementation of Pair
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
2019-10-13 23:36:33 +02:00
jvoisin c25e26d61a Remove a dead file 2019-10-12 13:07:35 +02:00
jvoisin 06e36ff154 Mark a field as private
Since we're synchronising on playQueue, we should make
it final.
2019-10-12 12:55:58 +02:00
Evan Harris 06f81f8b97 Added separate user icon from logout icon
Fixes #1305 and improves navigation.
2019-10-12 00:45:25 -05:00
Andrew DeMaria 89ea120a2f Merge remote-tracking branch 'origin/pr/1310' 2019-10-11 21:16:59 -06:00
Andrew DeMaria 357758ba4e Merge remote-tracking branch 'origin/pr/1312' 2019-10-11 21:15:17 -06:00
Andrew DeMaria 7058b5098d Merge remote-tracking branch 'origin/pr/1302' 2019-10-11 21:14:05 -06:00
François-Xavier Thomas 6b2c7e338d Remove white underline from player controls 2019-10-12 01:03:51 +02:00
François-Xavier Thomas 09808b170e Update dark icons for the 'groove' theme 2019-10-12 00:49:09 +02:00
François-Xavier Thomas 8b72964086 Display file id and path in debug scanning logs 2019-10-11 23:40:19 +02:00
jvoisin b6414ebb6c Simplify a condition 2019-10-11 23:27:53 +02:00
jvoisin 9f027f333e Upgrade PlaylistService to non-deprecated methods
As documented here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/Assert.html#notNull-java.lang.Object-java.lang.String-
2019-10-11 22:17:42 +02:00
Andrew DeMaria 3fe6e8b267 Add logger name checkstyle
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-10-10 00:05:35 -06:00
Evan Harris d8464e6497 Updated the issue template to add language
Also corrected some other typos and suggested using file attachments
or gist's for large logs.
2019-10-09 14:35:00 -05:00
Evan HarrisandAndrew DeMaria f644f5a1d0 Improved handling of missing/failed transcoder
Fixes #659.

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-10-08 18:41:55 -06:00
Andrew DeMariaandjvoisin 431b42bfb3 Ensure commons logging is excluded (#1274)
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-10-08 14:27:56 +00:00
Evan Harris 6783ced897 Removed inability to change roles for admin user 2019-10-08 06:38:57 -05:00
jvoisinandAndrew DeMaria 6f590f7740 Check the return value of delete calls
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-10-08 00:39:16 -06:00