Commit Graph
642 Commits
Author SHA1 Message Date
Evan Harris f62617df56 Added refresh link to all home navigation types
This adds a refresh link to all homePager.jsp browse methods in a
consistent place, so that users can easily refresh the proper frame
without causing a whole page refresh that would interrupt the web
player.
This is a follow-on to #1339 which removed the auto-refresh feature.
A side effect of this cleanup was to change all spacing between sets
of elements to a standard 2em to the right which made the layout
less convoluted.
2019-11-20 04:52:53 -06:00
Evan HarrisandGitHub 569a55259f Merge pull request #1339 from eharris/remove-autorefresh
Removed the auto-refresh feature
2019-11-20 04:21:38 -06:00
Evan Harris a44cad0c5b Removed duplicate Integer parsing code 2019-11-12 01:50:02 -06:00
Evan Harris 4a1493e474 Removed duplicated code 2019-11-12 01:50:02 -06:00
Evan Harris ecc026b3e8 Changed to use short-cut logic and other cleanups 2019-11-12 01:49:42 -06:00
Andrew DeMaria 1bdc45062a Merge remote-tracking branch 'origin/pr/1338' 2019-11-11 23:27:19 -07:00
François-Xavier ThomasandGitHub 0041fd7951 Merge pull request #1393 from muff1nman/pmd-with-source-refs
Add jxr plugin for pmd refs
2019-11-10 19:54:41 +01:00
Andrew DeMaria 35eaae39db Bump snapshot version
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-11-07 23:55:19 -07:00
prschopfandGitHub 3cb26bf6db Update ResourceBundle_pt_BR.properties 2019-11-06 23:25:11 -03:00
prschopfandGitHub 55cb221533 Update ResourceBundle_pt_BR.properties 2019-11-06 23:19:06 -03:00
prschopfandGitHub c6873a86a8 Update ResourceBundle_pt_BR.properties 2019-11-06 23:16:43 -03:00
Andrew DeMaria 2caa2550ef Change exception handling to log at debug 2019-11-03 17:29:49 -07:00
Andrew DeMaria ee5cbfdad0 Merge remote-tracking branch 'origin/pr/1287' 2019-11-03 17:11:00 -07:00
Andrew DeMaria eda6406865 Merge remote-tracking branch 'origin/pr/1262' 2019-11-03 14:57:19 -07:00
Andrew DeMaria 546451bf0a Merge remote-tracking branch 'origin/pr/1355' 2019-11-03 14:52:42 -07:00
Andrew DeMaria e2c4f57671 Merge remote-tracking branch 'origin/pr/1300' 2019-11-03 14:41:28 -07:00
Andrew DeMaria cb63a5cb88 Add jxr plugin for pmd refs 2019-11-03 14:37:28 -07:00
Andrew DeMaria ef22d6d8ed Remove optional jetty runtime
- Simplifies pom making future upgrades easier
- Fixes tests picking up jetty runtime

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-11-03 14:22:59 -07:00
Andrew DeMaria 39f75fd4a0 Merge remote-tracking branch 'origin/pr/1376' 2019-11-03 14:08:33 -07:00
Andrew DeMaria 2ef4a7131d Merge remote-tracking branch 'origin/pr/1350' 2019-11-03 14:08:19 -07:00
Andrew DeMaria 437d8ce947 Move index meta information
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-11-03 13:59:27 -07:00
Evan HarrisandJonas L a79b56fe5a Removed unused variables, imports, empty statements (#1361)
Also some unnecessary whitespace.
2019-11-03 14:35:53 +01:00
Randomnicode 4b852c53e2 Fix Test Queries for limits 2019-11-01 14:26:45 -07:00
Randomnicode 8728566860 Switch to using ScheduledExecutor for MediaScanner 2019-10-26 04:28:49 -07:00
jvoisinandGitHub a9a7b08230 Use the try-with-resource construct where possible 2019-10-25 19:43:24 +00:00
Evan Harrisandjvoisin 2da9c7310a Changed final constant to add static 2019-10-24 19:43:51 +00:00
jvoisin fd1b154a3c Simplify a bit a function
Credit goes to eharris@
2019-10-24 21:42:50 +02:00
jvoisin 1bc5729cfb Remove the parseLocale function in SettingsService 2019-10-24 21:42:50 +02:00
jvoisin d2ad85447b Remove the unused md5Hex method 2019-10-24 21:42:50 +02:00
jvoisin d07d0ad687 Tighten en exception 2019-10-24 21:42:50 +02:00
jvoisin e1a8a3b752 Use a switch-case instead of if-spaghettis 2019-10-24 21:42:50 +02:00
jvoisin 6b54086590 Remove an unused method 2019-10-24 21:42:50 +02:00
jvoisin 332718386b Simplify the parseInts method 2019-10-24 21:42:50 +02:00
jvoisin 29b083ddac Simplify the split method
Use a regexp with two groups, instead of
doing some black magic manually.
2019-10-24 21:42:50 +02:00
jvoisin e1583691d8 Replace StringUtil.toHtml with StringEscapeUtils.escapeHtml
Apache commons is providing Html-escaping, no need to reinvent the wheel:

> It supports all known HTML 4.0 entities, including funky accents. Note that the
> commonly used apostrophe escape character (&apos;) is not a legal entity and so
> is not supported).

So I manually checked that nothing is relying on escaped single-quotes,
and didn't manage to find anything that does.
2019-10-24 21:42:50 +02:00
jvoisin 9dc9cbd821 Remove the unused toISO8601 method 2019-10-24 21:42:50 +02:00
jvoisinandGitHub 9f6b02c5d0 Refactor a bit how we're handling avatars
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
2019-10-24 19:39:39 +00:00
François-Xavier ThomasandGitHub b37cbf6617 Merge pull request #1359 from randomnicode/minorfixtostatictimeunit
Minor fix to static time unit call
2019-10-22 21:33:39 +02:00
François-Xavier ThomasandGitHub 320e2a7b77 Merge pull request #1352 from fxthomas/1333-allow-previous-migration-checksums-for-mariadb
Allow previous Liquibase migration checksums for MariaDB
2019-10-22 20:27:53 +02:00
François-Xavier Thomas 78a99d5860 Allow previous Liquibase migration checksums for MariaDB
If someone was using MariaDB before #1188, they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).

This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188.
2019-10-21 22:00:37 +02:00
Randomnicode acb4e033aa Minor fix to static time unit call 2019-10-21 11:55:01 -07:00
Evan Harris a793deab0b Got rid of duplicated code to format durations
Added new functions and test cases.
2019-10-21 07:46:16 -05:00
Evan Harris 0660c4f3e6 Renamed StringUtil.formatDuration to formatDurationMSS 2019-10-21 07:01:34 -05:00
jvoisin f910c572c9 Use a static access in a test file, because we can. 2019-10-20 22:43:10 +02:00
Evan Harris 29c1b5dbca Enabled PMD checking for jsp files
2 rulesets are included.
2019-10-20 10:20:42 -05:00
Evan Harris 42537686fc Added page encoding meta tags to jsp files to satisfy PMD 2019-10-20 10:20:41 -05:00
Evan Harris 4098d801fc Fixed a bunch of quoting issues in jsp files
All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too.
2019-10-20 10:20:31 -05:00
Evan Harris cd0dc8673d Move DOCTYPE line to top of all jsp files
Not doing this causes violations when using PMD.
2019-10-20 10:03:22 -05:00
François-Xavier ThomasandGitHub 2438044c5d Merge pull request #1265 from benferreri/master
Add discogs search link to main album page
2019-10-20 16:08:16 +02:00
jvoisinandGitHub d3a9a3226f Replace deprecated Date by Calendar
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
2019-10-17 21:28:40 +00:00