Evan Harris
a44cad0c5b
Removed duplicate Integer parsing code
5 years ago
Evan Harris
4a1493e474
Removed duplicated code
5 years ago
Evan Harris
ecc026b3e8
Changed to use short-cut logic and other cleanups
5 years ago
Andrew DeMaria
35eaae39db
Bump snapshot version
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
prschopf
3cb26bf6db
Update ResourceBundle_pt_BR.properties
5 years ago
prschopf
55cb221533
Update ResourceBundle_pt_BR.properties
5 years ago
prschopf
c6873a86a8
Update ResourceBundle_pt_BR.properties
5 years ago
Andrew DeMaria
2caa2550ef
Change exception handling to log at debug
5 years ago
Andrew DeMaria
cb63a5cb88
Add jxr plugin for pmd refs
5 years ago
Andrew DeMaria
ef22d6d8ed
Remove optional jetty runtime
...
- Simplifies pom making future upgrades easier
- Fixes tests picking up jetty runtime
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
437d8ce947
Move index meta information
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
a79b56fe5a
Removed unused variables, imports, empty statements ( #1361 )
...
Also some unnecessary whitespace.
5 years ago
Randomnicode
4b852c53e2
Fix Test Queries for limits
5 years ago
Randomnicode
8728566860
Switch to using ScheduledExecutor for MediaScanner
5 years ago
jvoisin
a9a7b08230
Use the try-with-resource construct where possible
5 years ago
Evan Harris
2da9c7310a
Changed final constant to add static
5 years ago
jvoisin
fd1b154a3c
Simplify a bit a function
...
Credit goes to eharris@
5 years ago
jvoisin
1bc5729cfb
Remove the parseLocale function in SettingsService
5 years ago
jvoisin
d2ad85447b
Remove the unused md5Hex method
5 years ago
jvoisin
d07d0ad687
Tighten en exception
5 years ago
jvoisin
e1a8a3b752
Use a switch-case instead of if-spaghettis
5 years ago
jvoisin
6b54086590
Remove an unused method
5 years ago
jvoisin
332718386b
Simplify the parseInts method
5 years ago
jvoisin
29b083ddac
Simplify the split method
...
Use a regexp with two groups, instead of
doing some black magic manually.
5 years ago
jvoisin
e1583691d8
Replace StringUtil.toHtml with StringEscapeUtils.escapeHtml
...
Apache commons is providing Html-escaping, no need to reinvent the wheel:
> It supports all known HTML 4.0 entities, including funky accents. Note that the
> commonly used apostrophe escape character (') is not a legal entity and so
> is not supported).
So I manually checked that nothing is relying on escaped single-quotes,
and didn't manage to find anything that does.
5 years ago
jvoisin
9dc9cbd821
Remove the unused toISO8601 method
5 years ago
jvoisin
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
5 years ago
François-Xavier Thomas
78a99d5860
Allow previous Liquibase migration checksums for MariaDB
...
If someone was using MariaDB before #1188 , they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).
This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188 .
5 years ago
Randomnicode
acb4e033aa
Minor fix to static time unit call
5 years ago
Evan Harris
a793deab0b
Got rid of duplicated code to format durations
...
Added new functions and test cases.
5 years ago
Evan Harris
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
5 years ago
jvoisin
f910c572c9
Use a static access in a test file, because we can.
5 years ago
Evan Harris
29c1b5dbca
Enabled PMD checking for jsp files
...
2 rulesets are included.
5 years ago
Evan Harris
42537686fc
Added page encoding meta tags to jsp files to satisfy PMD
5 years ago
Evan Harris
4098d801fc
Fixed a bunch of quoting issues in jsp files
...
All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too.
5 years ago
Evan Harris
cd0dc8673d
Move DOCTYPE line to top of all jsp files
...
Not doing this causes violations when using PMD.
5 years ago
jvoisin
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
5 years ago
Evan Harris
460589f590
Added an SVG icon for shuffle in dark theme
5 years ago
Evan Harris
18e2fe6449
Changed link text from "more" to "refresh" (more correct)
...
Also added refresh SVG icons to match the text.
5 years ago
Evan Harris
91f91ed654
Removed the auto-refresh feature
...
This feature just generated a lot of unnecessary traffic to the server and
hurt usability because the page would refresh unexpectedly while a user was
actively looking at content. Fixes #1003 , #1179 , #729 .
Did not remove the column for that setting in the user database, since that
would lead to complications if needing to downgrade for some reason.
5 years ago
jvoisin
d17c00115a
Minor refactor of CsrfSecurityRequestMatcher
...
- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
c728d267c7
Fixed inconsistencies in SVG icon colors
5 years ago
Evan Harris
4fb9820a08
Added test case sources to checkstyle
...
Fixes #1328 .
5 years ago
Phil Hudson
0a94058a62
Fix broken update link
5 years ago
jvoisin
82fa09d198
Bump jwt
5 years ago
jvoisin
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
5 years ago
jvoisin
c25e26d61a
Remove a dead file
5 years ago
jvoisin
06e36ff154
Mark a field as private
...
Since we're synchronising on playQueue, we should make
it final.
5 years ago
Evan Harris
06f81f8b97
Added separate user icon from logout icon
...
Fixes #1305 and improves navigation.
5 years ago
François-Xavier Thomas
6b2c7e338d
Remove white underline from player controls
5 years ago