jvoisin
3d8f3ed21d
Gracefully handle failed version check attempts
...
This issue what found by darkling, and reported on irc
5 years ago
Evan Harris
b02fd9ad6c
Change integration tests from parallel to single
...
This is an attempt to make the Travis CI integration tests more reliable,
and changes from parallel to single forking mode.
This is a temporary measure until cucumber-jvm-parallel-plugin (which is no
longer supported) is ripped out (see #1240 )
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
d4aff1dca5
Added checkstyle to prohibit windows line endings
...
Suggestion taken from jvoisin in #1121 .
5 years ago
tesshucom
5c3c558923
Update Lucene from 3.0.3 to the current version 8.2.0
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Sid
8e279a2d2a
Fix to clean up docker instance on RunTimeException in Integration Tests
...
Signed-off-by: Sid <shyamindra@gmail.com>
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Celedhrim
c16fa9d159
Update db-changelog.xml to support mariadb
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
c6540d707e
Simplify a bit the annotations
...
There is no need to specify `value` every single time
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
eb4c5a04ff
Make the systemd unit compatible with tomcat9
...
- Use ReadWritePaths by default, since it doesn't
cause any harm
- Rephrase the ProtectSystem comment, to make it more clear
- Fix verbs in a comment
5 years ago
Evan Harris
83ca97e21c
Improve error handling for jaudiotaggerParser artwork fetch
5 years ago
jvoisin
6f57c6e313
Remove an unused/unuseable/half-done cache
5 years ago
jvoisin
46d806df1d
Fix two issues found by LGTM
5 years ago
jvoisin
c0fa01206a
Ignore yet an other jackson vulnerability
5 years ago
jvoisin
e085d77635
Remove use useless arrays creation
5 years ago
Evan Harris
4679bac08d
Added handling for LyricsService ConnectTimeoutException
5 years ago
Evan Harris
73768b94ea
Handle Lyrics fetch HttpResponseException
...
Also marked 503 error as retryable and added log message for socket error
5 years ago
Shen-Ta Hsieh
394dfa1ce7
upgrade jackson-databind and commons-beanutils for CVEs
...
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
5 years ago
Shen-Ta Hsieh
16c1e42b97
normalize license expire date to prevent outstanding value on Java 12
...
Date(Long.MAX_VALUE) is 292278994-08-17T07:12:55.807Z on Java 12, and
make Ultrasonic failed to parse.
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
5 years ago
Evan Harris
6e8ae8971c
Enable checkstyle OverloadMethodsDeclarationOrder
5 years ago
Evan Harris
1acfacb4c6
Enable checkstyle FileTabCharacter
5 years ago
Evan Harris
16039d5e81
Enable checkstyle UniqueProperties
5 years ago
Evan Harris
fcc68febc8
Enable several more code checkstyles
5 years ago
Evan Harris
389db3f1b4
Enable checkstyle for simple boolean expressions
5 years ago
Evan Harris
f738819625
Enable additional checkstyles for whitespace
...
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
5 years ago
Evan Harris
86a5b8708d
Enable checkstyle OneStatementPerLine
5 years ago
Evan Harris
153ad19b6b
Enable several more checkstyle modules
...
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
5 years ago
jvoisin
7578ee9537
Enable checkstyle's Indentation module
5 years ago
jvoisin
fabed228da
Enable EqualsAvoidNull in checkstyle
5 years ago
Evan Harris
3c5735e03e
Fix null exception when creating a new podcast channel
...
Until the podcast channel has been updated to provide it with a title, there
is no point to doing any further processing since the directory where episodes
are stored is derived from the title.
While this change is unrelated to #176 , it fixes the traceback shown in that
issue.
5 years ago
jvoisin
49c6e89f73
Ignore CVE-2019-14439 too
5 years ago
jvoisin
8260fed1b3
Ignore CVE-2019-14379
5 years ago
jvoisin
b650ac70d6
Temporarily skip a test
...
Based on tesshucom's #1192
5 years ago
jvoisin
9a5f3f9483
Replace a now-defunct maven repo with a working one
5 years ago
jvoisin
4a85cdbc7a
Sort the checkstyle modules
5 years ago
jvoisin
0d6ed81b83
Add a check for InnerAssignment in checkstyle.xml
5 years ago
jvoisin
ba9d3ff539
Remove an empty statement
5 years ago
jvoisin
61c8fbc5e2
Add more style checks
5 years ago
jvoisin
10b41160c0
Enabled StringLiteralEquality in CheckStyle
5 years ago
jvoisin
167d1d9c20
Enable EqualsHashCode in CheckStyle
5 years ago
jvoisin
8ba97026a4
Synchronize on activeAudioPlayers when changing them
5 years ago
Andrew DeMaria
e7bd5da6fa
Precompile jsp
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
tesshucom
ff08f6dd02
Fix #1139
5 years ago
Evan Harris
093f7c028d
Fix podcast download issues
...
Some podcast feeds use circular redirects (with query parameters).
Fixes #1013
Avoids HttpClient cookie handling producing "Invalid cookie" errors due to
not handling latest "expires" attribute formats.
5 years ago
jvoisin
d256386cbb
Use titles in some <img> tags
6 years ago
Evan Harris
bf309e9117
Fixup eccb7e08f5
( #1170 )
6 years ago
jvoisin
eccb7e08f5
Fix a NULL-deref in CoverArtController.java
...
ImageIO.read() can return null in certain cases
6 years ago
jvoisin
e9ea61036f
First pass of CSP-compliance for mousetrap
...
Since the preference for the keyboard shortcuts
is set server-side, I had to shove them into a non-javascript
context, and then access them via javascript,
in a separate file.
Since I'm not a javascript expert, I'm more than open
to alternatives if this isn't the right way™ to do it.
6 years ago
Andrew DeMaria
cb8fc14858
Some release note fixes
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
Andrew DeMaria
859d08fc02
Bump version
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
Andrew DeMaria
5d459d20e9
Add date for changelog
6 years ago
Andrew DeMaria
acb89fc556
Update changelog
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago