prschopf and GitHub
c6873a86a8
Update ResourceBundle_pt_BR.properties
2019-11-06 23:16:43 -03:00
Andrew DeMaria
2caa2550ef
Change exception handling to log at debug
2019-11-03 17:29:49 -07:00
Andrew DeMaria
ee5cbfdad0
Merge remote-tracking branch 'origin/pr/1287'
2019-11-03 17:11:00 -07:00
Andrew DeMaria
eda6406865
Merge remote-tracking branch 'origin/pr/1262'
2019-11-03 14:57:19 -07:00
Andrew DeMaria
546451bf0a
Merge remote-tracking branch 'origin/pr/1355'
2019-11-03 14:52:42 -07:00
Andrew DeMaria
e2c4f57671
Merge remote-tracking branch 'origin/pr/1300'
2019-11-03 14:41:28 -07:00
Andrew DeMaria
cb63a5cb88
Add jxr plugin for pmd refs
2019-11-03 14:37:28 -07:00
Andrew DeMaria
ef22d6d8ed
Remove optional jetty runtime
...
- Simplifies pom making future upgrades easier
- Fixes tests picking up jetty runtime
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-11-03 14:22:59 -07:00
Andrew DeMaria
39f75fd4a0
Merge remote-tracking branch 'origin/pr/1376'
2019-11-03 14:08:33 -07:00
Andrew DeMaria
2ef4a7131d
Merge remote-tracking branch 'origin/pr/1350'
2019-11-03 14:08:19 -07:00
Andrew DeMaria
437d8ce947
Move index meta information
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-11-03 13:59:27 -07:00
Evan Harris and Jonas L
a79b56fe5a
Removed unused variables, imports, empty statements ( #1361 )
...
Also some unnecessary whitespace.
2019-11-03 14:35:53 +01:00
Randomnicode
4b852c53e2
Fix Test Queries for limits
2019-11-01 14:26:45 -07:00
Randomnicode
8728566860
Switch to using ScheduledExecutor for MediaScanner
2019-10-26 04:28:49 -07:00
jvoisin and GitHub
a9a7b08230
Use the try-with-resource construct where possible
2019-10-25 19:43:24 +00:00
Evan Harris and jvoisin
2da9c7310a
Changed final constant to add static
2019-10-24 19:43:51 +00:00
jvoisin
fd1b154a3c
Simplify a bit a function
...
Credit goes to eharris@
2019-10-24 21:42:50 +02:00
jvoisin
1bc5729cfb
Remove the parseLocale function in SettingsService
2019-10-24 21:42:50 +02:00
jvoisin
d2ad85447b
Remove the unused md5Hex method
2019-10-24 21:42:50 +02:00
jvoisin
d07d0ad687
Tighten en exception
2019-10-24 21:42:50 +02:00
jvoisin
e1a8a3b752
Use a switch-case instead of if-spaghettis
2019-10-24 21:42:50 +02:00
jvoisin
6b54086590
Remove an unused method
2019-10-24 21:42:50 +02:00
jvoisin
332718386b
Simplify the parseInts method
2019-10-24 21:42:50 +02:00
jvoisin
29b083ddac
Simplify the split method
...
Use a regexp with two groups, instead of
doing some black magic manually.
2019-10-24 21:42:50 +02:00
jvoisin
e1583691d8
Replace StringUtil.toHtml with StringEscapeUtils.escapeHtml
...
Apache commons is providing Html-escaping, no need to reinvent the wheel:
> It supports all known HTML 4.0 entities, including funky accents. Note that the
> commonly used apostrophe escape character (') is not a legal entity and so
> is not supported).
So I manually checked that nothing is relying on escaped single-quotes,
and didn't manage to find anything that does.
2019-10-24 21:42:50 +02:00
jvoisin
9dc9cbd821
Remove the unused toISO8601 method
2019-10-24 21:42:50 +02:00
jvoisin and GitHub
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
2019-10-24 19:39:39 +00:00
François-Xavier Thomas and GitHub
b37cbf6617
Merge pull request #1359 from randomnicode/minorfixtostatictimeunit
...
Minor fix to static time unit call
2019-10-22 21:33:39 +02:00
François-Xavier Thomas and GitHub
320e2a7b77
Merge pull request #1352 from fxthomas/1333-allow-previous-migration-checksums-for-mariadb
...
Allow previous Liquibase migration checksums for MariaDB
2019-10-22 20:27:53 +02:00
François-Xavier Thomas
78a99d5860
Allow previous Liquibase migration checksums for MariaDB
...
If someone was using MariaDB before #1188 , they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).
This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188 .
2019-10-21 22:00:37 +02:00
Randomnicode
acb4e033aa
Minor fix to static time unit call
2019-10-21 11:55:01 -07:00
Evan Harris
a793deab0b
Got rid of duplicated code to format durations
...
Added new functions and test cases.
2019-10-21 07:46:16 -05:00
Evan Harris
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
2019-10-21 07:01:34 -05:00
jvoisin
f910c572c9
Use a static access in a test file, because we can.
2019-10-20 22:43:10 +02:00
Evan Harris
29c1b5dbca
Enabled PMD checking for jsp files
...
2 rulesets are included.
2019-10-20 10:20:42 -05:00
Evan Harris
42537686fc
Added page encoding meta tags to jsp files to satisfy PMD
2019-10-20 10:20:41 -05:00
Evan Harris
4098d801fc
Fixed a bunch of quoting issues in jsp files
...
All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too.
2019-10-20 10:20:31 -05:00
Evan Harris
cd0dc8673d
Move DOCTYPE line to top of all jsp files
...
Not doing this causes violations when using PMD.
2019-10-20 10:03:22 -05:00
François-Xavier Thomas and GitHub
2438044c5d
Merge pull request #1265 from benferreri/master
...
Add discogs search link to main album page
2019-10-20 16:08:16 +02:00
jvoisin and GitHub
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
2019-10-17 21:28:40 +00:00
Evan Harris
460589f590
Added an SVG icon for shuffle in dark theme
2019-10-17 15:57:05 -05:00
Evan Harris
18e2fe6449
Changed link text from "more" to "refresh" (more correct)
...
Also added refresh SVG icons to match the text.
2019-10-17 15:34:50 -05:00
Evan Harris
91f91ed654
Removed the auto-refresh feature
...
This feature just generated a lot of unnecessary traffic to the server and
hurt usability because the page would refresh unexpectedly while a user was
actively looking at content. Fixes #1003 , #1179 , #729 .
Did not remove the column for that setting in the user database, since that
would lead to complications if needing to downgrade for some reason.
2019-10-16 00:50:15 -05:00
jvoisin and Andrew DeMaria
d17c00115a
Minor refactor of CsrfSecurityRequestMatcher
...
- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-15 21:15:55 -06:00
Andrew DeMaria
d61a00e830
Merge remote-tracking branch 'origin/pr/1315'
2019-10-15 21:13:46 -06:00
Andrew DeMaria
75a280457e
Merge remote-tracking branch 'origin/pr/1327'
2019-10-15 21:09:48 -06:00
Andrew DeMaria
0d0683d066
Merge remote-tracking branch 'origin/pr/1335'
2019-10-15 21:08:39 -06:00
Andrew DeMaria
ceb6b3e598
Merge remote-tracking branch 'origin/pr/1332'
2019-10-15 21:07:42 -06:00
Evan Harris
c728d267c7
Fixed inconsistencies in SVG icon colors
2019-10-15 20:51:04 -05:00
Evan Harris
4fb9820a08
Added test case sources to checkstyle
...
Fixes #1328 .
2019-10-15 12:38:52 -05:00