Andrew DeMaria
666bc66ec8
Merge remote-tracking branch 'origin/pr/1313'
2019-10-14 21:38:45 -06:00
Andrew DeMaria
7d0328cf8d
Update changelog with 10.4.1 release
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-14 20:57:12 -06:00
jvoisin and GitHub
82fa09d198
Bump jwt
2019-10-13 23:32:45 +00:00
jvoisin
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
2019-10-13 23:36:33 +02:00
jvoisin
c25e26d61a
Remove a dead file
2019-10-12 13:07:35 +02:00
jvoisin
06e36ff154
Mark a field as private
...
Since we're synchronising on playQueue, we should make
it final.
2019-10-12 12:55:58 +02:00
Evan Harris
06f81f8b97
Added separate user icon from logout icon
...
Fixes #1305 and improves navigation.
2019-10-12 00:45:25 -05:00
Andrew DeMaria
89ea120a2f
Merge remote-tracking branch 'origin/pr/1310'
2019-10-11 21:16:59 -06:00
Andrew DeMaria
357758ba4e
Merge remote-tracking branch 'origin/pr/1312'
2019-10-11 21:15:17 -06:00
Andrew DeMaria
7058b5098d
Merge remote-tracking branch 'origin/pr/1302'
2019-10-11 21:14:05 -06:00
François-Xavier Thomas
6b2c7e338d
Remove white underline from player controls
2019-10-12 01:03:51 +02:00
François-Xavier Thomas
09808b170e
Update dark icons for the 'groove' theme
2019-10-12 00:49:09 +02:00
François-Xavier Thomas
8b72964086
Display file id and path in debug scanning logs
2019-10-11 23:40:19 +02:00
jvoisin
b6414ebb6c
Simplify a condition
2019-10-11 23:27:53 +02:00
jvoisin
9f027f333e
Upgrade PlaylistService to non-deprecated methods
...
As documented here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/Assert.html#notNull-java.lang.Object-java.lang.String-
2019-10-11 22:17:42 +02:00
Andrew DeMaria
3fe6e8b267
Add logger name checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-10 00:05:35 -06:00
Evan Harris
d8464e6497
Updated the issue template to add language
...
Also corrected some other typos and suggested using file attachments
or gist's for large logs.
2019-10-09 14:35:00 -05:00
Evan Harris
317b3a44b5
Fixed broken brace and quote splitting in help text
...
Hopefully fixes #1298 .
2019-10-09 14:14:13 -05:00
Evan Harris and Andrew DeMaria
f644f5a1d0
Improved handling of missing/failed transcoder
...
Fixes #659 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-08 18:41:55 -06:00
Andrew DeMaria and jvoisin
431b42bfb3
Ensure commons logging is excluded ( #1274 )
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-08 14:27:56 +00:00
Evan Harris
6783ced897
Removed inability to change roles for admin user
2019-10-08 06:38:57 -05:00
jvoisin and Andrew DeMaria
6f590f7740
Check the return value of delete calls
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-08 00:39:16 -06:00
Kessiler Rodrigues and Andrew DeMaria
4b3890f6ec
Replace custom circular buffer with Apache commons(CircularFifoQueue)
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-08 00:34:46 -06:00
jvoisin and Andrew DeMaria
42b4aaafc7
Use EnumMap in IndexManager
...
EnumMap are _much_ more efficient than HashMaps,
so we should use them if we can.
See here for more details: https://docs.oracle.com/javase/8/docs/api/java/util/EnumMap.html
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-08 00:29:03 -06:00
Andrew DeMaria
85f85fd88c
Make test results quieter
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-07 22:41:12 -06:00
jvoisin
1a7bb68dc6
Remove a leftover of the Radexo removal
...
This is a followup of 85e0e08d9a
2019-10-07 17:11:42 +02:00
Andrew DeMaria
f38142f271
Make coverity even quieter
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 21:15:29 -06:00
Andrew DeMaria
6ff5ad52d3
Shorten output
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 21:06:02 -06:00
Andrew DeMaria
3a2980e1db
Try compile
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 20:53:10 -06:00
Andrew DeMaria
b7ec9f0cc2
Revert "Revert coverity in travis - takes too long"
...
This reverts commit 32da2ec9fd .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 20:47:24 -06:00
Andrew DeMaria
32da2ec9fd
Revert coverity in travis - takes too long
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 20:46:16 -06:00
Andrew DeMaria
9ef7f47c45
Try to fix travis
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 20:31:03 -06:00
jvoisin
da34bf0d3f
Improve Windows system detection
...
Use apache commons instead of terrifyingly fragile black magic.
2019-10-07 01:16:34 +02:00
jvoisin and Andrew DeMaria
bf5e8ef247
Add coverity to travis-ci
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 16:13:25 -06:00
jvoisin and Andrew DeMaria
85e0e08d9a
Remove radeox
...
Radeox is a rendering engine for an unspecified markup.
Its [website](http://radeox.org/ ) is dead, the website
of its [authors](http://www.codehaus.org/ ) is dead too,
its [last commit](https://github.com/codehaus/radeox ) was 13 years ago.
It's only used for the welcome and login messages,
as well as comments from users. If we want to have some markup parsing,
we should use something maintained with autoescaping guarantees,
instead of a piece of zombie code prone to $DEITY knows what injections.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 16:02:46 -06:00
jvoisin and Andrew DeMaria
e5404648a4
Remove unnecessary exceptions and unused imports
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 16:00:29 -06:00
Evan Harris and Andrew DeMaria
90e6c77563
Fix incorrect absolute paths in css
...
Fixes #1256
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 15:55:19 -06:00
Andrew DeMaria
b778f7099f
Remove Tomcat version override
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 15:46:58 -06:00
Andrew DeMaria
776bb2cfef
Switch to newer modelAttribute
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 15:45:32 -06:00
Andrew DeMaria and GitHub
2f143ad6aa
Merge pull request #1279 from jvoisin/fix_javadoc
...
Fix some javadoc comments
2019-10-06 14:38:22 -07:00
jvoisin and Andrew DeMaria
dddf8dc0aa
Fix some javadoc comments
...
- Remove a dangling comment
- Delete half-documented parameters
- Fix some @see/@link
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-06 15:37:54 -06:00
jvoisin
889add6848
More lambdaification
2019-10-06 15:00:34 +02:00
jvoisin
362cf29e41
Fix some javadoc comments
...
- Remove a dangling comment
- Delete half-documented parameters
- Fix some @see/@link
2019-10-06 14:30:21 +02:00
Andrew DeMaria
45d789b64e
Option to disable timestamps during scan
...
I accidentally deleted most of my music directory. The database was
still intact. I recovered the music directory by rolling back to a
previous ZFS snapshot and performed a reindex. However, libresonic did
not mark the deleted files as present. Turns out the file timestamp was
unchanged through the ZFS restore, and so libresonic still thought the
last indexing effort was still "good".
This adds the option to ignore file timestamps when scanning files. This
can be helpful in the case of a restore as described above. There might
be a better way to do this, as this was really a quick effort on my part
to fix my own libresonic.
This does not add a UI, just a single property that can be turned on by
editing the lilbresonic.properties file.
@fxthomas suggested this could instead be a query parameter on the
initial issue #359 . That would basically move the potential UI to the
scan page. That would be fine, but I could imagine there might be cases
where people want this setting on all the time.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-05 21:25:17 -06:00
Evan Harris and Andrew DeMaria
41967e76df
Media file scan will now heed configured music/video file types
...
It will also now heed the Media Folders -> Exclude Pattern. Fixes #1227 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-05 21:14:31 -06:00
Evan Harris and Andrew DeMaria
1b28d2c2fe
Handle nulls when processing cover art better
...
This expands on commit d4487a07a0fcacea1544d61c79a380f2e9bf3087.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-05 20:06:09 -06:00
jvoisin and Andrew DeMaria
5c1451b904
Bump Spring
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-05 19:57:33 -06:00
jvoisin and Andrew DeMaria
dd1e0181d1
Please checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-05 19:48:00 -06:00
jvoisin and Andrew DeMaria
af05b0f45b
Use lambdas instead of ghetto nested types
...
This change was done in an automated fashion
via IntelliJ IDEA
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-05 19:47:48 -06:00
jvoisin and Andrew DeMaria
9cbcc94b58
Bump ehcache
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-10-05 19:44:29 -06:00