8b72964086
Display file id and path in debug scanning logs
6 years ago
b6414ebb6c
Simplify a condition
6 years ago
9f027f333e
Upgrade PlaylistService to non-deprecated methods
...
As documented here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/Assert.html#notNull-java.lang.Object-java.lang.String-
6 years ago
3fe6e8b267
Add logger name checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
d8464e6497
Updated the issue template to add language
...
Also corrected some other typos and suggested using file attachments
or gist's for large logs.
6 years ago
317b3a44b5
Fixed broken brace and quote splitting in help text
...
Hopefully fixes #1298 .
6 years ago
f644f5a1d0
Improved handling of missing/failed transcoder
...
Fixes #659 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
431b42bfb3
Ensure commons logging is excluded ( #1274 )
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
6783ced897
Removed inability to change roles for admin user
6 years ago
6f590f7740
Check the return value of `delete` calls
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
4b3890f6ec
Replace custom circular buffer with Apache commons(CircularFifoQueue)
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
42b4aaafc7
Use EnumMap in IndexManager
...
EnumMap are _much_ more efficient than HashMaps,
so we should use them if we can.
See here for more details: https://docs.oracle.com/javase/8/docs/api/java/util/EnumMap.html
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
85f85fd88c
Make test results quieter
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
1a7bb68dc6
Remove a leftover of the Radexo removal
...
This is a followup of 85e0e08d9a
6 years ago
f38142f271
Make coverity even quieter
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
6ff5ad52d3
Shorten output
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
3a2980e1db
Try compile
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
b7ec9f0cc2
Revert "Revert coverity in travis - takes too long"
...
This reverts commit 32da2ec9fd
6 years ago
32da2ec9fd
Revert coverity in travis - takes too long
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
9ef7f47c45
Try to fix travis
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
da34bf0d3f
Improve Windows system detection
...
Use apache commons instead of terrifyingly fragile black magic.
6 years ago
bf5e8ef247
Add coverity to travis-ci
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
85e0e08d9a
Remove radeox
...
Radeox is a rendering engine for an unspecified markup.
Its [website](http://radeox.org/ ) is dead, the website
of its [authors](http://www.codehaus.org/ ) is dead too,
its [last commit](https://github.com/codehaus/radeox ) was 13 years ago.
It's only used for the welcome and login messages,
as well as comments from users. If we want to have some markup parsing,
we should use something maintained with autoescaping guarantees,
instead of a piece of zombie code prone to $DEITY knows what injections.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
e5404648a4
Remove unnecessary exceptions and unused imports
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
90e6c77563
Fix incorrect absolute paths in css
...
Fixes #1256
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
b778f7099f
Remove Tomcat version override
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
776bb2cfef
Switch to newer modelAttribute
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
2f143ad6aa
Merge pull request #1279 from jvoisin/fix_javadoc
...
Fix some javadoc comments
6 years ago
dddf8dc0aa
Fix some javadoc comments
...
- Remove a dangling comment
- Delete half-documented parameters
- Fix some @see/@link
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
889add6848
More lambdaification
6 years ago
362cf29e41
Fix some javadoc comments
...
- Remove a dangling comment
- Delete half-documented parameters
- Fix some @see/@link
6 years ago
45d789b64e
Option to disable timestamps during scan
...
I accidentally deleted most of my music directory. The database was
still intact. I recovered the music directory by rolling back to a
previous ZFS snapshot and performed a reindex. However, libresonic did
not mark the deleted files as present. Turns out the file timestamp was
unchanged through the ZFS restore, and so libresonic still thought the
last indexing effort was still "good".
This adds the option to ignore file timestamps when scanning files. This
can be helpful in the case of a restore as described above. There might
be a better way to do this, as this was really a quick effort on my part
to fix my own libresonic.
This does not add a UI, just a single property that can be turned on by
editing the lilbresonic.properties file.
@fxthomas suggested this could instead be a query parameter on the
initial issue #359 . That would basically move the potential UI to the
scan page. That would be fine, but I could imagine there might be cases
where people want this setting on all the time.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
41967e76df
Media file scan will now heed configured music/video file types
...
It will also now heed the Media Folders -> Exclude Pattern. Fixes #1227 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
1b28d2c2fe
Handle nulls when processing cover art better
...
This expands on commit d4487a07a0fcacea1544d61c79a380f2e9bf3087.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
5c1451b904
Bump Spring
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
dd1e0181d1
Please checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
af05b0f45b
Use lambdas instead of ghetto nested types
...
This change was done in an automated fashion
via IntelliJ IDEA
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
9cbcc94b58
Bump ehcache
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
25327c69cc
Replace deprecated IOUtils.closeQuietly calls
...
Use FileUtil.closeQuietly instead, since it's our reimplemented of this deprecated method.
This change was done automatically via IntelliJ IDEA.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
645fb88c7d
Add expunge to IndexManager
...
When DB expunge is invoked from the management screen,
also indexManager performs expunge.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
c6ae5a1df7
Use `computeIfAbsent` instead of an `if`
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
888204ffe7
Remove an unused import
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
6 years ago
c0beca6a58
Use `removeIf` instead of doing this manually
6 years ago
13d5426449
escaped artist and album values in links; fixed allmusic link
6 years ago
38b602922b
Merge remote-tracking branch 'upstream/master'
6 years ago
f77a0d8b67
fixed 'Settings Saved' notification when saving transcoding settings #1114 ( #1269 )
...
Signed-off-by: Jon <jon@powha.net>
6 years ago
2fa584f81d
Merge branch 'origin/pr/1244'
6 years ago
45c6893f16
Making textareas vertical-align middle allows them to align with adjacent imgs.
...
Signed-off-by: Andrew V. Louis
6 years ago
207ee4569c
added discogs search link to main album page
...
Signed-off-by: benferreri <benferreri11@gmail.com>
6 years ago
5593275a5a
Fix the CSS for groove_simple
...
Previously, the css pointed to a non-existent
file path for the background.
6 years ago
François-Xavier Thomas
jvoisin
Andrew DeMaria
Evan Harris
Kessiler Rodrigues
tesshucom
benferreri
Jon Borglund
Andrew V. Louis