MightyPork/airsonic-custom
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Catch Exceptions instead of only Throwables in JAudiotaggerParser

Browse Source 
Since JAudioTagger isn't the rock-solidest software
in the world, we should catch as much things as possible
This commit is contained in:
jvoisin
2020-02-02 18:26:17 +01:00
parent a13552b6f5
commit c6eed14db5
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
airsonic-main/src/main/java/org/airsonic/player/service/metadata/JaudiotaggerParser.java
+3 -3
View File
@@ -86,7 +86,7 @@ public class JaudiotaggerParser extends MetaDataParser {
AudioFile audioFile; AudioFile audioFile;
try { try {
audioFile = AudioFileIO.read(file); audioFile = AudioFileIO.read(file);
} catch (Throwable x) { } catch (Exception x) {
LOG.warn("Error when parsing tags in " + file, x); LOG.warn("Error when parsing tags in " + file, x);
return metaData; return metaData;
} }
@@ -229,7 +229,7 @@ public class JaudiotaggerParser extends MetaDataParser {
audioFile.commit(); audioFile.commit();
} catch (Throwable x) { } catch (Exception x) {
LOG.warn("Failed to update tags for file " + file, x); LOG.warn("Failed to update tags for file " + file, x);
throw new RuntimeException("Failed to update tags for file " + file + ". " + x.getMessage(), x); throw new RuntimeException("Failed to update tags for file " + file + ". " + x.getMessage(), x);
} }
@@ -288,4 +288,4 @@ public class JaudiotaggerParser extends MetaDataParser {
Tag tag = audioFile.getTag(); Tag tag = audioFile.getTag();
return tag == null ? null : tag.getFirstArtwork(); return tag == null ? null : tag.getFirstArtwork();
} }
} }