Catch Exceptions instead of only Throwables in JAudiotaggerParser

Since JAudioTagger isn't the rock-solidest software
in the world, we should catch as much things as possible
master
jvoisin 5 years ago
parent a13552b6f5
commit c6eed14db5
  1. 6
      airsonic-main/src/main/java/org/airsonic/player/service/metadata/JaudiotaggerParser.java

@ -86,7 +86,7 @@ public class JaudiotaggerParser extends MetaDataParser {
AudioFile audioFile; AudioFile audioFile;
try { try {
audioFile = AudioFileIO.read(file); audioFile = AudioFileIO.read(file);
} catch (Throwable x) { } catch (Exception x) {
LOG.warn("Error when parsing tags in " + file, x); LOG.warn("Error when parsing tags in " + file, x);
return metaData; return metaData;
} }
@ -229,7 +229,7 @@ public class JaudiotaggerParser extends MetaDataParser {
audioFile.commit(); audioFile.commit();
} catch (Throwable x) { } catch (Exception x) {
LOG.warn("Failed to update tags for file " + file, x); LOG.warn("Failed to update tags for file " + file, x);
throw new RuntimeException("Failed to update tags for file " + file + ". " + x.getMessage(), x); throw new RuntimeException("Failed to update tags for file " + file + ". " + x.getMessage(), x);
} }
@ -288,4 +288,4 @@ public class JaudiotaggerParser extends MetaDataParser {
Tag tag = audioFile.getTag(); Tag tag = audioFile.getTag();
return tag == null ? null : tag.getFirstArtwork(); return tag == null ? null : tag.getFirstArtwork();
} }
} }

Loading…
Cancel
Save