Merge pull request #378 from muff1nman/fix-377

Dont mix ws and normal HttpServletRequest retrieval methods
master
Andrew DeMaria 8 years ago committed by GitHub
commit 4806f772f2
  1. 5
      libresonic-main/src/main/java/org/libresonic/player/controller/SonosSettingsController.java
  2. 5
      libresonic-main/src/main/java/org/libresonic/player/service/SonosService.java

@ -19,6 +19,7 @@
package org.libresonic.player.controller; package org.libresonic.player.controller;
import org.apache.commons.lang.StringUtils; import org.apache.commons.lang.StringUtils;
import org.libresonic.player.service.NetworkService;
import org.libresonic.player.service.SettingsService; import org.libresonic.player.service.SettingsService;
import org.libresonic.player.service.SonosService; import org.libresonic.player.service.SonosService;
import org.springframework.beans.factory.annotation.Autowired; import org.springframework.beans.factory.annotation.Autowired;
@ -80,8 +81,8 @@ public class SonosSettingsController {
settingsService.setSonosServiceName(sonosServiceName); settingsService.setSonosServiceName(sonosServiceName);
settingsService.save(); settingsService.save();
sonosService.setMusicServiceEnabled(false); sonosService.setMusicServiceEnabled(false, NetworkService.getBaseUrl(request));
sonosService.setMusicServiceEnabled(sonosEnabled); sonosService.setMusicServiceEnabled(sonosEnabled, NetworkService.getBaseUrl(request));
} }
public void setSettingsService(SettingsService settingsService) { public void setSettingsService(SettingsService settingsService) {

@ -106,7 +106,7 @@ public class SonosService implements SonosSoap {
@Resource @Resource
private WebServiceContext context; private WebServiceContext context;
public void setMusicServiceEnabled(boolean enabled) { public void setMusicServiceEnabled(boolean enabled, String baseUrl) {
List<String> sonosControllers = upnpService.getSonosControllerHosts(); List<String> sonosControllers = upnpService.getSonosControllerHosts();
if (sonosControllers.isEmpty()) { if (sonosControllers.isEmpty()) {
LOG.info("No Sonos controller found"); LOG.info("No Sonos controller found");
@ -116,11 +116,10 @@ public class SonosService implements SonosSoap {
String sonosServiceName = settingsService.getSonosServiceName(); String sonosServiceName = settingsService.getSonosServiceName();
int sonosServiceId = settingsService.getSonosServiceId(); int sonosServiceId = settingsService.getSonosServiceId();
String libresonicBaseUrl = NetworkService.getBaseUrl(getRequest());
for (String sonosController : sonosControllers) { for (String sonosController : sonosControllers) {
try { try {
new SonosServiceRegistration().setEnabled(libresonicBaseUrl, sonosController, enabled, new SonosServiceRegistration().setEnabled(baseUrl, sonosController, enabled,
sonosServiceName, sonosServiceId); sonosServiceName, sonosServiceId);
break; break;
} catch (IOException x) { } catch (IOException x) {

Loading…
Cancel
Save