Second pass of trivial modernizations

- Replace unnecessary getters/setters with inline assignments
- Simplify string constructions
- Improve containers construction

airsonic-main/src/main/java/org/airsonic/player/command/UserSettingsCommand.java

@@ -295,7 +295,7 @@ public class UserSettingsCommand {
         isSettingsRole = user != null && user.isSettingsRole();
         isShareRole = user != null && user.isShareRole();
         isLdapAuthenticated = user != null && user.isLdapAuthenticated();
-        setNewUser(false);
+        isNewUser = false;
     }
 
 }

airsonic-main/src/main/java/org/airsonic/player/domain/TranscodeScheme.java

@@ -85,7 +85,7 @@ public enum TranscodeScheme {
         if (this == OFF) {
             return "No limit";
         }
-        return "" + getMaxBitRate() + " Kbps";
+        return getMaxBitRate() + " Kbps";
     }
 
     /**

airsonic-main/src/main/java/org/airsonic/player/domain/TransferStatus.java

@@ -234,8 +234,8 @@ public class TransferStatus {
         this.active = active;
 
         if (active) {
-            setBytesSkipped(0L);
+            bytesSkipped = 0L;
-            setBytesTotal(0L);
+            bytesTotal = 0L;
             setBytesTransfered(0L);
         } else {
             createSample(getBytesTransfered(), true);
@@ -281,10 +281,9 @@ public class TransferStatus {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
+        String builder = "TransferStatus-" + hashCode() + " [player: " + player.getId() + ", file: " +
-        builder.append("TransferStatus-").append(hashCode()).append(" [player: ").append(player.getId()).append(", file: ");
+                file + ", terminated: " + terminated + ", active: " + active + "]";
-        builder.append(file).append(", terminated: ").append(terminated).append(", active: ").append(active).append("]");
+        return builder;
-        return builder.toString();
     }
 
     /**

airsonic-main/src/main/java/org/airsonic/player/service/LastFmService.java

@@ -183,9 +183,8 @@ public class LastFmService {
      */
     public List<MediaFile> getSimilarSongs(org.airsonic.player.domain.Artist artist, int count,
                                            List<MusicFolder> musicFolders) throws IOException {
-        List<MediaFile> similarSongs = new ArrayList<MediaFile>();
 
-        similarSongs.addAll(mediaFileDao.getSongsByArtist(artist.getName(), 0, 1000));
+        List<MediaFile> similarSongs = new ArrayList<MediaFile>(mediaFileDao.getSongsByArtist(artist.getName(), 0, 1000));
         for (org.airsonic.player.domain.Artist similarArtist : getSimilarArtists(artist, 100, false, musicFolders)) {
             similarSongs.addAll(mediaFileDao.getSongsByArtist(similarArtist.getName(), 0, 1000));
         }

airsonic-main/src/main/java/org/airsonic/player/service/SettingsService.java

@@ -606,7 +606,7 @@ public class SettingsService {
      * @param limit The download bitrate limit in Kbit/s. Zero if unlimited.
      */
     public void setDownloadBitrateLimit(long limit) {
-        setProperty(KEY_DOWNLOAD_BITRATE_LIMIT, "" + limit);
+        setProperty(KEY_DOWNLOAD_BITRATE_LIMIT, String.valueOf(limit));
     }
 
     /**

airsonic-main/src/main/java/org/airsonic/player/service/SonosService.java

@@ -464,7 +464,7 @@ public class SonosService implements SonosSoap {
             if (StringUtils.isNumeric(part)) {
                 result.add(Integer.parseInt(part));
             } else {
-                int dashIndex = part.indexOf("-");
+                int dashIndex = part.indexOf('-');
                 int from = Integer.parseInt(part.substring(0, dashIndex));
                 int to = Integer.parseInt(part.substring(dashIndex + 1));
                 for (int i = from; i <= to; i++) {

airsonic-main/src/main/java/org/airsonic/player/service/sonos/SonosHelper.java

@@ -118,9 +118,7 @@ public class SonosHelper {
         List<MediaFile> albums = searchService.getRandomAlbums(40, musicFolders);
         List<MediaFile> songs = new ArrayList<MediaFile>();
         for (MediaFile album : albums) {
-            for (MediaFile file : filterMusic(mediaFileService.getChildrenOf(album, true, false, false))) {
+            songs.addAll(filterMusic(mediaFileService.getChildrenOf(album, true, false, false)));
-                songs.add(file);
-            }
         }
         Collections.shuffle(songs);
         songs = songs.subList(0, Math.min(count, songs.size()));

airsonic-main/src/test/java/org/airsonic/player/service/PlaylistServiceTestImport.java

@@ -88,9 +88,9 @@ public class PlaylistServiceTestImport {
         FileUtils.touch(mf2);
         File mf3 = folder.newFile();
         FileUtils.touch(mf3);
-        builder.append(mf1.getAbsolutePath() + "\n");
+        builder.append(mf1.getAbsolutePath()).append("\n");
-        builder.append(mf2.getAbsolutePath() + "\n");
+        builder.append(mf2.getAbsolutePath()).append("\n");
-        builder.append(mf3.getAbsolutePath() + "\n");
+        builder.append(mf3.getAbsolutePath()).append("\n");
         doAnswer(new PersistPlayList(23)).when(playlistDao).createPlaylist(any());
         doAnswer(new MediaFileHasEverything()).when(mediaFileService).getMediaFile(any(File.class));
         InputStream inputStream = new ByteArrayInputStream(builder.toString().getBytes("UTF-8"));
@@ -122,9 +122,9 @@ public class PlaylistServiceTestImport {
         FileUtils.touch(mf2);
         File mf3 = folder.newFile();
         FileUtils.touch(mf3);
-        builder.append("File1=" + mf1.getAbsolutePath() + "\n");
+        builder.append("File1=").append(mf1.getAbsolutePath()).append("\n");
-        builder.append("File2=" + mf2.getAbsolutePath() + "\n");
+        builder.append("File2=").append(mf2.getAbsolutePath()).append("\n");
-        builder.append("File3=" + mf3.getAbsolutePath() + "\n");
+        builder.append("File3=").append(mf3.getAbsolutePath()).append("\n");
         doAnswer(new PersistPlayList(23)).when(playlistDao).createPlaylist(any());
         doAnswer(new MediaFileHasEverything()).when(mediaFileService).getMediaFile(any(File.class));
         InputStream inputStream = new ByteArrayInputStream(builder.toString().getBytes("UTF-8"));
@@ -158,9 +158,9 @@ public class PlaylistServiceTestImport {
         FileUtils.touch(mf2);
         File mf3 = folder.newFile();
         FileUtils.touch(mf3);
-        builder.append("<track><location>file://" + mf1.getAbsolutePath() + "</location></track>\n");
+        builder.append("<track><location>file://").append(mf1.getAbsolutePath()).append("</location></track>\n");
-        builder.append("<track><location>file://" + mf2.getAbsolutePath() + "</location></track>\n");
+        builder.append("<track><location>file://").append(mf2.getAbsolutePath()).append("</location></track>\n");
-        builder.append("<track><location>file://" + mf3.getAbsolutePath() + "</location></track>\n");
+        builder.append("<track><location>file://").append(mf3.getAbsolutePath()).append("</location></track>\n");
         builder.append("    </trackList>\n" + "</playlist>\n");
         doAnswer(new PersistPlayList(23)).when(playlistDao).createPlaylist(any());
         doAnswer(new MediaFileHasEverything()).when(mediaFileService).getMediaFile(any(File.class));