diff --git a/src/digest.rs b/src/digest.rs index 3f1b4ae..4e1e0b4 100644 --- a/src/digest.rs +++ b/src/digest.rs @@ -32,7 +32,7 @@ impl QuoteForDigest for String { } /// Join a Vec of Display items using a separator -fn join_vec(vec: &Vec, sep: &str) -> String { +fn join_vec(vec: &[T], sep: &str) -> String { vec.iter() .map(ToString::to_string) .collect::>() @@ -507,8 +507,8 @@ impl AuthorizationHeader { None => { let mut rng = rand::thread_rng(); let nonce_bytes: [u8; 16] = rng.gen(); - let cnonce = hex::encode(nonce_bytes); - cnonce + + hex::encode(nonce_bytes) } } }; @@ -654,7 +654,7 @@ impl AuthorizationHeader { }; if auth.qop.is_some() { - if !auth.cnonce.is_some() { + if auth.cnonce.is_none() { return Err(MissingRequired("cnonce", input.into())); } } else { diff --git a/src/enums.rs b/src/enums.rs index 87eeb57..c6a60a9 100644 --- a/src/enums.rs +++ b/src/enums.rs @@ -30,8 +30,8 @@ impl Algorithm { } /// Calculate a hash of bytes using the selected algorithm - pub fn hash(&self, bytes: &[u8]) -> String { - let mut hash : Box = match self.algo { + pub fn hash(self, bytes: &[u8]) -> String { + let mut hash: Box = match self.algo { AlgorithmType::MD5 => Box::new(Md5::new()), AlgorithmType::SHA2_256 => Box::new(Sha256::new()), AlgorithmType::SHA2_512_256 => Box::new(Sha512Trunc256::new()), @@ -42,7 +42,7 @@ impl Algorithm { } /// Calculate a hash of string's bytes using the selected algorithm - pub fn hash_str(&self, bytes: &str) -> String { + pub fn hash_str(self, bytes: &str) -> String { self.hash(bytes.as_bytes()) } } diff --git a/src/lib.rs b/src/lib.rs index 3f1c870..371453b 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -101,5 +101,5 @@ Digest username="Mufasa", #[test] fn test_cast_error() { - let _m : Box = Error::UnknownAlgorithm("Uhhh".into()).into(); + let _m: Box = Error::UnknownAlgorithm("Uhhh".into()).into(); }