MightyPork/tangara-fw
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't fade for brightness slider changes

Browse Source
This commit is contained in:
jacqueline
2023-08-29 12:18:15 +10:00
parent f2bb2e2528
commit 773f285767
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/drivers/display.cpp
+11 -5
View File
@@ -198,20 +198,26 @@ Display::~Display() {
auto Display::SetDisplayOn(bool enabled) -> void {
display_on_ = enabled;
int new_duty = display_on_ ? brightness_ : 0;
SetDutyCycle(new_duty);
SetDutyCycle(new_duty, true);
}
auto Display::SetBrightness(uint_fast8_t percent) -> void {
brightness_ =
std::pow(static_cast<double>(percent) / 100.0, 2.8) * 1024.0 + 0.5;
if (display_on_) {
SetDutyCycle(brightness_);
SetDutyCycle(brightness_, false);
}
}
auto Display::SetDutyCycle(uint_fast8_t new_duty) -> void {
ledc_set_fade_with_time(LEDC_LOW_SPEED_MODE, LEDC_CHANNEL_0, new_duty, 100);
ledc_fade_start(LEDC_LOW_SPEED_MODE, LEDC_CHANNEL_0, LEDC_FADE_NO_WAIT);
auto Display::SetDutyCycle(uint_fast8_t new_duty, bool fade) -> void {
if (fade) {
ledc_set_fade_with_time(LEDC_LOW_SPEED_MODE, LEDC_CHANNEL_0, new_duty, 100);
ledc_fade_start(LEDC_LOW_SPEED_MODE, LEDC_CHANNEL_0, LEDC_FADE_NO_WAIT);
} else {
ESP_ERROR_CHECK(
ledc_set_duty(LEDC_LOW_SPEED_MODE, LEDC_CHANNEL_0, new_duty));
ESP_ERROR_CHECK(ledc_update_duty(LEDC_LOW_SPEED_MODE, LEDC_CHANNEL_0));
}
}
void Display::SendInitialisationSequence(const uint8_t* data) {
src/drivers/include/display.hpp
+1 -1
View File
@@ -76,7 +76,7 @@ class Display {
const uint8_t* data,
size_t length);
auto SetDutyCycle(uint_fast8_t) -> void;
auto SetDutyCycle(uint_fast8_t, bool) -> void;
};
} // namespace drivers