Evan Harris
f738819625
Enable additional checkstyles for whitespace
...
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
5 years ago
Evan Harris
86a5b8708d
Enable checkstyle OneStatementPerLine
5 years ago
Evan Harris
153ad19b6b
Enable several more checkstyle modules
...
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
5 years ago
jvoisin
7578ee9537
Enable checkstyle's Indentation module
5 years ago
jvoisin
fabed228da
Enable EqualsAvoidNull in checkstyle
5 years ago
Evan Harris
3c5735e03e
Fix null exception when creating a new podcast channel
...
Until the podcast channel has been updated to provide it with a title, there
is no point to doing any further processing since the directory where episodes
are stored is derived from the title.
While this change is unrelated to #176 , it fixes the traceback shown in that
issue.
5 years ago
jvoisin
49c6e89f73
Ignore CVE-2019-14439 too
5 years ago
jvoisin
8260fed1b3
Ignore CVE-2019-14379
5 years ago
jvoisin
0d6ed81b83
Add a check for InnerAssignment in checkstyle.xml
5 years ago
jvoisin
ba9d3ff539
Remove an empty statement
5 years ago
jvoisin
8ba97026a4
Synchronize on activeAudioPlayers when changing them
5 years ago
Andrew DeMaria
e7bd5da6fa
Precompile jsp
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
tesshucom
ff08f6dd02
Fix #1139
5 years ago
Evan Harris
093f7c028d
Fix podcast download issues
...
Some podcast feeds use circular redirects (with query parameters).
Fixes #1013
Avoids HttpClient cookie handling producing "Invalid cookie" errors due to
not handling latest "expires" attribute formats.
5 years ago
jvoisin
d256386cbb
Use titles in some <img> tags
5 years ago
Evan Harris
bf309e9117
Fixup eccb7e08f5
( #1170 )
5 years ago
jvoisin
eccb7e08f5
Fix a NULL-deref in CoverArtController.java
...
ImageIO.read() can return null in certain cases
5 years ago
jvoisin
e9ea61036f
First pass of CSP-compliance for mousetrap
...
Since the preference for the keyboard shortcuts
is set server-side, I had to shove them into a non-javascript
context, and then access them via javascript,
in a separate file.
Since I'm not a javascript expert, I'm more than open
to alternatives if this isn't the right way™ to do it.
5 years ago
Andrew DeMaria
859d08fc02
Bump version
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
8db4ec12e1
Add sha256sums and gpg sign outside of maven process
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
3b8993e860
Replace Hashtable with HashMap, since Hashtable are deprecated
5 years ago
tesshucom
4ce892e39d
Fix for duplication and synchronization.
...
- Moved MusicFolderTestData
from org.airsonic.player.service
to org.airsonic.player.util
5 years ago
Evan Harris
50b3fd382c
Handle null without exception
5 years ago
tesshucom
4a728ed9a6
Add and modify comments
5 years ago
tesshucom
f67c758c4e
Add missing test cases
5 years ago
tesshu.com
76f665b3c4
Update airsonic-main/src/test/java/org/airsonic/player/service/search/SearchServiceSpecialGenreTestCase.java
...
Fix comment
Co-Authored-By: jvoisin <jvoisin@users.noreply.github.com>
5 years ago
tesshu.com
810920556e
Update airsonic-main/src/test/java/org/airsonic/player/service/search/AnalyzerFactoryTestCase.java
...
Fix comment
Co-Authored-By: jvoisin <jvoisin@users.noreply.github.com>
5 years ago
tesshu.com
5bfc232021
Update airsonic-main/src/test/java/org/airsonic/player/service/search/AnalyzerFactoryTestCase.java
...
Fix comment
Co-Authored-By: jvoisin <jvoisin@users.noreply.github.com>
5 years ago
tesshu.com
c74ef2ea30
Update airsonic-main/src/test/java/org/airsonic/player/service/search/AnalyzerFactoryTestCase.java
...
Fix comment
Co-Authored-By: jvoisin <jvoisin@users.noreply.github.com>
5 years ago
tesshu.com
eb5963dfa3
Update airsonic-main/src/test/java/org/airsonic/player/service/search/AnalyzerFactoryTestCase.java
...
Fix comment
Co-Authored-By: jvoisin <jvoisin@users.noreply.github.com>
5 years ago
tesshucom
f2d26348b6
Add tests for SearchService
...
Test cases related to current issues or points that need confirmation
after Lucene update.
5 years ago
François-Xavier Thomas
073b7e35e1
Add simple test cases for internet radios
5 years ago
François-Xavier Thomas
86510a4d42
Use the clear action to stop the internet radio
5 years ago
François-Xavier Thomas
19082afc11
Mark cached internet radio sources as a final variable
5 years ago
François-Xavier Thomas
53b174a8f4
Follow HTTP redirects when loading internet radio playlists
5 years ago
François-Xavier Thomas
9ff5536d9b
Do not try to load radio playlists in the browser when clicking on a radio
5 years ago
François-Xavier Thomas
760a6e957a
Limit the amount of data we parse from remote internet radio playlists
5 years ago
François-Xavier Thomas
afa037611d
Show an error is an internet radio has no sources to load
5 years ago
François-Xavier Thomas
5cb9b6c029
Hide play queue actions while playing internet radios
5 years ago
François-Xavier Thomas
b1185601d5
Tweak logging for internet radio playlists
5 years ago
François-Xavier Thomas
aeabfa1044
Add internet radio source cache
...
This helps us avoid loading and parsing the external playlists each time
we try to load an internet radio.
5 years ago
François-Xavier Thomas
cab3f60a25
Refactor internet radio loading into a service
5 years ago
François-Xavier Thomas
02d373d9ec
Play internet radios in MediaElement ( fix #408 )
...
This allows the user to control playback for the internet radios, which
were previously started outside of the main player without any
possibility for direct control.
5 years ago
François-Xavier Thomas
2e0134259d
Try to show a progress bar in the media player
...
This commit is kind of a hack to force MediaElement.js to show a
progress bar when we are loading a song.
Normally, in vanilla HTML5 MediaElement, we'd explicitely call 'play()'
when loading a song. Here, we cannot ensure playback will work well if
we don't wait for the 'canplay' event to be fired, but the progress bar
won't show up without 'play()'...
This commit emits a fake 'waiting' event to let the MEJS know that it
should update the UI.
5 years ago
François-Xavier Thomas
5a72322772
Work around play queue not going to the next song automatically
...
This commit works around a race caused by some of our JS code trying to
run play() for the next song while the MEJS player is still cleaning up
the last song.
MEJS issue: https://github.com/mediaelement/mediaelement/issues/2650
5 years ago
Evan Harris
59db5073e3
Added webm to default video file types
5 years ago
tesshucom
767b39ed5b
Split SearchService
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
42bced139f
Small refactor on httpservletrequest injection
5 years ago
Evan Harris
983d688cce
Added validation to reject things disallowed on the current user
5 years ago
Evan Harris
a4c62f6860
Disallow deleting your own user or removing admin role
5 years ago