Commit Graph
370 Commits
Author SHA1 Message Date
Evan Harris 6e8ae8971c Enable checkstyle OverloadMethodsDeclarationOrder 2019-08-16 18:08:42 -05:00
Evan Harris 1acfacb4c6 Enable checkstyle FileTabCharacter 2019-08-15 18:40:04 -05:00
Evan Harrisandjvoisin 389db3f1b4 Enable checkstyle for simple boolean expressions 2019-08-11 20:10:06 +00:00
Evan Harrisandjvoisin f738819625 Enable additional checkstyles for whitespace
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
2019-08-11 20:09:40 +00:00
Evan Harrisandjvoisin 86a5b8708d Enable checkstyle OneStatementPerLine 2019-08-08 21:26:01 +00:00
Evan Harrisandjvoisin 153ad19b6b Enable several more checkstyle modules
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
2019-08-07 22:46:10 +00:00
jvoisinandGitHub 7578ee9537 Enable checkstyle's Indentation module 2019-08-07 20:13:29 +00:00
jvoisinandGitHub fabed228da Enable EqualsAvoidNull in checkstyle 2019-08-07 19:12:04 +00:00
Evan Harrisandjvoisin 3c5735e03e Fix null exception when creating a new podcast channel
Until the podcast channel has been updated to provide it with a title, there
is no point to doing any further processing since the directory where episodes
are stored is derived from the title.

While this change is unrelated to #176, it fixes the traceback shown in that
issue.
2019-08-07 09:14:18 +00:00
jvoisin 0d6ed81b83 Add a check for InnerAssignment in checkstyle.xml 2019-08-01 10:36:51 +02:00
jvoisin ba9d3ff539 Remove an empty statement 2019-08-01 10:30:26 +02:00
jvoisinandGitHub 8ba97026a4 Synchronize on activeAudioPlayers when changing them 2019-07-27 16:28:51 +00:00
Andrew DeMariaandjvoisin e7bd5da6fa Precompile jsp
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-07-27 16:25:59 +00:00
tesshucomandAndrew DeMaria ff08f6dd02 Fix #1139 2019-07-25 19:26:01 -06:00
Evan Harris 093f7c028d Fix podcast download issues
Some podcast feeds use circular redirects (with query parameters).
Fixes #1013
Avoids HttpClient cookie handling producing "Invalid cookie" errors due to
not handling latest "expires" attribute formats.
2019-07-24 23:30:40 -05:00
jvoisin d256386cbb Use titles in some <img> tags 2019-07-22 22:49:11 +02:00
Evan Harrisandjvoisin bf309e9117 Fixup eccb7e08f5 (#1170) 2019-07-17 22:48:41 +00:00
jvoisinandAndrew DeMaria eccb7e08f5 Fix a NULL-deref in CoverArtController.java
ImageIO.read() can return null in certain cases
2019-07-14 11:54:30 -06:00
jvoisinandAndrew DeMaria e9ea61036f First pass of CSP-compliance for mousetrap
Since the preference for the keyboard shortcuts
is set server-side, I had to shove them into a non-javascript
context, and then access them via javascript,
in a separate file.

Since I'm not a javascript expert, I'm more than open
to alternatives if this isn't the right way™ to do it.
2019-07-14 11:46:28 -06:00
jvoisinandGitHub 3b8993e860 Replace Hashtable with HashMap, since Hashtable are deprecated 2019-07-13 11:38:01 +00:00
Andrew DeMaria 0dd16c2cd8 Merge remote-tracking branch 'origin/pr/1152' 2019-07-09 13:08:17 -06:00
Andrew DeMaria 05c8bdf73a Merge remote-tracking branch 'origin/pr/897' 2019-07-08 12:25:33 -06:00
Evan Harris 50b3fd382c Handle null without exception 2019-07-08 02:57:41 -05:00
Andrew DeMaria 7b16189415 Merge remote-tracking branch 'origin/pr/1153' 2019-07-03 20:27:36 -06:00
Andrew DeMaria 3d0d0482f5 Merge remote-tracking branch 'origin/pr/985' 2019-07-03 19:22:17 -06:00
François-Xavier Thomas 073b7e35e1 Add simple test cases for internet radios 2019-07-02 23:00:03 +02:00
François-Xavier Thomas 86510a4d42 Use the clear action to stop the internet radio 2019-07-02 23:00:03 +02:00
François-Xavier Thomas 19082afc11 Mark cached internet radio sources as a final variable 2019-07-02 23:00:03 +02:00
François-Xavier Thomas 53b174a8f4 Follow HTTP redirects when loading internet radio playlists 2019-07-02 23:00:03 +02:00
François-Xavier Thomas 9ff5536d9b Do not try to load radio playlists in the browser when clicking on a radio 2019-07-02 23:00:03 +02:00
François-Xavier Thomas 760a6e957a Limit the amount of data we parse from remote internet radio playlists 2019-07-02 23:00:03 +02:00
François-Xavier Thomas afa037611d Show an error is an internet radio has no sources to load 2019-07-02 23:00:03 +02:00
François-Xavier Thomas 5cb9b6c029 Hide play queue actions while playing internet radios 2019-07-02 23:00:01 +02:00
François-Xavier Thomas b1185601d5 Tweak logging for internet radio playlists 2019-07-02 22:25:19 +02:00
François-Xavier Thomas aeabfa1044 Add internet radio source cache
This helps us avoid loading and parsing the external playlists each time
we try to load an internet radio.
2019-07-02 22:25:19 +02:00
François-Xavier Thomas cab3f60a25 Refactor internet radio loading into a service 2019-07-02 22:25:19 +02:00
François-Xavier Thomas 02d373d9ec Play internet radios in MediaElement (fix #408)
This allows the user to control playback for the internet radios, which
were previously started outside of the main player without any
possibility for direct control.
2019-07-02 22:25:19 +02:00
François-Xavier Thomas 2e0134259d Try to show a progress bar in the media player
This commit is kind of a hack to force MediaElement.js to show a
progress bar when we are loading a song.

Normally, in vanilla HTML5 MediaElement, we'd explicitely call 'play()'
when loading a song. Here, we cannot ensure playback will work well if
we don't wait for the 'canplay' event to be fired, but the progress bar
won't show up without 'play()'...

This commit emits a fake 'waiting' event to let the MEJS know that it
should update the UI.
2019-07-02 22:23:01 +02:00
François-Xavier Thomas 5a72322772 Work around play queue not going to the next song automatically
This commit works around a race caused by some of our JS code trying to
run play() for the next song while the MEJS player is still cleaning up
the last song.

MEJS issue: https://github.com/mediaelement/mediaelement/issues/2650
2019-07-02 22:21:30 +02:00
Evan Harris 59db5073e3 Added webm to default video file types 2019-07-02 06:33:03 -05:00
tesshucomandAndrew DeMaria 767b39ed5b Split SearchService
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-07-02 01:02:49 -06:00
Andrew DeMaria 42bced139f Small refactor on httpservletrequest injection 2019-07-02 00:59:38 -06:00
Andrew DeMaria a9b4d481c3 Merge remote-tracking branch 'origin/pr/1129' 2019-07-01 21:14:11 -06:00
Andrew DeMaria 2bfaea2e22 Merge remote-tracking branch 'origin/pr/1090' 2019-07-01 20:45:48 -06:00
Evan Harris 983d688cce Added validation to reject things disallowed on the current user 2019-06-27 00:26:10 -05:00
Evan Harris a4c62f6860 Disallow deleting your own user or removing admin role 2019-06-26 21:17:56 -05:00
Andrew DeMaria f8bd580fb7 Revert "Replace wz_tooltip.js with jquery-ui" and Revert "Fix #1112"
This reverts commit 50467942c8.
This reverts commit 195a0879c3.

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
2019-06-26 17:16:34 -06:00
Andrew DeMaria 50467942c8 Fix #1112 2019-06-26 16:18:16 -06:00
Andrew DeMaria cf5a43d327 Merge remote-tracking branch 'origin/pr/1134' 2019-06-26 12:50:48 -06:00
Evan Harris 79b800656a Cleanup siebling -> sibling mis-spellings 2019-06-24 20:59:04 -05:00