jvoisin
6599e6a689
Minor cleanup of InternalHelpController.java ( #1525 )
...
- Access static methods explicitly
- Remove useless String.format calls
4 years ago
François-Xavier Thomas
73a06879b5
Internal help: Fix crash when no transcoders are installed
4 years ago
François-Xavier Thomas
bd4153962f
Internal help: Add database server version
4 years ago
François-Xavier Thomas
3acd06e91b
Internal help: Fix crash with MariaDB and uppercase table names
4 years ago
François-Xavier Thomas
09fa486bb0
Internal help: Only show db filesystem size for legacy profile
4 years ago
François-Xavier Thomas
6c54f1f7c8
Internal help: Refactor detailed db/index stats
4 years ago
François-Xavier Thomas
9d3ec88796
Internal help: Support table stats for external dbs
4 years ago
François-Xavier Thomas
55f9a41673
Internal help: Warn for potential db corruption issues
4 years ago
François-Xavier Thomas
768968d075
Internal help: Add transcoding info
4 years ago
François-Xavier Thomas
7a27e08106
Add "internal help" page with diagnostic information
4 years ago
jvoisin
d4002ef6ce
Fix two possible nullptr deref
5 years ago
Evan Harris
a6cdba4a44
Added a warning if stream output exceeds predicted size
5 years ago
Evan Harris
6cfbe0ff88
Moved expected content length calculation to TranscodingService
5 years ago
Evan Harris
b28ffb0d1a
Added isRangeAllowed() function for transcoded sources
...
This isn't a perfect solution, but it should help increase confidence
that the transcoder in use is likely to produce an approximately
correct-sized stream.
5 years ago
Evan Harris
e691c80774
Change back to allow transcodes to allow seeking
...
This switches back to allowing range rather than chunked requests so that
seeking works in the web player, but does so by safer means than previous
solutions, by slightly over-estimating the transcoded size, then sending
dummy bytes to the client to fill any gap. Fixes #1117 . Addresses #685 .
5 years ago
Evan Harris
ac45a9b7dc
Added checkstyles for brace placement
5 years ago
Evan Harris
510314a9d8
Added SingleSpaceSeparator checkstyle
5 years ago
Evan Harris
f476fd7c33
Added checkstyle for trailing whitespace
5 years ago
Andrew DeMaria
fa1a700ebd
Translated xml configuration to java configuration
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Shen-Ta Hsieh
84df4e3b94
Add support for ListenBrainz Audio Scrobbler Service
...
- Add textbox in user settings page for ListenBrainz token
- Add changes to db
- Add db colume to store MusicBrainz Recording ID
- Add db colume to store ListenBrainz token
- Add test for reading id
- Add tag on testing file
- Add localization entry
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
ef22d6d8ed
Remove optional jetty runtime
...
- Simplifies pom making future upgrades easier
- Fixes tests picking up jetty runtime
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
437d8ce947
Move index meta information
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
a79b56fe5a
Removed unused variables, imports, empty statements ( #1361 )
...
Also some unnecessary whitespace.
5 years ago
jvoisin
a9a7b08230
Use the try-with-resource construct where possible
5 years ago
jvoisin
e1583691d8
Replace StringUtil.toHtml with StringEscapeUtils.escapeHtml
...
Apache commons is providing Html-escaping, no need to reinvent the wheel:
> It supports all known HTML 4.0 entities, including funky accents. Note that the
> commonly used apostrophe escape character (') is not a legal entity and so
> is not supported).
So I manually checked that nothing is relying on escaped single-quotes,
and didn't manage to find anything that does.
5 years ago
jvoisin
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
5 years ago
Evan Harris
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
5 years ago
jvoisin
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
5 years ago
Evan Harris
91f91ed654
Removed the auto-refresh feature
...
This feature just generated a lot of unnecessary traffic to the server and
hurt usability because the page would refresh unexpectedly while a user was
actively looking at content. Fixes #1003 , #1179 , #729 .
Did not remove the column for that setting in the user database, since that
would lead to complications if needing to downgrade for some reason.
5 years ago
jvoisin
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
5 years ago
jvoisin
c25e26d61a
Remove a dead file
5 years ago
Andrew DeMaria
3fe6e8b267
Add logger name checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
6783ced897
Removed inability to change roles for admin user
5 years ago
jvoisin
e5404648a4
Remove unnecessary exceptions and unused imports
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
1b28d2c2fe
Handle nulls when processing cover art better
...
This expands on commit d4487a07a0fcacea1544d61c79a380f2e9bf3087.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
25327c69cc
Replace deprecated IOUtils.closeQuietly calls
...
Use FileUtil.closeQuietly instead, since it's our reimplemented of this deprecated method.
This change was done automatically via IntelliJ IDEA.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
tesshucom
645fb88c7d
Add expunge to IndexManager
...
When DB expunge is invoked from the management screen,
also indexManager performs expunge.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Jon Borglund
f77a0d8b67
fixed 'Settings Saved' notification when saving transcoding settings #1114 ( #1269 )
...
Signed-off-by: Jon <jon@powha.net>
5 years ago
jvoisin
bc832d0034
Use a constant for encoding
...
Replace string.getBytes("UTF-8") with
string.getBytes(CONSTANT).
5 years ago
jvoisin
c6540d707e
Simplify a bit the annotations
...
There is no need to specify `value` every single time
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
83ca97e21c
Improve error handling for jaudiotaggerParser artwork fetch
5 years ago
jvoisin
6f57c6e313
Remove an unused/unuseable/half-done cache
5 years ago
Shen-Ta Hsieh
16c1e42b97
normalize license expire date to prevent outstanding value on Java 12
...
Date(Long.MAX_VALUE) is 292278994-08-17T07:12:55.807Z on Java 12, and
make Ultrasonic failed to parse.
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
5 years ago
Evan Harris
389db3f1b4
Enable checkstyle for simple boolean expressions
5 years ago
Evan Harris
f738819625
Enable additional checkstyles for whitespace
...
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
5 years ago
Evan Harris
153ad19b6b
Enable several more checkstyle modules
...
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
5 years ago
jvoisin
7578ee9537
Enable checkstyle's Indentation module
5 years ago
jvoisin
0d6ed81b83
Add a check for InnerAssignment in checkstyle.xml
5 years ago
jvoisin
ba9d3ff539
Remove an empty statement
5 years ago
Evan Harris
bf309e9117
Fixup eccb7e08f5
( #1170 )
5 years ago