Evan Harris
a79b56fe5a
Removed unused variables, imports, empty statements ( #1361 )
...
Also some unnecessary whitespace.
5 years ago
jvoisin
a9a7b08230
Use the try-with-resource construct where possible
5 years ago
jvoisin
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
5 years ago
Evan Harris
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
5 years ago
jvoisin
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
5 years ago
jvoisin
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
5 years ago
jvoisin
c25e26d61a
Remove a dead file
5 years ago
Andrew DeMaria
3fe6e8b267
Add logger name checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
6783ced897
Removed inability to change roles for admin user
5 years ago
jvoisin
e5404648a4
Remove unnecessary exceptions and unused imports
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
1b28d2c2fe
Handle nulls when processing cover art better
...
This expands on commit d4487a07a0fcacea1544d61c79a380f2e9bf3087.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
25327c69cc
Replace deprecated IOUtils.closeQuietly calls
...
Use FileUtil.closeQuietly instead, since it's our reimplemented of this deprecated method.
This change was done automatically via IntelliJ IDEA.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
tesshucom
645fb88c7d
Add expunge to IndexManager
...
When DB expunge is invoked from the management screen,
also indexManager performs expunge.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Jon Borglund
f77a0d8b67
fixed 'Settings Saved' notification when saving transcoding settings #1114 ( #1269 )
...
Signed-off-by: Jon <jon@powha.net>
5 years ago
jvoisin
bc832d0034
Use a constant for encoding
...
Replace string.getBytes("UTF-8") with
string.getBytes(CONSTANT).
5 years ago
jvoisin
c6540d707e
Simplify a bit the annotations
...
There is no need to specify `value` every single time
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
83ca97e21c
Improve error handling for jaudiotaggerParser artwork fetch
5 years ago
jvoisin
6f57c6e313
Remove an unused/unuseable/half-done cache
5 years ago
Shen-Ta Hsieh
16c1e42b97
normalize license expire date to prevent outstanding value on Java 12
...
Date(Long.MAX_VALUE) is 292278994-08-17T07:12:55.807Z on Java 12, and
make Ultrasonic failed to parse.
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
5 years ago
Evan Harris
389db3f1b4
Enable checkstyle for simple boolean expressions
5 years ago
Evan Harris
f738819625
Enable additional checkstyles for whitespace
...
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
5 years ago
Evan Harris
153ad19b6b
Enable several more checkstyle modules
...
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
5 years ago
jvoisin
7578ee9537
Enable checkstyle's Indentation module
5 years ago
jvoisin
0d6ed81b83
Add a check for InnerAssignment in checkstyle.xml
5 years ago
jvoisin
ba9d3ff539
Remove an empty statement
5 years ago
Evan Harris
bf309e9117
Fixup eccb7e08f5
( #1170 )
5 years ago
jvoisin
eccb7e08f5
Fix a NULL-deref in CoverArtController.java
...
ImageIO.read() can return null in certain cases
5 years ago
Evan Harris
50b3fd382c
Handle null without exception
5 years ago
François-Xavier Thomas
02d373d9ec
Play internet radios in MediaElement ( fix #408 )
...
This allows the user to control playback for the internet radios, which
were previously started outside of the main player without any
possibility for direct control.
5 years ago
tesshucom
767b39ed5b
Split SearchService
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Andrew DeMaria
42bced139f
Small refactor on httpservletrequest injection
5 years ago
Evan Harris
a4c62f6860
Disallow deleting your own user or removing admin role
5 years ago
Evan Harris
79b800656a
Cleanup siebling -> sibling mis-spellings
5 years ago
jvoisin
1640411573
Fix some invalid/incomplete javadoc comments
5 years ago
jvoisin
4fbc080098
Please the linter
5 years ago
jvoisin
70bc0f6c04
Remove the ghetto REST flash-based video player
5 years ago
jvoisin
1f1a22fca5
Remove the deprecated getAlphabetialAlbums method
5 years ago
jvoisin
643be3930f
Remove superfluous casts
5 years ago
jvoisin
57df709cd8
Replace things like size == 0 with isEmpty
5 years ago
jvoisin
828c1b2674
Use modern Spring mapping annotations
...
Java is verbose enough, no need to make it worse.
5 years ago
jvoisin
e283ac46a8
Fix downloads with embedded covers
...
Previously, this would always fail with
embedded covers.
5 years ago
jvoisin
b697dc5bfc
An other batch of LGTM-found issues
5 years ago
Peter Marheine
3efa2d3e2c
Remove the option to never set Content-Length
...
This workaround is obsolete with correct handling of ranges when
requested.
5 years ago
Peter Marheine
9be2a8892f
More correctly handle stream ranges
...
When transcoding, always use chunked transfers and report that ranges
are not supported. When not transcoding, support returning ranges but
only if requested.
5 years ago
Peter Marheine
3e97186043
Omit unnecessary null check on ranges
5 years ago
Peter Marheine
47eefc1369
Refactor output streaming for readability
...
The core loop was put together confusingly; this encapsulates the
process of constructing an OutputStream and reformats some.
5 years ago
Peter Marheine
cae8f8b4e5
Reformat stream controller some
...
Mostly just whitespace changes, shortening lines for readability. Adds a
few comments that outline what's supposed to happen.
5 years ago
Peter Marheine
d42af4575f
Add some @Nullable annotations
...
Making it easier to tell where API contracts allow nulls, where it's
otherwise unclear without reading the implementation.
5 years ago
jvoisin
ab03526620
Fix two NULL-deref
5 years ago
jvoisin
348c698e35
Remove the /db page
...
This page wasn't linked anywhere, and was
allowing an administrator to issue arbitrary sql
comments, and was vulnerable to reflected XSS.
We should get rid of it. If you really want to issue
SQL commands, just ssh to your instance and do it from here.
5 years ago