e1a8a3b752
Use a switch-case instead of if-spaghettis
5 years ago
6b54086590
Remove an unused method
5 years ago
332718386b
Simplify the parseInts method
5 years ago
29b083ddac
Simplify the split method
...
Use a regexp with two groups, instead of
doing some black magic manually.
5 years ago
e1583691d8
Replace StringUtil.toHtml with StringEscapeUtils.escapeHtml
...
Apache commons is providing Html-escaping, no need to reinvent the wheel:
> It supports all known HTML 4.0 entities, including funky accents. Note that the
> commonly used apostrophe escape character (') is not a legal entity and so
> is not supported).
So I manually checked that nothing is relying on escaped single-quotes,
and didn't manage to find anything that does.
5 years ago
9dc9cbd821
Remove the unused toISO8601 method
5 years ago
a0cc372abc
Add OpenJDK 13 and OpenJDK-dev to travis
5 years ago
9f6b02c5d0
Refactor a bit how we're handling avatars
...
- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions
5 years ago
b37cbf6617
Merge pull request #1359 from randomnicode/minorfixtostatictimeunit
...
Minor fix to static time unit call
5 years ago
320e2a7b77
Merge pull request #1352 from fxthomas/1333-allow-previous-migration-checksums-for-mariadb
...
Allow previous Liquibase migration checksums for MariaDB
5 years ago
78a99d5860
Allow previous Liquibase migration checksums for MariaDB
...
If someone was using MariaDB before #1188 , they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).
This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188 .
5 years ago
acb4e033aa
Minor fix to static time unit call
5 years ago
a793deab0b
Got rid of duplicated code to format durations
...
Added new functions and test cases.
5 years ago
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
5 years ago
0c0561d104
Bump apache's cxf
5 years ago
599eb8574d
Bump OWASP's maven dependency's check
5 years ago
f910c572c9
Use a static access in a test file, because we can.
5 years ago
a4cc1ec6ec
Bump jackson to a proper release
5 years ago
29c1b5dbca
Enabled PMD checking for jsp files
...
2 rulesets are included.
5 years ago
42537686fc
Added page encoding meta tags to jsp files to satisfy PMD
5 years ago
4098d801fc
Fixed a bunch of quoting issues in jsp files
...
All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too.
5 years ago
cd0dc8673d
Move DOCTYPE line to top of all jsp files
...
Not doing this causes violations when using PMD.
5 years ago
2438044c5d
Merge pull request #1265 from benferreri/master
...
Add discogs search link to main album page
5 years ago
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
5 years ago
460589f590
Added an SVG icon for shuffle in dark theme
5 years ago
18e2fe6449
Changed link text from "more" to "refresh" (more correct)
...
Also added refresh SVG icons to match the text.
5 years ago
91f91ed654
Removed the auto-refresh feature
...
This feature just generated a lot of unnecessary traffic to the server and
hurt usability because the page would refresh unexpectedly while a user was
actively looking at content. Fixes #1003 , #1179 , #729 .
Did not remove the column for that setting in the user database, since that
would lead to complications if needing to downgrade for some reason.
5 years ago
d17c00115a
Minor refactor of CsrfSecurityRequestMatcher
...
- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
d61a00e830
Merge remote-tracking branch 'origin/pr/1315'
5 years ago
75705e8f2d
Merge remote-tracking branch 'origin/pr/1324'
5 years ago
75a280457e
Merge remote-tracking branch 'origin/pr/1327'
5 years ago
0d0683d066
Merge remote-tracking branch 'origin/pr/1335'
5 years ago
ceb6b3e598
Merge remote-tracking branch 'origin/pr/1332'
5 years ago
378850a9b1
Merge remote-tracking branch 'origin/pr/1330'
5 years ago
c728d267c7
Fixed inconsistencies in SVG icon colors
5 years ago
af28e7c257
Fix the syntax for sunfire's exclusion
5 years ago
4fb9820a08
Added test case sources to checkstyle
...
Fixes #1328 .
5 years ago
0a94058a62
Fix broken update link
5 years ago
666bc66ec8
Merge remote-tracking branch 'origin/pr/1313'
5 years ago
7d0328cf8d
Update changelog with 10.4.1 release
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
82fa09d198
Bump jwt
5 years ago
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
5 years ago
c25e26d61a
Remove a dead file
5 years ago
06e36ff154
Mark a field as private
...
Since we're synchronising on playQueue, we should make
it final.
5 years ago
06f81f8b97
Added separate user icon from logout icon
...
Fixes #1305 and improves navigation.
5 years ago
89ea120a2f
Merge remote-tracking branch 'origin/pr/1310'
5 years ago
357758ba4e
Merge remote-tracking branch 'origin/pr/1312'
5 years ago
7058b5098d
Merge remote-tracking branch 'origin/pr/1302'
5 years ago
6b2c7e338d
Remove white underline from player controls
5 years ago
09808b170e
Update dark icons for the 'groove' theme
5 years ago
jvoisin
jvoisin
François-Xavier Thomas
Randomnicode
Evan Harris
Andrew DeMaria
Phil Hudson