554 Commits (3f38c527540d10de012910857d6635438c0596fe)

Author	SHA1	Message	Date
jvoisin	8f4e351718	Add an `alt` attribute to images, to increase accessibility	6 years ago
jvoisin	fc43364908	Fix a useless double-assignation	6 years ago
jvoisin	4fbc080098	Please the linter	6 years ago
jvoisin	70bc0f6c04	Remove the ghetto REST flash-based video player	6 years ago
jvoisin	1f1a22fca5	Remove the deprecated getAlphabetialAlbums method	6 years ago
jvoisin	643be3930f	Remove superfluous casts	6 years ago
jvoisin	3202a1086d	Minor simplification ... `.sorted(Comparator.reverseOrder()).findFirst()` can be replaced with `max(Comparator.naturalOrder()`	6 years ago
jvoisin	def5f854fb	Inline some variables ... There is no point in `Type a = …; return a;`	6 years ago
jvoisin	57df709cd8	Replace things like size == 0 with isEmpty	6 years ago
jvoisin	e0ac46cf44	Fix 3 minor errors in jsp files ... - Add a missing `$` in dlnaSettings - Add a missing taglib import in homePage.jsp - Add a missing `=` in playQueue.jsp's css	6 years ago
jvoisin	977b656bc6	Remove superfluous escape in two regexp	6 years ago
jvoisin	40f7c73390	Fix the video player that was broken in cf1f86f	6 years ago
jvoisin	828c1b2674	Use modern Spring mapping annotations ... Java is verbose enough, no need to make it worse.	6 years ago
jvoisin	3492fc0c05	Fix a crash when transcoding a track without album	6 years ago
jvoisin	b1eb0536b8	Fix a crash when transcoding a track without artist	6 years ago
jvoisin	e283ac46a8	Fix downloads with embedded covers ... Previously, this would always fail with embedded covers.	6 years ago
jvoisin	b697dc5bfc	An other batch of LGTM-found issues	6 years ago
Schuyler Eldridge	89a4517f64	Show cover art not displaying on chromecast ... Signed-off-by: Schuyler Eldridge <schuyler.eldridge@gmail.com>	6 years ago
jvoisin	24632317b2	Declare the usage of HTML5 in the doctype ... This should marginally increase the performances and jquery (no more quirks mode), as well as making web browsers happier.	6 years ago
jvoisin	fe73034f10	Strip the <p>…</p> markup in translation ... This was done via `find airsonic-main/src/main/resources/ -name 'ResourceBundle_*.properties' -print0 | xargs -0 sed -i 's/\(helppopup\..*\.text\)\s*=\s*<p>\(.*\)<\/p>/\1=\2/'`, courtesy of fxthomas.	6 years ago
jvoisin	01dd070efa	Fix indentation	6 years ago
jvoisin	195a0879c3	Replace wz_tooltip.js with jquery-ui ... Since we're already using jquery-ui for other stuff, it makes sense to use it for tooltips too, instead of using an old-school-written-in-2009 1300 lines steaming pile of javascript named wz_tooltip.js	6 years ago
jvoisin	f4fa75f808	Fix compat with the latest jquery ... Stolen^w borrowed from https://github.com/keegnotrub/jquery.fancyzoom/issues/3#issue-388966769	6 years ago
jvoisin	c5eb7aa37c	Fix a typo	6 years ago
jvoisin	9a43b4f360	Group the .attr calls	6 years ago
jvoisin	15a1e5e7d6	Replace FancyZoom with jquery.fancyzoom ... FancyZoom isn't a free-as-in-freedom software, and is mostly a big pile of old-school javascript. This commit replace it with a small jquery-powered script under MIT license.	6 years ago
jo	131b7ada1d	Update translation and fix char encoding	6 years ago
tesshucom	1c4a70af99	Fixed null check with StringUtils/ObjectUtils.	6 years ago
Peter Marheine	3efa2d3e2c	Remove the option to never set Content-Length ... This workaround is obsolete with correct handling of ranges when requested.	6 years ago
Peter Marheine	9be2a8892f	More correctly handle stream ranges ... When transcoding, always use chunked transfers and report that ranges are not supported. When not transcoding, support returning ranges but only if requested.	6 years ago
Peter Marheine	3e97186043	Omit unnecessary null check on ranges	6 years ago
Peter Marheine	47eefc1369	Refactor output streaming for readability ... The core loop was put together confusingly; this encapsulates the process of constructing an OutputStream and reformats some.	6 years ago
Peter Marheine	cae8f8b4e5	Reformat stream controller some ... Mostly just whitespace changes, shortening lines for readability. Adds a few comments that outline what's supposed to happen.	6 years ago
Peter Marheine	d42af4575f	Add some @Nullable annotations ... Making it easier to tell where API contracts allow nulls, where it's otherwise unclear without reading the implementation.	6 years ago
Peter Marheine	5077e0d5e1	Short circuit RangeOutputStream for open ranges ... There's no reason to wrap a stream in an output that will do nothing, as when the requested range is 0-; eg the entire stream.	6 years ago
Andrew DeMaria	2643545b39	Rename utilsjs	6 years ago
jvoisin	1090348b0e	Use the version number in jquery-ui's css path	6 years ago
jvoisin	ce7671bf5e	Add the required keyword to some forms ... This should improve a bit the accessibility.	6 years ago
jvoisin	6d294a770b	Replace the usage of prototypejs with jquery in changeCoverArt.jsp ... This change was successfully tested on Chromium and Firefox.	6 years ago
jvoisin	bf5f8cb713	Factorize scripts-2.0.js into utils.js ... No need to include two different and super-small javascript "utils" files.	6 years ago
jvoisin	f3b2c2ea7a	Add a missing taglib to homePager.jsp ... The missing taglib is confusing coverity a bit, and I think that it's a good practise to add it anyway.	6 years ago
jvoisin	3cfe2b31a1	Move some cast-related inline js to an external file ... There is no point in having such a massive blob of javascript inline in the page.	6 years ago
jvoisin	ab03526620	Fix two NULL-deref	6 years ago
François-Xavier Thomas	f57ad3f27b	Fix typo in anonymous user name (#663)	6 years ago
François-Xavier Thomas	8a90d9f77b	Add system properties for persisting the 'remember me' key ... This adds the 'airsonic.rememberMeKey' system property (can be set from command-line with `-Dairsonic.rememberMeKey=<value>`) as well as a 'RememberMeKey' setting in airsonic.properties, so that the key used for generating 'remember me' tokens can be persisted across server restarts. It also adds a default, insecure key in case we are running in development mode with the 'airsonic.development' property set.	6 years ago
jvoisin	3ee6fefe11	Bump jQuery/jquery-ui to the latest versions ... I bumped it first to 2.X with jQuery migrate, played around but didn't manage to trigger any warning. So I bumped it again to the latest available version, jQuery 3.4.0, which isn't triggering useful warnings either.	6 years ago
jvoisin	b663a2fb90	Fix a stored XSS	6 years ago
jvoisin	348c698e35	Remove the /db page ... This page wasn't linked anywhere, and was allowing an administrator to issue arbitrary sql comments, and was vulnerable to reflected XSS. We should get rid of it. If you really want to issue SQL commands, just ssh to your instance and do it from here.	6 years ago
jvoisin	d3970a5c62	Fix various minor issues found by LGTM ... - Unnecessary boxing - Integer overflow - Path traversal via zip - Dangerous synchronization pattern	6 years ago
Andrew DeMaria	2162250101	Revert "Minor frameset-related factorization" ... This reverts commit e69287cfe6. Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>	6 years ago