fd1b154a3c 
								
							
								 
							
						 
						
							
							
								
								Simplify a bit a function  
							
							... 
							
							
 
							
							Credit goes to eharris@ 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								1bc5729cfb 
								
							
								 
							
						 
						
							
							
								
								Remove the parseLocale function in SettingsService  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								d2ad85447b 
								
							
								 
							
						 
						
							
							
								
								Remove the unused md5Hex method  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								d07d0ad687 
								
							
								 
							
						 
						
							
							
								
								Tighten en exception  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								e1a8a3b752 
								
							
								 
							
						 
						
							
							
								
								Use a switch-case instead of if-spaghettis  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								6b54086590 
								
							
								 
							
						 
						
							
							
								
								Remove an unused method  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								332718386b 
								
							
								 
							
						 
						
							
							
								
								Simplify the parseInts method  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								29b083ddac 
								
							
								 
							
						 
						
							
							
								
								Simplify the split method  
							
							... 
							
							
 
							
							Use a regexp with two groups, instead of
doing some black magic manually. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								e1583691d8 
								
							
								 
							
						 
						
							
							
								
								Replace StringUtil.toHtml with StringEscapeUtils.escapeHtml  
							
							... 
							
							
 
							
							Apache commons is providing Html-escaping, no need to reinvent the wheel:
> It supports all known HTML 4.0 entities, including funky accents. Note that the
> commonly used apostrophe escape character (') is not a legal entity and so
> is not supported).
So I manually checked that nothing is relying on escaped single-quotes,
and didn't manage to find anything that does. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								9dc9cbd821 
								
							
								 
							
						 
						
							
							
								
								Remove the unused toISO8601 method  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								9f6b02c5d0 
								
									
								
							
								 
							
						 
						
							
							
								
								Refactor a bit how we're handling avatars  
							
							... 
							
							
 
							
							- Remove an unnecessary cast
- Fix two stored XSS, since the name of the avatar is user-controlled
- Tighten the type of some exceptions 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								78a99d5860 
								
							
								 
							
						 
						
							
							
								
								Allow previous Liquibase migration checksums for MariaDB  
							
							... 
							
							
 
							
							If someone was using MariaDB before #1188 , they were probably doing so
by using the MySQL JDBC driver to pass the migration (which had the
proper workarounds in place for some column types).
This commit assumes that the migrations done that way were valid and
produced the same result as running the MariaDB migrations after #1188 . 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								acb4e033aa 
								
							
								 
							
						 
						
							
							
								
								Minor fix to static time unit call  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								a793deab0b 
								
									
								
							
								 
							
						 
						
							
							
								
								Got rid of duplicated code to format durations  
							
							... 
							
							
 
							
							Added new functions and test cases. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								0660c4f3e6 
								
									
								
							
								 
							
						 
						
							
							
								
								Renamed StringUtil.formatDuration to formatDurationMSS  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								f910c572c9 
								
							
								 
							
						 
						
							
							
								
								Use a static access in a test file, because we can.  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								42537686fc 
								
									
								
							
								 
							
						 
						
							
							
								
								Added page encoding meta tags to jsp files to satisfy PMD  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								4098d801fc 
								
									
								
							
								 
							
						 
						
							
							
								
								Fixed a bunch of quoting issues in jsp files  
							
							... 
							
							
 
							
							All the quoting issues were causing PMD violations.
A few other things that were noticed along the way were fixed too. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								cd0dc8673d 
								
									
								
							
								 
							
						 
						
							
							
								
								Move DOCTYPE line to top of all jsp files  
							
							... 
							
							
 
							
							Not doing this causes violations when using PMD. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								d3a9a3226f 
								
									
								
							
								 
							
						 
						
							
							
								
								Replace deprecated Date by Calendar  
							
							... 
							
							
 
							
							Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html  
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								460589f590 
								
									
								
							
								 
							
						 
						
							
							
								
								Added an SVG icon for shuffle in dark theme  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								18e2fe6449 
								
									
								
							
								 
							
						 
						
							
							
								
								Changed link text from "more" to "refresh" (more correct)  
							
							... 
							
							
 
							
							Also added refresh SVG icons to match the text. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								91f91ed654 
								
									
								
							
								 
							
						 
						
							
							
								
								Removed the auto-refresh feature  
							
							... 
							
							
 
							
							This feature just generated a lot of unnecessary traffic to the server and
hurt usability because the page would refresh unexpectedly while a user was
actively looking at content.  Fixes  #1003 , #1179 , #729 .
Did not remove the column for that setting in the user database, since that
would lead to complications if needing to downgrade for some reason. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								d17c00115a 
								
									
								
							
								 
							
						 
						
							
							
								
								Minor refactor of CsrfSecurityRequestMatcher  
							
							... 
							
							
 
							
							- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								c728d267c7 
								
									
								
							
								 
							
						 
						
							
							
								
								Fixed inconsistencies in SVG icon colors  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								4fb9820a08 
								
									
								
							
								 
							
						 
						
							
							
								
								Added test case sources to checkstyle  
							
							... 
							
							
 
							
							Fixes  #1328 . 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								0a94058a62 
								
							
								 
							
						 
						
							
							
								
								Fix broken update link  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								78480ab766 
								
							
								 
							
						 
						
							
							
								
								Remove a homemade implementation of Pair  
							
							... 
							
							
 
							
							Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								c25e26d61a 
								
							
								 
							
						 
						
							
							
								
								Remove a dead file  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								06e36ff154 
								
							
								 
							
						 
						
							
							
								
								Mark a field as private  
							
							... 
							
							
 
							
							Since we're synchronising on playQueue, we should make
it final. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								06f81f8b97 
								
									
								
							
								 
							
						 
						
							
							
								
								Added separate user icon from logout icon  
							
							... 
							
							
 
							
							Fixes  #1305  and improves navigation. 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								6b2c7e338d 
								
							
								 
							
						 
						
							
							
								
								Remove white underline from player controls  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								09808b170e 
								
							
								 
							
						 
						
							
							
								
								Update dark icons for the 'groove' theme  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								8b72964086 
								
							
								 
							
						 
						
							
							
								
								Display file id and path in debug scanning logs  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								b6414ebb6c 
								
							
								 
							
						 
						
							
							
								
								Simplify a condition  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								9f027f333e 
								
							
								 
							
						 
						
							
							
								
								Upgrade PlaylistService to non-deprecated methods  
							
							... 
							
							
 
							
							As documented here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/Assert.html#notNull-java.lang.Object-java.lang.String-  
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								3fe6e8b267 
								
									
								
							
								 
							
						 
						
							
							
								
								Add logger name checkstyle  
							
							... 
							
							
 
							
							Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								317b3a44b5 
								
							
								 
							
						 
						
							
							
								
								Fixed broken brace and quote splitting in help text  
							
							... 
							
							
 
							
							Hopefully fixes  #1298 . 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								f644f5a1d0 
								
									
								
							
								 
							
						 
						
							
							
								
								Improved handling of missing/failed transcoder  
							
							... 
							
							
 
							
							Fixes  #659 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								6783ced897 
								
									
								
							
								 
							
						 
						
							
							
								
								Removed inability to change roles for admin user  
							
							
 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								6f590f7740 
								
									
								
							
								 
							
						 
						
							
							
								
								Check the return value of `delete` calls  
							
							... 
							
							
 
							
							Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								4b3890f6ec 
								
									
								
							
								 
							
						 
						
							
							
								
								Replace custom circular buffer with Apache commons(CircularFifoQueue)  
							
							... 
							
							
 
							
							Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								42b4aaafc7 
								
									
								
							
								 
							
						 
						
							
							
								
								Use EnumMap in IndexManager  
							
							... 
							
							
 
							
							EnumMap are _much_ more efficient than HashMaps,
so we should use them if we can.
See here for more details: https://docs.oracle.com/javase/8/docs/api/java/util/EnumMap.html 
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								85f85fd88c 
								
									
								
							
								 
							
						 
						
							
							
								
								Make test results quieter  
							
							... 
							
							
 
							
							Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								1a7bb68dc6 
								
							
								 
							
						 
						
							
							
								
								Remove a leftover of the Radexo removal  
							
							... 
							
							
 
							
							This is a followup of 85e0e08d9a 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								da34bf0d3f 
								
							
								 
							
						 
						
							
							
								
								Improve Windows system detection  
							
							... 
							
							
 
							
							Use apache commons instead of terrifyingly fragile black magic. 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								85e0e08d9a 
								
									
								
							
								 
							
						 
						
							
							
								
								Remove radeox  
							
							... 
							
							
 
							
							Radeox is a rendering engine for an unspecified markup.
Its [website](http://radeox.org/ ) is dead, the website
of its [authors](http://www.codehaus.org/ ) is dead too,
its [last commit](https://github.com/codehaus/radeox ) was 13 years ago.
It's only used for the welcome and login messages,
as well as comments from users. If we want to have some markup parsing,
we should use something maintained with autoescaping guarantees,
instead of a piece of zombie code prone to $DEITY knows what injections.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								e5404648a4 
								
									
								
							
								 
							
						 
						
							
							
								
								Remove unnecessary exceptions and unused imports  
							
							... 
							
							
 
							
							Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								90e6c77563 
								
									
								
							
								 
							
						 
						
							
							
								
								Fix incorrect absolute paths in css  
							
							... 
							
							
 
							
							Fixes  #1256 
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
						
							6 years ago  
				
					
						
							
							
								 
						
							
							
								776bb2cfef 
								
									
								
							
								 
							
						 
						
							
							
								
								Switch to newer modelAttribute  
							
							... 
							
							
 
							
							Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com> 
							
						 
						
							6 years ago