MightyPork/airsonic-custom
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,010 Commits 2 Branches 0 Tags
195a0879c3e86e7e10adcfcb35b57a5a7070ba96
Commit Graph
276 Commits
Author SHA1 Message Date
jvoisin 195a0879c3 Replace wz_tooltip.js with jquery-ui 
Since we're already using jquery-ui for other stuff, it makes sense to use it
for tooltips too, instead of using an old-school-written-in-2009 1300 lines
  steaming pile of javascript named wz_tooltip.js
 2019-05-29 23:39:25 +02:00
Andrew DeMaria ce2a56e6f1 Merge remote-tracking branch 'origin/pr/1033' 2019-05-23 10:45:07 -06:00
Peter Marheine 3efa2d3e2c Remove the option to never set Content-Length 
This workaround is obsolete with correct handling of ranges when
requested.
 2019-05-23 10:54:06 +10:00
Peter Marheine 9be2a8892f More correctly handle stream ranges 
When transcoding, always use chunked transfers and report that ranges
are not supported. When not transcoding, support returning ranges but
only if requested.
 2019-05-23 10:51:37 +10:00
Peter Marheine 3e97186043 Omit unnecessary null check on ranges 2019-05-23 10:50:20 +10:00
Peter Marheine 47eefc1369 Refactor output streaming for readability 
The core loop was put together confusingly; this encapsulates the
process of constructing an OutputStream and reformats some.
 2019-05-23 10:48:09 +10:00
Peter Marheine cae8f8b4e5 Reformat stream controller some 
Mostly just whitespace changes, shortening lines for readability. Adds a
few comments that outline what's supposed to happen.
 2019-05-23 10:43:51 +10:00
Peter Marheine d42af4575f Add some @Nullable annotations 
Making it easier to tell where API contracts allow nulls, where it's
otherwise unclear without reading the implementation.
 2019-05-23 10:37:35 +10:00
Peter Marheine 5077e0d5e1 Short circuit RangeOutputStream for open ranges 
There's no reason to wrap a stream in an output that will do nothing, as
when the requested range is 0-; eg the entire stream.
 2019-05-23 10:34:57 +10:00
Andrew DeMaria 2643545b39 Rename utilsjs 2019-05-21 11:00:27 -06:00
Andrew DeMaria 493a53b418 Merge remote-tracking branch 'origin/pr/930' 2019-05-20 15:30:15 -06:00
Andrew DeMaria bec5cec4a2 Merge remote-tracking branch 'origin/pr/930' 2019-05-20 15:05:18 -06:00
jvoisin 1090348b0e Use the version number in jquery-ui's css path 2019-05-20 22:57:21 +02:00
Andrew DeMaria 0a1164966d Merge remote-tracking branch 'origin/pr/1032' 2019-05-20 14:52:32 -06:00
Andrew DeMaria cdd307d86f Merge remote-tracking branch 'origin/pr/1042' 2019-05-20 14:50:56 -06:00
Andrew DeMaria 1e89890223 Merge remote-tracking branch 'origin/pr/1038' 2019-05-20 14:17:33 -06:00
jvoisinandJonas L 33bf68aaa5 Add a password settings testcase (#1058) 
* Add a simple testcase

This commit was done to understand how JUnit
and its friends are working. Expect more useful tests
in the future ;)

* Factorise a bit the tests
 2019-05-20 20:26:00 +02:00
jvoisinandGitHub ce7671bf5e Add the required keyword to some forms 
This should improve a bit the accessibility.
 2019-05-17 20:29:16 +00:00
jvoisinandGitHub 6d294a770b Replace the usage of prototypejs with jquery in changeCoverArt.jsp 
This change was successfully tested on Chromium and Firefox.
 2019-05-17 20:23:40 +00:00
jvoisinandGitHub bf5f8cb713 Factorize scripts-2.0.js into utils.js 
No need to include two different and super-small javascript "utils" files.
 2019-05-17 20:13:12 +00:00
jvoisinandGitHub f3b2c2ea7a Add a missing taglib to homePager.jsp 
The missing taglib is confusing coverity a bit,
and I think that it's a good practise to add it
anyway.
 2019-05-17 17:13:01 +00:00
jvoisinandGitHub 3cfe2b31a1 Move some cast-related inline js to an external file 
There is no point in having such a massive
blob of javascript inline in the page.
 2019-05-17 17:09:45 +00:00
jvoisinandGitHub ab03526620 Fix two NULL-deref 2019-05-01 08:52:09 +00:00
François-Xavier Thomas f57ad3f27b Fix typo in anonymous user name (#663) 2019-04-29 23:30:02 +02:00
Andrew DeMaria ac0a722a10 Merge remote-tracking branch 'airsonic/pr/990' 2019-04-28 22:59:23 -04:00
Andrew DeMaria b51cdc1c5c Merge remote-tracking branch 'airsonic/pr/1028' 2019-04-28 22:58:29 -04:00
François-Xavier Thomas 8a90d9f77b Add system properties for persisting the 'remember me' key 
This adds the 'airsonic.rememberMeKey' system property (can be set from
command-line with `-Dairsonic.rememberMeKey=<value>`) as well as a
'RememberMeKey' setting in airsonic.properties, so that the key used for
generating 'remember me' tokens can be persisted across server restarts.

It also adds a default, insecure key in case we are running in
development mode with the 'airsonic.development' property set.
 2019-04-28 16:51:46 +02:00
jvoisin 3ee6fefe11 Bump jQuery/jquery-ui to the latest versions 
I bumped it first to 2.X with jQuery migrate, played around but didn't manage
to trigger any warning.  So I bumped it again to the latest available version,
jQuery 3.4.0, which isn't triggering useful warnings either.
 2019-04-28 16:26:36 +02:00
jvoisinandGitHub b663a2fb90 Fix a stored XSS 2019-04-28 08:49:25 +00:00
jvoisinandGitHub 348c698e35 Remove the /db page 
This page wasn't linked anywhere, and was
allowing an administrator to issue arbitrary sql
comments, and was vulnerable to reflected XSS.

We should get rid of it. If you really want to issue
SQL commands, just ssh to your instance and do it from here.
 2019-04-28 08:48:41 +00:00
jvoisinandGitHub d3970a5c62 Fix various minor issues found by LGTM 
- Unnecessary boxing
- Integer overflow
- Path traversal via zip
- Dangerous synchronization pattern
 2019-04-28 08:37:47 +00:00
Andrew DeMaria a911ebab80 Merge remote-tracking branch 'origin/pr/1027' 2019-04-27 20:27:37 -06:00
Andrew DeMaria df352d8cb0 Fix #611 Add support for Java 9 and greater 
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-04-27 14:04:48 -06:00
Andrew DeMaria 2162250101 Revert "Minor frameset-related factorization" 
This reverts commit e69287cfe6.

Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-04-27 14:00:52 -06:00
jvoisin 3d54ef1afb Mark the player cookie httpOnly 
It doesn't improve much security-wise,
but it's a good practise anyway.
 2019-04-27 20:37:41 +02:00
jvoisin 8f608485cb Fix a typo 2019-04-27 20:37:35 +02:00
jvoisin 8123716d52 Remove unused loggers 2019-04-27 20:37:35 +02:00
Andrew DeMaria a3e59e9724 Fix file encoding 
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-04-27 10:56:09 -06:00
Andrew DeMaria e5c36d9854 Fix variable name 
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
 2019-04-27 10:55:54 -06:00
Andrew DeMaria d8a5d1afad Merge remote-tracking branch 'origin/pr/1034' 2019-04-27 10:45:48 -06:00
François-Xavier Thomas 820a4faec2 Avoid logging sensitive URL parameters in the Subsonic API 
In case of exceptions, Airsonic logs the full URL that triggered it
since 417583cc, including possibly sensitive query parameters such as
the authentication password/tokens passed to the Subsonic API.

This replaces the value set for this parameter in the URL by the
"<hidden>" string.
 2019-04-26 22:18:23 +02:00
jvoisin 41408bc2c3 Replace the double-mustache anti-pattern 
Because Double Brace Initialization (DBI) creates an anonymous class with a
reference to the instance of the owning object, its use can lead to memory
leaks if the anonymous inner class is returned and held by other objects. Even
when there's no leak, DBI is so obscure that it's bound to confuse most
maintainers.
 2019-04-25 22:32:45 +02:00
jvoisin c6825cf0d7 Minor refactorization of two methods in AbstractDao 2019-04-24 22:40:38 +02:00
François-Xavier Thomas d9f164499f Fix cancel button colors in 'Groove' dark theme 2019-04-22 15:15:36 +02:00
Andrew DeMaria 1463f75b06 Merge remote-tracking branch 'origin/pr/961' 2019-04-19 09:51:41 -06:00
Andrew DeMaria cddc2b2fa7 Merge remote-tracking branch 'origin/pr/983' 2019-04-19 09:48:05 -06:00
Andrew DeMaria 2030caa219 Merge remote-tracking branch 'origin/pr/994' 2019-04-19 09:46:40 -06:00
Andrew DeMaria 1bd70263bd Merge remote-tracking branch 'origin/pr/989' 2019-04-19 09:41:06 -06:00
Andrew DeMaria 24f5c2d8f5 Merge remote-tracking branch 'origin/pr/1005' 2019-04-19 09:40:48 -06:00
Andrew DeMaria 3f9c525933 Merge remote-tracking branch 'origin/pr/1007' 2019-04-19 09:39:48 -06:00