d4aff1dca5
Added checkstyle to prohibit windows line endings
...
Suggestion taken from jvoisin in #1121 .
5 years ago
5c3c558923
Update Lucene from 3.0.3 to the current version 8.2.0
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
6e8ae8971c
Enable checkstyle OverloadMethodsDeclarationOrder
5 years ago
f738819625
Enable additional checkstyles for whitespace
...
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
5 years ago
153ad19b6b
Enable several more checkstyle modules
...
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
5 years ago
7578ee9537
Enable checkstyle's Indentation module
5 years ago
fabed228da
Enable EqualsAvoidNull in checkstyle
5 years ago
3c5735e03e
Fix null exception when creating a new podcast channel
...
Until the podcast channel has been updated to provide it with a title, there
is no point to doing any further processing since the directory where episodes
are stored is derived from the title.
While this change is unrelated to #176 , it fixes the traceback shown in that
issue.
5 years ago
8ba97026a4
Synchronize on activeAudioPlayers when changing them
5 years ago
e7bd5da6fa
Precompile jsp
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
ff08f6dd02
Fix #1139
5 years ago
093f7c028d
Fix podcast download issues
...
Some podcast feeds use circular redirects (with query parameters).
Fixes #1013
Avoids HttpClient cookie handling producing "Invalid cookie" errors due to
not handling latest "expires" attribute formats.
5 years ago
3b8993e860
Replace Hashtable with HashMap, since Hashtable are deprecated
5 years ago
073b7e35e1
Add simple test cases for internet radios
5 years ago
19082afc11
Mark cached internet radio sources as a final variable
5 years ago
53b174a8f4
Follow HTTP redirects when loading internet radio playlists
5 years ago
760a6e957a
Limit the amount of data we parse from remote internet radio playlists
5 years ago
b1185601d5
Tweak logging for internet radio playlists
5 years ago
aeabfa1044
Add internet radio source cache
...
This helps us avoid loading and parsing the external playlists each time
we try to load an internet radio.
5 years ago
cab3f60a25
Refactor internet radio loading into a service
5 years ago
59db5073e3
Added webm to default video file types
5 years ago
767b39ed5b
Split SearchService
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
1640411573
Fix some invalid/incomplete javadoc comments
5 years ago
643be3930f
Remove superfluous casts
5 years ago
3202a1086d
Minor simplification
...
`.sorted(Comparator.reverseOrder()).findFirst()`
can be replaced with `max(Comparator.naturalOrder()`
5 years ago
def5f854fb
Inline some variables
...
There is no point in `Type a = …; return a;`
5 years ago
57df709cd8
Replace things like size == 0 with isEmpty
5 years ago
977b656bc6
Remove superfluous escape in two regexp
5 years ago
3492fc0c05
Fix a crash when transcoding a track without album
5 years ago
b1eb0536b8
Fix a crash when transcoding a track without artist
5 years ago
b697dc5bfc
An other batch of LGTM-found issues
5 years ago
1c4a70af99
Fixed null check with StringUtils/ObjectUtils.
5 years ago
3efa2d3e2c
Remove the option to never set Content-Length
...
This workaround is obsolete with correct handling of ranges when
requested.
5 years ago
8a90d9f77b
Add system properties for persisting the 'remember me' key
...
This adds the 'airsonic.rememberMeKey' system property (can be set from
command-line with `-Dairsonic.rememberMeKey=<value>`) as well as a
'RememberMeKey' setting in airsonic.properties, so that the key used for
generating 'remember me' tokens can be persisted across server restarts.
It also adds a default, insecure key in case we are running in
development mode with the 'airsonic.development' property set.
5 years ago
3d54ef1afb
Mark the player cookie httpOnly
...
It doesn't improve much security-wise,
but it's a good practise anyway.
5 years ago
8123716d52
Remove unused loggers
5 years ago
4a06823057
Balance some synchronized
...
Balance synchronized used on getters and not setters
as well as the other way around.
5 years ago
a3e59e9724
Fix file encoding
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
a21188a064
Add a permission check for the podcast folder
...
This should make podcast-related stacktraces a bit
more obvious to debug for users.
5 years ago
133cf666b7
Fix processing when artist and albumArtist are null
5 years ago
f5f1ec336f
Fix to get fields when file format is ID3v2.4
5 years ago
4cd9e9deac
revert cling-core, cling-support, seamless-util and configuration
5 years ago
910802b64f
Fix a small resource leak
5 years ago
30fa4d0467
Second pass of trivial modernizations
...
- Replace unnecessary getters/setters with inline assignments
- Simplify string constructions
- Improve containers construction
5 years ago
ca489f8220
This is a first batch of simple modernization of the codebase
...
I threw airsonic at IntelliJ's IDEA analysis,
and asked it to flag what could be modernized
for Java > 5.
- foreach instead of for…
- I added some null-deref checks
- Integer.ValueOf, since Integer(…) is deprecated
- Contextual try
- Objects.equals instead of handcrafted comparisons
- StringBuilder instead of StringBuffer
- Removal of outdated/wrong javadoc comments
5 years ago
07daf86bf0
Add m4b to m4a locations in java
...
anywhere m4a is referenced in java code add support for m4b as well.
Signed-off-by: <senorsmartypants@gmail.com>
5 years ago
c0f3606091
Force database checkpoints on 'Clean-up' and 'Scan' actions
...
This will only affect the (embedded/legacy) HSQLDB driver. Even though
cff97ea9
5 years ago
1a88f46c18
CVE-2018-20222 Prevent xxe during parse
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
ac0e29bf9c
Remove unused import
6 years ago
61c0c0d758
Fix import style error
6 years ago
Evan Harris
tesshucom
jvoisin
Andrew DeMaria
François-Xavier Thomas
jvoisin
Peter Marheine
SenorSmartyPants