jvoisin and GitHub
3d8f3ed21d
Gracefully handle failed version check attempts
...
This issue what found by darkling, and reported on irc
2019-09-19 19:54:58 +00:00
jvoisin
53d835e6ed
Make the logout icon/image cliquable
...
This should close #1178
2019-09-19 20:49:45 +02:00
Evan Harris and Andrew DeMaria
b02fd9ad6c
Change integration tests from parallel to single
...
This is an attempt to make the Travis CI integration tests more reliable,
and changes from parallel to single forking mode.
This is a temporary measure until cucumber-jvm-parallel-plugin (which is no
longer supported) is ripped out (see #1240 )
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-09-18 22:23:51 -06:00
Evan Harris
d4aff1dca5
Added checkstyle to prohibit windows line endings
...
Suggestion taken from jvoisin in #1121 .
2019-09-13 13:11:01 -05:00
tesshucom and Andrew DeMaria
5c3c558923
Update Lucene from 3.0.3 to the current version 8.2.0
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-09-12 16:33:44 -06:00
Sid and Andrew DeMaria
8e279a2d2a
Fix to clean up docker instance on RunTimeException in Integration Tests
...
Signed-off-by: Sid <shyamindra@gmail.com >
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-09-10 14:44:10 -06:00
Celedhrim and Andrew DeMaria
c16fa9d159
Update db-changelog.xml to support mariadb
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-09-10 14:22:43 -06:00
jvoisin and Andrew DeMaria
c6540d707e
Simplify a bit the annotations
...
There is no need to specify `value` every single time
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-09-10 13:51:35 -06:00
jvoisin and Evan Harris
eb4c5a04ff
Make the systemd unit compatible with tomcat9
...
- Use ReadWritePaths by default, since it doesn't
cause any harm
- Rephrase the ProtectSystem comment, to make it more clear
- Fix verbs in a comment
2019-09-03 04:54:43 -05:00
Evan Harris
83ca97e21c
Improve error handling for jaudiotaggerParser artwork fetch
2019-09-01 13:24:26 -05:00
jvoisin
6f57c6e313
Remove an unused/unuseable/half-done cache
2019-09-01 18:11:48 +02:00
jvoisin
46d806df1d
Fix two issues found by LGTM
2019-09-01 18:11:48 +02:00
jvoisin
c0fa01206a
Ignore yet an other jackson vulnerability
2019-09-01 18:11:48 +02:00
jvoisin and GitHub
e085d77635
Remove use useless arrays creation
2019-09-01 15:16:14 +00:00
Evan Harris
4679bac08d
Added handling for LyricsService ConnectTimeoutException
2019-08-31 08:44:25 -05:00
Evan Harris
73768b94ea
Handle Lyrics fetch HttpResponseException
...
Also marked 503 error as retryable and added log message for socket error
2019-08-31 08:44:10 -05:00
Shen-Ta Hsieh
394dfa1ce7
upgrade jackson-databind and commons-beanutils for CVEs
...
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com >
2019-08-31 15:40:59 +08:00
Shen-Ta Hsieh
16c1e42b97
normalize license expire date to prevent outstanding value on Java 12
...
Date(Long.MAX_VALUE) is 292278994-08-17T07:12:55.807Z on Java 12, and
make Ultrasonic failed to parse.
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com >
2019-08-31 10:11:30 +08:00
Evan Harris
6e8ae8971c
Enable checkstyle OverloadMethodsDeclarationOrder
2019-08-16 18:08:42 -05:00
Evan Harris
1acfacb4c6
Enable checkstyle FileTabCharacter
2019-08-15 18:40:04 -05:00
Evan Harris and jvoisin
16039d5e81
Enable checkstyle UniqueProperties
2019-08-15 22:07:53 +00:00
Evan Harris and jvoisin
fcc68febc8
Enable several more code checkstyles
2019-08-15 22:07:32 +00:00
Evan Harris and jvoisin
389db3f1b4
Enable checkstyle for simple boolean expressions
2019-08-11 20:10:06 +00:00
Evan Harris and jvoisin
f738819625
Enable additional checkstyles for whitespace
...
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
2019-08-11 20:09:40 +00:00
Evan Harris and jvoisin
86a5b8708d
Enable checkstyle OneStatementPerLine
2019-08-08 21:26:01 +00:00
Evan Harris and jvoisin
153ad19b6b
Enable several more checkstyle modules
...
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
2019-08-07 22:46:10 +00:00
jvoisin and GitHub
7578ee9537
Enable checkstyle's Indentation module
2019-08-07 20:13:29 +00:00
jvoisin and GitHub
fabed228da
Enable EqualsAvoidNull in checkstyle
2019-08-07 19:12:04 +00:00
Evan Harris and jvoisin
3c5735e03e
Fix null exception when creating a new podcast channel
...
Until the podcast channel has been updated to provide it with a title, there
is no point to doing any further processing since the directory where episodes
are stored is derived from the title.
While this change is unrelated to #176 , it fixes the traceback shown in that
issue.
2019-08-07 09:14:18 +00:00
jvoisin
49c6e89f73
Ignore CVE-2019-14439 too
2019-08-07 02:09:52 +02:00
jvoisin
8260fed1b3
Ignore CVE-2019-14379
2019-08-07 01:57:54 +02:00
jvoisin
b650ac70d6
Temporarily skip a test
...
Based on tesshucom's #1192
2019-08-07 01:52:17 +02:00
jvoisin and GitHub
9a5f3f9483
Replace a now-defunct maven repo with a working one
2019-08-04 21:02:51 +00:00
jvoisin
4a85cdbc7a
Sort the checkstyle modules
2019-08-01 10:46:26 +02:00
jvoisin
0d6ed81b83
Add a check for InnerAssignment in checkstyle.xml
2019-08-01 10:36:51 +02:00
jvoisin
ba9d3ff539
Remove an empty statement
2019-08-01 10:30:26 +02:00
jvoisin
61c8fbc5e2
Add more style checks
2019-08-01 10:21:54 +02:00
jvoisin
10b41160c0
Enabled StringLiteralEquality in CheckStyle
2019-07-31 00:26:58 +02:00
jvoisin
167d1d9c20
Enable EqualsHashCode in CheckStyle
2019-07-31 00:23:18 +02:00
jvoisin and GitHub
8ba97026a4
Synchronize on activeAudioPlayers when changing them
2019-07-27 16:28:51 +00:00
Andrew DeMaria and jvoisin
e7bd5da6fa
Precompile jsp
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-07-27 16:25:59 +00:00
tesshucom and Andrew DeMaria
ff08f6dd02
Fix #1139
2019-07-25 19:26:01 -06:00
Evan Harris
093f7c028d
Fix podcast download issues
...
Some podcast feeds use circular redirects (with query parameters).
Fixes #1013
Avoids HttpClient cookie handling producing "Invalid cookie" errors due to
not handling latest "expires" attribute formats.
2019-07-24 23:30:40 -05:00
jvoisin
d256386cbb
Use titles in some <img> tags
2019-07-22 22:49:11 +02:00
Evan Harris and jvoisin
bf309e9117
Fixup eccb7e08f5 ( #1170 )
2019-07-17 22:48:41 +00:00
jvoisin and Andrew DeMaria
eccb7e08f5
Fix a NULL-deref in CoverArtController.java
...
ImageIO.read() can return null in certain cases
2019-07-14 11:54:30 -06:00
jvoisin and Andrew DeMaria
e9ea61036f
First pass of CSP-compliance for mousetrap
...
Since the preference for the keyboard shortcuts
is set server-side, I had to shove them into a non-javascript
context, and then access them via javascript,
in a separate file.
Since I'm not a javascript expert, I'm more than open
to alternatives if this isn't the right way™ to do it.
2019-07-14 11:46:28 -06:00
Andrew DeMaria
cb8fc14858
Some release note fixes
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-07-13 18:12:01 -06:00
Andrew DeMaria
859d08fc02
Bump version
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com >
2019-07-13 18:10:18 -06:00
Andrew DeMaria
5d459d20e9
Add date for changelog
2019-07-13 17:58:14 -06:00