Evan Harris
0660c4f3e6
Renamed StringUtil.formatDuration to formatDurationMSS
5 years ago
jvoisin
d3a9a3226f
Replace deprecated Date by Calendar
...
Apparently, Date.setYear and Date.getYear are deprecated in favour of Calendar, since Java6!
Source: https://docs.oracle.com/javase/6/docs/api/java/util/Date.html
5 years ago
jvoisin
d17c00115a
Minor refactor of CsrfSecurityRequestMatcher
...
- use plain string comparison instead of regexp
- Simplify data structures
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
78480ab766
Remove a homemade implementation of Pair
...
Since apache-commons is already implementing a Pair
type, there is no need to reinvent the wheel.
5 years ago
jvoisin
c25e26d61a
Remove a dead file
5 years ago
jvoisin
06e36ff154
Mark a field as private
...
Since we're synchronising on playQueue, we should make
it final.
5 years ago
François-Xavier Thomas
8b72964086
Display file id and path in debug scanning logs
5 years ago
jvoisin
b6414ebb6c
Simplify a condition
5 years ago
jvoisin
9f027f333e
Upgrade PlaylistService to non-deprecated methods
...
As documented here: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/Assert.html#notNull-java.lang.Object-java.lang.String-
5 years ago
Andrew DeMaria
3fe6e8b267
Add logger name checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
f644f5a1d0
Improved handling of missing/failed transcoder
...
Fixes #659 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
6783ced897
Removed inability to change roles for admin user
5 years ago
jvoisin
6f590f7740
Check the return value of `delete` calls
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Kessiler Rodrigues
4b3890f6ec
Replace custom circular buffer with Apache commons(CircularFifoQueue)
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
42b4aaafc7
Use EnumMap in IndexManager
...
EnumMap are _much_ more efficient than HashMaps,
so we should use them if we can.
See here for more details: https://docs.oracle.com/javase/8/docs/api/java/util/EnumMap.html
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
da34bf0d3f
Improve Windows system detection
...
Use apache commons instead of terrifyingly fragile black magic.
5 years ago
jvoisin
85e0e08d9a
Remove radeox
...
Radeox is a rendering engine for an unspecified markup.
Its [website](http://radeox.org/ ) is dead, the website
of its [authors](http://www.codehaus.org/ ) is dead too,
its [last commit](https://github.com/codehaus/radeox ) was 13 years ago.
It's only used for the welcome and login messages,
as well as comments from users. If we want to have some markup parsing,
we should use something maintained with autoescaping guarantees,
instead of a piece of zombie code prone to $DEITY knows what injections.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
e5404648a4
Remove unnecessary exceptions and unused imports
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
dddf8dc0aa
Fix some javadoc comments
...
- Remove a dangling comment
- Delete half-documented parameters
- Fix some @see/@link
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
889add6848
More lambdaification
5 years ago
jvoisin
362cf29e41
Fix some javadoc comments
...
- Remove a dangling comment
- Delete half-documented parameters
- Fix some @see/@link
5 years ago
Andrew DeMaria
45d789b64e
Option to disable timestamps during scan
...
I accidentally deleted most of my music directory. The database was
still intact. I recovered the music directory by rolling back to a
previous ZFS snapshot and performed a reindex. However, libresonic did
not mark the deleted files as present. Turns out the file timestamp was
unchanged through the ZFS restore, and so libresonic still thought the
last indexing effort was still "good".
This adds the option to ignore file timestamps when scanning files. This
can be helpful in the case of a restore as described above. There might
be a better way to do this, as this was really a quick effort on my part
to fix my own libresonic.
This does not add a UI, just a single property that can be turned on by
editing the lilbresonic.properties file.
@fxthomas suggested this could instead be a query parameter on the
initial issue #359 . That would basically move the potential UI to the
scan page. That would be fine, but I could imagine there might be cases
where people want this setting on all the time.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
41967e76df
Media file scan will now heed configured music/video file types
...
It will also now heed the Media Folders -> Exclude Pattern. Fixes #1227 .
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
1b28d2c2fe
Handle nulls when processing cover art better
...
This expands on commit d4487a07a0fcacea1544d61c79a380f2e9bf3087.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
dd1e0181d1
Please checkstyle
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
af05b0f45b
Use lambdas instead of ghetto nested types
...
This change was done in an automated fashion
via IntelliJ IDEA
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
25327c69cc
Replace deprecated IOUtils.closeQuietly calls
...
Use FileUtil.closeQuietly instead, since it's our reimplemented of this deprecated method.
This change was done automatically via IntelliJ IDEA.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
tesshucom
645fb88c7d
Add expunge to IndexManager
...
When DB expunge is invoked from the management screen,
also indexManager performs expunge.
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
c6ae5a1df7
Use `computeIfAbsent` instead of an `if`
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
888204ffe7
Remove an unused import
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
c0beca6a58
Use `removeIf` instead of doing this manually
5 years ago
Jon Borglund
f77a0d8b67
fixed 'Settings Saved' notification when saving transcoding settings #1114 ( #1269 )
...
Signed-off-by: Jon <jon@powha.net>
5 years ago
jvoisin
bc832d0034
Use a constant for encoding
...
Replace string.getBytes("UTF-8") with
string.getBytes(CONSTANT).
5 years ago
jvoisin
3d8f3ed21d
Gracefully handle failed version check attempts
...
This issue what found by darkling, and reported on irc
5 years ago
Evan Harris
d4aff1dca5
Added checkstyle to prohibit windows line endings
...
Suggestion taken from jvoisin in #1121 .
5 years ago
tesshucom
5c3c558923
Update Lucene from 3.0.3 to the current version 8.2.0
...
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
jvoisin
c6540d707e
Simplify a bit the annotations
...
There is no need to specify `value` every single time
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
5 years ago
Evan Harris
83ca97e21c
Improve error handling for jaudiotaggerParser artwork fetch
5 years ago
jvoisin
6f57c6e313
Remove an unused/unuseable/half-done cache
5 years ago
jvoisin
46d806df1d
Fix two issues found by LGTM
5 years ago
jvoisin
e085d77635
Remove use useless arrays creation
5 years ago
Evan Harris
4679bac08d
Added handling for LyricsService ConnectTimeoutException
5 years ago
Evan Harris
73768b94ea
Handle Lyrics fetch HttpResponseException
...
Also marked 503 error as retryable and added log message for socket error
5 years ago
Shen-Ta Hsieh
16c1e42b97
normalize license expire date to prevent outstanding value on Java 12
...
Date(Long.MAX_VALUE) is 292278994-08-17T07:12:55.807Z on Java 12, and
make Ultrasonic failed to parse.
Signed-off-by: Shen-Ta Hsieh <ibmibmibm.tw@gmail.com>
5 years ago
Evan Harris
6e8ae8971c
Enable checkstyle OverloadMethodsDeclarationOrder
5 years ago
Evan Harris
1acfacb4c6
Enable checkstyle FileTabCharacter
5 years ago
Evan Harris
389db3f1b4
Enable checkstyle for simple boolean expressions
5 years ago
Evan Harris
f738819625
Enable additional checkstyles for whitespace
...
* Enable checkstyle WhitespaceAround
* Enable checkstyle NoWhitespaceBefore
* Enable checkstyle MethodParamPad
5 years ago
Evan Harris
86a5b8708d
Enable checkstyle OneStatementPerLine
5 years ago
Evan Harris
153ad19b6b
Enable several more checkstyle modules
...
* Enable checkstyle ParenPadCheck
* Enable checkstyle EmptyLineSeparator
* Enable checkstyle TypecastParenPad
5 years ago