Added checkstyle for trailing whitespace

This commit is contained in:
Evan Harris
2019-12-06 03:10:06 -06:00
parent 2d30a37208
commit f476fd7c33
29 changed files with 119 additions and 114 deletions
@@ -301,7 +301,7 @@ public class PlayQueueTestCase extends TestCase {
public String getAlbumName() {
return album;
}
@Override
public File getFile() {
return new File(name);
@@ -81,7 +81,7 @@ public abstract class AbstractAirsonicHomeTest implements AirsonicHomeTest {
public AtomicBoolean dataBaseReady() {
return dataBaseReady;
}
@Override
public final void populateDatabaseOnlyOnce() {
if (!dataBasePopulated().get()) {
@@ -13,7 +13,7 @@ public interface AirsonicHomeTest {
/**
* MusicFolder used by test class.
*
*
* @return MusicFolder used by test class
*/
default List<MusicFolder> getMusicFolders() {
@@ -22,7 +22,7 @@ public interface AirsonicHomeTest {
/**
* Whether the data input has been completed.
*
*
* @return Static AtomicBoolean indicating whether the data injection has been
* completed
*/
@@ -30,12 +30,12 @@ public interface AirsonicHomeTest {
/**
* Whether the data input has been completed.
*
*
* @return Static AtomicBoolean indicating whether the data injection has been
* completed
*/
abstract AtomicBoolean dataBaseReady();
/**
* Populate the database only once.
* It is called in the @Before granted method.
@@ -156,7 +156,7 @@ public class AnalyzerFactoryTestCase {
/**
* Detailed tests on Stopward.
*
*
* @see org.apache.lucene.analysis.core.StopAnalyzer#ENGLISH_STOP_WORDS_SET
*/
@Test
@@ -275,7 +275,7 @@ public class AnalyzerFactoryTestCase {
terms = toTermString(queryFullWidth);
/*
* XXX 3.x -> 8.x :
*
*
* This is not a change due to the library but an intentional change.
* The filter order has been changed properly
* as it is probably not a deliberate specification.
@@ -477,7 +477,7 @@ public class AnalyzerFactoryTestCase {
assertEquals("walker", terms.get(2));
assertEquals("nash", terms.get(3));
assertEquals("ensemble", terms.get(4));
// Space
assertEquals(asList("abc", "def"), toTermString(" ABC DEF "));
assertEquals(asList("abc1", "def"), toTermString(" ABC1 DEF "));
@@ -655,7 +655,7 @@ public class AnalyzerFactoryTestCase {
assertEquals(1, terms.size());
assertEquals("{ }", terms.get(0));
}
private List<String> toTermString(String str) {
return toTermString(null, str);
}
@@ -174,7 +174,7 @@ public class IndexManagerTestCase extends AbstractAirsonicHomeTest {
indexManager.expunge();
indexManager.stopIndexing(indexManager.getStatistics());
/*
/*
* Subsequent search results.
* Results can also be confirmed with Luke.
*/
@@ -65,7 +65,7 @@ public class QueryFactoryTestCase {
private static final MusicFolder MUSIC_FOLDER1 =
new MusicFolder(FID1, new File(PATH1), "music1", true, new java.util.Date());
private static final MusicFolder MUSIC_FOLDER2 =
private static final MusicFolder MUSIC_FOLDER2 =
new MusicFolder(FID2, new File(PATH2), "music2", true, new java.util.Date());
private static final List<MusicFolder> SINGLE_FOLDERS = Arrays.asList(MUSIC_FOLDER1);
@@ -76,7 +76,7 @@ public class QueryFactoryTestCase {
* XXX 3.x -> 8.x :
* It does not change the basic functional requirements for the query.
* However, some minor improvements are included.
*
*
* - Use 'Or' instead of 'SpanOr'.
* This is suitable for 8.x document definition and query grammar.
* A more rigorous comparison.
@@ -89,7 +89,7 @@ public class QueryFactoryTestCase {
* Currently, these are "key" strings, both in the requirements and in the implementation.
* The legacy "normalize" is dirty code that compensates for the incomplete analytics implementation
* and is not necessary as long as proper key comparison can be done.
*
*
* => Treating these strictly as keys enables DB reference.
* For example, can support multi-genre by creating a new genre field that implements another Tokenizer.
*
@@ -48,12 +48,12 @@ public class SearchServiceSpecialGenreTestCase extends AbstractAirsonicHomeTest
* in src/test/resources/MEDIAS/Search/SpecialGenre/ARTIST1/ALBUM_A.
* In FILE01 to FILE16, Special strings for Lucene syntax are stored
* as tag values of Genre.
*
*
* Legacy can not search all these genres.
* (Strictly speaking, the genre field is not created at index creation.)
*
* // XXX 3.x -> 8.x : Do the process more strictly.
*
*
* - Values that can be cross-referenced with DB are stored in the index.
* - Search is also possible with user's readable value (file tag value).
* - However, there is an exception in parentheses.
@@ -91,10 +91,10 @@ public class SearchServiceSpecialGenreTestCase extends AbstractAirsonicHomeTest
/*
* // XXX 3.x -> 8.x : Brackets ()
*
*
* Lucene can handle these.
* However, brackets are specially parsed before the index creation process.
*
*
* This string is never stored in the index.
* This is the only exception.
*/
@@ -106,16 +106,16 @@ public class SearchServiceSpecialGenreTestCase extends AbstractAirsonicHomeTest
/*
* // XXX 3.x -> 8.x : Brackets {}[]
*
*
* Lucene can handle these.
* However, brackets are specially parsed before the index creation process.
*
*
* This can be done with a filter that performs the reverse process
* on the input values when searching.
* As a result, the values stored in the file can be retrieved by search.
*
*
* @see AnalyzerFactory
*
*
* >>>>>
*/
songs = searchService.getRandomSongs(simpleStringCriteria.apply("{}"));
@@ -204,7 +204,7 @@ public class SearchServiceSpecialGenreTestCase extends AbstractAirsonicHomeTest
/*
* Search by genre string registered in file.
*
*
* The value stored in the index is different from legacy.
* Domain value is kept as it is.
*/
@@ -256,12 +256,12 @@ public class SearchServiceSpecialGenreTestCase extends AbstractAirsonicHomeTest
/*
* Other special strings. (FILE19)
*
*
* {'“『【【】】[︴○◎@ $〒→+]FULL-WIDTHCæsar's
*
*
* Legacy stores with Analyze,
* so searchable characters are different.
*
*
*/
@Test
public void testOthers() {
@@ -20,10 +20,10 @@ import static org.springframework.util.ObjectUtils.isEmpty;
/*
* Test cases related to #1139.
* Confirming whether shuffle search can be performed correctly in MusicFolder containing special strings.
*
*
* (Since the query of getRandomAlbums consists of folder paths only,
* this verification is easy to perform.)
*
*
* This test case is a FalsePattern for search,
* but there may be problems with the data flow prior to creating the search index.
*/
@@ -20,7 +20,7 @@ import static org.springframework.util.ObjectUtils.isEmpty;
/*
* Test cases related to #1142.
* The filter is not properly applied when analyzing the query,
*
*
* In the process of hardening the Analyzer implementation,
* this problem is solved side by side.
*/
@@ -55,7 +55,7 @@ public class SearchServiceTestCase extends AbstractAirsonicHomeTest {
List<MusicFolder> allMusicFolders = musicFolderDao.getAllMusicFolders();
Assert.assertEquals(3, allMusicFolders.size());
// *** testSearch() ***
String query = "Sarah Walker";