Check the return value of delete calls
Signed-off-by: Andrew DeMaria <lostonamountain@gmail.com>
This commit is contained in:
@@ -160,7 +160,9 @@ public class CoverArtService {
|
|||||||
private void backup(File newCoverFile, File backup) {
|
private void backup(File newCoverFile, File backup) {
|
||||||
if (newCoverFile.exists()) {
|
if (newCoverFile.exists()) {
|
||||||
if (backup.exists()) {
|
if (backup.exists()) {
|
||||||
backup.delete();
|
if (!backup.delete()) {
|
||||||
|
LOG.warn("Failed to delete " + backup);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
if (newCoverFile.renameTo(backup)) {
|
if (newCoverFile.renameTo(backup)) {
|
||||||
LOG.info("Backed up old image file to " + backup);
|
LOG.info("Backed up old image file to " + backup);
|
||||||
|
|||||||
+1
-2
@@ -90,8 +90,7 @@ public class BootstrapVerificationFilter implements Filter {
|
|||||||
private boolean directoryWritable(File dir) {
|
private boolean directoryWritable(File dir) {
|
||||||
try {
|
try {
|
||||||
File tempFile = File.createTempFile("test", null, dir);
|
File tempFile = File.createTempFile("test", null, dir);
|
||||||
tempFile.delete();
|
return tempFile.delete();
|
||||||
return true;
|
|
||||||
} catch (IOException x) {
|
} catch (IOException x) {
|
||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -579,7 +579,9 @@ public class PodcastService {
|
|||||||
if (isEpisodeDeleted(episode)) {
|
if (isEpisodeDeleted(episode)) {
|
||||||
LOG.info("Podcast " + episode.getUrl() + " was deleted. Aborting download.");
|
LOG.info("Podcast " + episode.getUrl() + " was deleted. Aborting download.");
|
||||||
FileUtil.closeQuietly(out);
|
FileUtil.closeQuietly(out);
|
||||||
file.delete();
|
if (!file.delete()) {
|
||||||
|
LOG.warn("Unable to delete " + file);
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
addMediaFileIdToEpisodes(Arrays.asList(episode));
|
addMediaFileIdToEpisodes(Arrays.asList(episode));
|
||||||
episode.setBytesDownloaded(bytesDownloaded);
|
episode.setBytesDownloaded(bytesDownloaded);
|
||||||
|
|||||||
Reference in New Issue
Block a user