From 4098d801fcba5a99a325264b7c6c58d975080d27 Mon Sep 17 00:00:00 2001 From: Evan Harris Date: Sun, 20 Oct 2019 02:54:21 -0500 Subject: [PATCH] Fixed a bunch of quoting issues in jsp files All the quoting issues were causing PMD violations. A few other things that were noticed along the way were fixed too. --- .../main/webapp/WEB-INF/jsp/accessDenied.jsp | 2 +- .../webapp/WEB-INF/jsp/advancedSettings.jsp | 10 +-- .../src/main/webapp/WEB-INF/jsp/albumMain.jsp | 42 ++++++------ .../main/webapp/WEB-INF/jsp/artistMain.jsp | 30 ++++----- .../webapp/WEB-INF/jsp/avatarUploadResult.jsp | 2 +- .../webapp/WEB-INF/jsp/changeCoverArt.jsp | 16 ++--- .../src/main/webapp/WEB-INF/jsp/coverArt.jsp | 6 +- .../main/webapp/WEB-INF/jsp/createShare.jsp | 6 +- .../webapp/WEB-INF/jsp/databaseSettings.jsp | 8 +-- .../main/webapp/WEB-INF/jsp/dlnaSettings.jsp | 14 ++-- .../src/main/webapp/WEB-INF/jsp/editTags.jsp | 8 +-- .../src/main/webapp/WEB-INF/jsp/error.jsp | 2 +- .../webapp/WEB-INF/jsp/externalPlayer.jsp | 6 +- .../webapp/WEB-INF/jsp/generalSettings.jsp | 10 +-- .../webapp/WEB-INF/jsp/gettingStarted.jsp | 2 +- .../src/main/webapp/WEB-INF/jsp/head.jsp | 18 +++--- .../src/main/webapp/WEB-INF/jsp/help.jsp | 8 +-- .../src/main/webapp/WEB-INF/jsp/home.jsp | 4 +- .../src/main/webapp/WEB-INF/jsp/homePager.jsp | 8 +-- .../webapp/WEB-INF/jsp/importPlaylist.jsp | 2 +- .../WEB-INF/jsp/internetRadioSettings.jsp | 10 +-- .../jsp/javaJukeboxPlayerControlBar.jspf | 6 +- .../src/main/webapp/WEB-INF/jsp/jquery.jsp | 6 +- .../src/main/webapp/WEB-INF/jsp/left.jsp | 12 ++-- .../src/main/webapp/WEB-INF/jsp/login.jsp | 10 +-- .../src/main/webapp/WEB-INF/jsp/lyrics.jsp | 10 +-- .../src/main/webapp/WEB-INF/jsp/more.jsp | 28 ++++---- .../WEB-INF/jsp/musicFolderSettings.jsp | 8 +-- .../src/main/webapp/WEB-INF/jsp/notFound.jsp | 2 +- .../webapp/WEB-INF/jsp/passwordSettings.jsp | 4 +- .../webapp/WEB-INF/jsp/personalSettings.jsp | 12 ++-- .../main/webapp/WEB-INF/jsp/playButtons.jsp | 32 +++++----- .../src/main/webapp/WEB-INF/jsp/playQueue.jsp | 64 +++++++++---------- .../webapp/WEB-INF/jsp/playerSettings.jsp | 10 +-- .../src/main/webapp/WEB-INF/jsp/playlist.jsp | 22 +++---- .../src/main/webapp/WEB-INF/jsp/playlists.jsp | 2 +- .../webapp/WEB-INF/jsp/podcastChannel.jsp | 2 +- .../webapp/WEB-INF/jsp/podcastChannels.jsp | 4 +- .../webapp/WEB-INF/jsp/podcastSettings.jsp | 4 +- .../src/main/webapp/WEB-INF/jsp/rating.jsp | 6 +- .../src/main/webapp/WEB-INF/jsp/recover.jsp | 2 +- .../src/main/webapp/WEB-INF/jsp/right.jsp | 10 +-- .../src/main/webapp/WEB-INF/jsp/search.jsp | 2 +- .../webapp/WEB-INF/jsp/settingsHeader.jsp | 2 +- .../main/webapp/WEB-INF/jsp/shareSettings.jsp | 4 +- .../main/webapp/WEB-INF/jsp/sonosSettings.jsp | 14 ++-- .../src/main/webapp/WEB-INF/jsp/starred.jsp | 10 +-- .../src/main/webapp/WEB-INF/jsp/status.jsp | 10 +-- .../src/main/webapp/WEB-INF/jsp/top.jsp | 34 +++++----- .../WEB-INF/jsp/transcodingSettings.jsp | 18 +++--- .../main/webapp/WEB-INF/jsp/userSettings.jsp | 10 +-- .../src/main/webapp/WEB-INF/jsp/videoMain.jsp | 4 +- .../main/webapp/WEB-INF/jsp/videoPlayer.jsp | 18 +++--- .../main/webapp/WEB-INF/jsp/viewSelector.jsp | 8 +-- 54 files changed, 302 insertions(+), 302 deletions(-) diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/accessDenied.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/accessDenied.jsp index d000c6a5..7ef30f79 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/accessDenied.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/accessDenied.jsp @@ -8,7 +8,7 @@

- " alt=""/> +

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/advancedSettings.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/advancedSettings.jsp index 954d270f..4f1c826e 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/advancedSettings.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/advancedSettings.jsp @@ -4,7 +4,7 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - + - + + @@ -167,8 +167,8 @@

- " style="margin-right:0.3em"> - "> + + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/albumMain.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/albumMain.jsp index a7e7742a..33b2490d 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/albumMain.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/albumMain.jsp @@ -5,12 +5,12 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - - - - - - + + + + + + @@ -103,12 +103,12 @@ } function toggleStar(mediaFileId, imageId) { - if ($(imageId).attr("src").indexOf("") != -1) { - $(imageId).attr("src", ""); + if ($(imageId).attr("src").indexOf("") != -1) { + $(imageId).attr("src", ""); starService.unstar(mediaFileId); } - else if ($(imageId).attr("src").indexOf("") != -1) { - $(imageId).attr("src", ""); + else if ($(imageId).attr("src").indexOf("") != -1) { + $(imageId).attr("src", ""); starService.star(mediaFileId); } } @@ -153,7 +153,7 @@ } playlistService.appendToPlaylist(playlistId, mediaFileIds, function (){ top.left.updatePlaylists(); - $().toastmessage("showSuccessToast", ""); + $().toastmessage("showSuccessToast", ""); }); } function showAllAlbums() { @@ -163,7 +163,7 @@

- " + @@ -239,27 +239,27 @@ - " style="height:18px;" alt=""> + | - + - + - + - + Google | @@ -292,7 +292,7 @@ - "> +

@@ -460,7 +460,7 @@ - " onclick="showAllAlbums()"> + @@ -480,7 +480,7 @@ - " onclick="showAllAlbums()"> + @@ -498,7 +498,7 @@ -
" style="display: none;"> + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/artistMain.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/artistMain.jsp index a771d939..fc212a24 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/artistMain.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/artistMain.jsp @@ -25,11 +25,11 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - - - - - + + + + + @@ -164,7 +164,7 @@

- " + @@ -215,7 +215,7 @@ - "> +

@@ -243,7 +243,7 @@ - " onclick="showAllAlbums()"> + @@ -285,7 +285,7 @@ - " onclick="showAllAlbums()"> +
@@ -308,8 +308,8 @@ - " onclick="playSimilar()"> - " onclick="playAllTopSongs()"> + + @@ -320,16 +320,16 @@ - " + - " alt="" title="" + <fmt:message key='common.play'/> - " alt="" title="" + <fmt:message key='common.add'/> - " alt="" title="" + <fmt:message key='main.addnext'/> Rank Title diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/avatarUploadResult.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/avatarUploadResult.jsp index 4b1973b5..49b42f2c 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/avatarUploadResult.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/avatarUploadResult.jsp @@ -7,7 +7,7 @@

- " alt=""/> +

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/changeCoverArt.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/changeCoverArt.jsp index 4351b380..ac8c1396 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/changeCoverArt.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/changeCoverArt.jsp @@ -3,9 +3,9 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - - - + + + - - + + @@ -118,8 +118,8 @@

- " style="margin-right:0.3em"> - "> + +

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/dlnaSettings.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/dlnaSettings.jsp index 06650885..9450659b 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/dlnaSettings.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/dlnaSettings.jsp @@ -21,12 +21,12 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - + - - + + @@ -47,7 +47,7 @@
"/> + value=""/>

@@ -56,15 +56,15 @@

" /> + value="" />

- " style="margin-right:0.3em"> - "> + +

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/editTags.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/editTags.jsp index c3816b21..85e1922a 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/editTags.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/editTags.jsp @@ -2,9 +2,9 @@ <%@ include file="head.jsp" %> - - - + + + @@ -159,6 +159,6 @@ -

" onclick="updateTags()"/>

+

\ No newline at end of file diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/error.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/error.jsp index 11c4ae28..1d7383be 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/error.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/error.jsp @@ -12,7 +12,7 @@

- " alt=""/> + Error

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/externalPlayer.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/externalPlayer.jsp index 1ea047f2..0efc1001 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/externalPlayer.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/externalPlayer.jsp @@ -5,9 +5,9 @@ <%@ include file="head.jsp" %> - - - "> + + + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/generalSettings.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/generalSettings.jsp index 6d65bddf..14332cbd 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/generalSettings.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/generalSettings.jsp @@ -4,12 +4,12 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - + - - + + @@ -156,8 +156,8 @@ - " style="margin-right:0.3em"> - "> + + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/gettingStarted.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/gettingStarted.jsp index 1efec8ee..a3df4877 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/gettingStarted.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/gettingStarted.jsp @@ -13,7 +13,7 @@

- " alt=""> +

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/head.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/head.jsp index c0c2c711..381f6ca7 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/head.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/head.jsp @@ -2,18 +2,18 @@ -"/> -"/> -"/> -"/> -" color="#2f7bd9"/> + + + + + -"> -" type="text/css"> + + Airsonic - - + + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/help.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/help.jsp index d06be4eb..a095eaa5 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/help.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/help.jsp @@ -3,7 +3,7 @@ <%@ include file="head.jsp" %> - + @@ -26,7 +26,7 @@

- " alt=""> +

@@ -39,7 +39,7 @@ ${versionString} – ${buildDateString} ${model.serverInfo} ( / ) - GPL 3.0"> + GPL 3.0 Airsonic website Airsonic on Reddit @@ -49,7 +49,7 @@

- " alt=""> +

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/home.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/home.jsp index 7f6459a3..2830dad8 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/home.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/home.jsp @@ -33,7 +33,7 @@

- " alt=""> + ${model.welcomeTitle}

@@ -64,7 +64,7 @@ <%@ include file="homePager.jsp" %> -
"> +
${model.welcomeMessage}
diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/homePager.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/homePager.jsp index 1df64f14..28d819f8 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/homePager.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/homePager.jsp @@ -6,7 +6,7 @@ -
; padding-left: 0.5em;padding-right: 0.5em"> +
${fn:escapeXml(model.musicFolder.name)}
@@ -39,11 +39,11 @@ - " alt=""> + - " alt=""> + @@ -77,7 +77,7 @@ - " alt="Shuffle" style="height:16px;"> + Shuffle diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/importPlaylist.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/importPlaylist.jsp index 7a3559b5..8ac49761 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/importPlaylist.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/importPlaylist.jsp @@ -31,7 +31,7 @@
- "/> +
diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/internetRadioSettings.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/internetRadioSettings.jsp index b702ee53..364ae02a 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/internetRadioSettings.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/internetRadioSettings.jsp @@ -39,17 +39,17 @@ - "/> - "/> - "/> + + + - " style="margin-right:0.3em"> - "> + + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/javaJukeboxPlayerControlBar.jspf b/airsonic-main/src/main/webapp/WEB-INF/jsp/javaJukeboxPlayerControlBar.jspf index 4a0af380..ea22c6a8 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/javaJukeboxPlayerControlBar.jspf +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/javaJukeboxPlayerControlBar.jspf @@ -11,8 +11,8 @@ - Start" onclick="onJavaJukeboxStart()" style="cursor:pointer"> - Pause" onclick="onJavaJukeboxStop()" style="cursor:pointer; display:none"> + Start + @@ -20,7 +20,7 @@ - " alt=""> +
diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/jquery.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/jquery.jsp index 080e7cd7..693cc713 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/jquery.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/jquery.jsp @@ -1,5 +1,5 @@ -" type="text/css"> -" type="text/css" > + + - + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/left.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/left.jsp index bed58f79..bf32c962 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/left.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/left.jsp @@ -3,9 +3,9 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - - - + + + - - + + + - - + + + - - + + @@ -138,8 +138,8 @@ <%--

--%>

- " style="margin-right:0.3em"> - "> + +

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/notFound.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/notFound.jsp index 2f3b53d2..b56f7c10 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/notFound.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/notFound.jsp @@ -8,7 +8,7 @@

- " alt=""/> +

diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/passwordSettings.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/passwordSettings.jsp index 3c4b6701..aa59976a 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/passwordSettings.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/passwordSettings.jsp @@ -37,8 +37,8 @@ - " style="margin-right:0.3em"> - "> + + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/personalSettings.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/personalSettings.jsp index 45d9ef80..d2c56044 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/personalSettings.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/personalSettings.jsp @@ -4,7 +4,7 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - + - + + @@ -207,8 +207,8 @@

- " style="margin-right:0.3em"/> - "> + +

@@ -247,7 +247,7 @@ - "/> + diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/playButtons.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/playButtons.jsp index 96770848..bd606fcd 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/playButtons.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/playButtons.jsp @@ -18,11 +18,11 @@ PARAMETERS - " alt="" style="cursor:pointer;height:18px;" + - " alt="" style="cursor:pointer;height:18px;" + @@ -37,16 +37,16 @@ PARAMETERS - " alt="" - title=""> + <fmt:message key='common.play'/> - " alt="" style="cursor:pointer; height:18px;" - onclick="${param.onPlay}; return false;" title=""> + <fmt:message key='common.play'/> - " alt="" style="cursor:pointer; height:18px;" - onclick="top.playQueue.onPlay(${param.id}); return false;" title=""> + <fmt:message key='common.play'/> @@ -54,17 +54,17 @@ PARAMETERS - " alt="" - onclick="top.playQueue.onAdd(${param.id}); $().toastmessage('showSuccessToast', ''); return false;" - style="cursor:pointer; height:18px;" title=""> + <fmt:message key='main.addlast'/> - " alt="" - onclick="top.playQueue.onAddNext(${param.id}); $().toastmessage('showSuccessToast', ''); return false;" - style="cursor:pointer; height:18px;" title=""> + <fmt:message key='main.addnext'/> @@ -74,7 +74,7 @@ PARAMETERS - " alt="" - title="" > + <fmt:message key='common.download'/> diff --git a/airsonic-main/src/main/webapp/WEB-INF/jsp/playQueue.jsp b/airsonic-main/src/main/webapp/WEB-INF/jsp/playQueue.jsp index 2c8a9261..1b37f4ce 100644 --- a/airsonic-main/src/main/webapp/WEB-INF/jsp/playQueue.jsp +++ b/airsonic-main/src/main/webapp/WEB-INF/jsp/playQueue.jsp @@ -3,14 +3,14 @@ <%@ include file="head.jsp" %> <%@ include file="jquery.jsp" %> - - - - - - - - + + + + + + + +