From 389db3f1b46722a146612d0ae41821136adb7aae Mon Sep 17 00:00:00 2001
From: Evan Harris <eharris@puremagic.com>
Date: Sun, 11 Aug 2019 15:10:07 -0500
Subject: [PATCH] Enable checkstyle for simple boolean expressions

---
 .../java/org/airsonic/player/controller/DownloadController.java | 2 +-
 .../main/java/org/airsonic/player/monitor/MetricsManager.java   | 2 +-
 checkstyle.xml                                                  | 2 ++
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/airsonic-main/src/main/java/org/airsonic/player/controller/DownloadController.java b/airsonic-main/src/main/java/org/airsonic/player/controller/DownloadController.java
index 48ac590c..6deb1e5c 100644
--- a/airsonic-main/src/main/java/org/airsonic/player/controller/DownloadController.java
+++ b/airsonic-main/src/main/java/org/airsonic/player/controller/DownloadController.java
@@ -240,7 +240,7 @@ public class DownloadController implements LastModified {
                 }
             }
         }
-        if (coverArtFile != null && coverArtFile.exists() && cover_embedded == false) {
+        if (coverArtFile != null && coverArtFile.exists() && !cover_embedded) {
             zip(out, coverArtFile.getParentFile(), coverArtFile, status, range);
         }
 
diff --git a/airsonic-main/src/main/java/org/airsonic/player/monitor/MetricsManager.java b/airsonic-main/src/main/java/org/airsonic/player/monitor/MetricsManager.java
index a719a2dc..862efae5 100644
--- a/airsonic-main/src/main/java/org/airsonic/player/monitor/MetricsManager.java
+++ b/airsonic-main/src/main/java/org/airsonic/player/monitor/MetricsManager.java
@@ -79,7 +79,7 @@ public class MetricsManager {
      */
     public TimerBuilder condition(boolean ifTrue) {
         if (metricsActivatedByConfiguration()) {
-            if (ifTrue == false) {
+            if (!ifTrue) {
                 return conditionFalseTimerBuilderSingleton;
             }
             return new TimerBuilder();
diff --git a/checkstyle.xml b/checkstyle.xml
index a6e1badf..f6edf1c7 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -38,6 +38,8 @@
         <module name="OneStatementPerLine"/>
         <module name="ParenPadCheck"/>
         <module name="RedundantImport"/>
+        <module name="SimplifyBooleanExpression"/>
+        <module name="SimplifyBooleanReturn"/>
         <module name="StringLiteralEquality"/>
         <module name="TypecastParenPad"/>
         <module name="UnusedImports"/>